From: Cristian Marussi <cristian.marussi@arm.com>
To: kernel test robot <lkp@intel.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev,
oe-kbuild-all@lists.linux.dev, sudeep.holla@arm.com,
vincent.guittot@linaro.org, peng.fan@oss.nxp.com,
michal.simek@amd.com, quic_sibis@quicinc.com,
quic_nkela@quicinc.com, souvik.chakravarty@arm.com
Subject: Re: [PATCH 06/11] firmware: arm_scmi: Implement Clock .is_notify_supported callback
Date: Tue, 13 Feb 2024 08:49:51 +0000 [thread overview]
Message-ID: <ZcstL8tRVKIUFoBr@pluto> (raw)
In-Reply-To: <202402131047.2NVZWHma-lkp@intel.com>
On Tue, Feb 13, 2024 at 10:58:23AM +0800, kernel test robot wrote:
> Hi Cristian,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on soc/for-next]
> [also build test ERROR on linus/master v6.8-rc4 next-20240212]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
Hi,
this series, as stated in the cover-letter, is based off the current tip of
sudeep/for-next/scmi/updates
and particularly needs commit:
9c5bc650031e firmware: arm_scmi: Rework clock domain info lookups
from there, since it contains the missing scmi_clock_domain_lookup().
Not_sure/dont_known if there is any way to convey this "based-on-branch"
info to your/any CI at the moment.
Thanks,
Cristian
> url: https://github.com/intel-lab-lkp/linux/commits/Cristian-Marussi/firmware-arm_scmi-Check-for-notification-support/20240212-203727
> base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
> patch link: https://lore.kernel.org/r/20240212123233.1230090-7-cristian.marussi%40arm.com
> patch subject: [PATCH 06/11] firmware: arm_scmi: Implement Clock .is_notify_supported callback
> config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20240213/202402131047.2NVZWHma-lkp@intel.com/config)
> compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project c08b90c50bcac9f3f563c79491c8dbcbe7c3b574)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240213/202402131047.2NVZWHma-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202402131047.2NVZWHma-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> >> drivers/firmware/arm_scmi/clock.c:853:8: error: call to undeclared function 'scmi_clock_domain_lookup'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 853 | clk = scmi_clock_domain_lookup(ci, src_id);
> | ^
> >> drivers/firmware/arm_scmi/clock.c:853:6: error: incompatible integer to pointer conversion assigning to 'struct scmi_clock_info *' from 'int' [-Wint-conversion]
> 853 | clk = scmi_clock_domain_lookup(ci, src_id);
> | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 2 errors generated.
>
>
> vim +/scmi_clock_domain_lookup +853 drivers/firmware/arm_scmi/clock.c
>
> 842
> 843 static bool scmi_clk_notify_supported(const struct scmi_protocol_handle *ph,
> 844 u8 evt_id, u32 src_id)
> 845 {
> 846 bool supported;
> 847 struct scmi_clock_info *clk;
> 848 struct clock_info *ci = ph->get_priv(ph);
> 849
> 850 if (evt_id >= ARRAY_SIZE(evt_2_cmd))
> 851 return false;
> 852
> > 853 clk = scmi_clock_domain_lookup(ci, src_id);
> 854 if (IS_ERR(clk))
> 855 return false;
> 856
> 857 if (evt_id == SCMI_EVENT_CLOCK_RATE_CHANGED)
> 858 supported = clk->rate_changed_notifications;
> 859 else
> 860 supported = clk->rate_change_requested_notifications;
> 861
> 862 return supported;
> 863 }
> 864
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: Cristian Marussi <cristian.marussi@arm.com>
To: kernel test robot <lkp@intel.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev,
oe-kbuild-all@lists.linux.dev, sudeep.holla@arm.com,
vincent.guittot@linaro.org, peng.fan@oss.nxp.com,
michal.simek@amd.com, quic_sibis@quicinc.com,
quic_nkela@quicinc.com, souvik.chakravarty@arm.com
Subject: Re: [PATCH 06/11] firmware: arm_scmi: Implement Clock .is_notify_supported callback
Date: Tue, 13 Feb 2024 08:49:51 +0000 [thread overview]
Message-ID: <ZcstL8tRVKIUFoBr@pluto> (raw)
In-Reply-To: <202402131047.2NVZWHma-lkp@intel.com>
On Tue, Feb 13, 2024 at 10:58:23AM +0800, kernel test robot wrote:
> Hi Cristian,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on soc/for-next]
> [also build test ERROR on linus/master v6.8-rc4 next-20240212]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
Hi,
this series, as stated in the cover-letter, is based off the current tip of
sudeep/for-next/scmi/updates
and particularly needs commit:
9c5bc650031e firmware: arm_scmi: Rework clock domain info lookups
from there, since it contains the missing scmi_clock_domain_lookup().
Not_sure/dont_known if there is any way to convey this "based-on-branch"
info to your/any CI at the moment.
Thanks,
Cristian
> url: https://github.com/intel-lab-lkp/linux/commits/Cristian-Marussi/firmware-arm_scmi-Check-for-notification-support/20240212-203727
> base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
> patch link: https://lore.kernel.org/r/20240212123233.1230090-7-cristian.marussi%40arm.com
> patch subject: [PATCH 06/11] firmware: arm_scmi: Implement Clock .is_notify_supported callback
> config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20240213/202402131047.2NVZWHma-lkp@intel.com/config)
> compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project c08b90c50bcac9f3f563c79491c8dbcbe7c3b574)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240213/202402131047.2NVZWHma-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202402131047.2NVZWHma-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> >> drivers/firmware/arm_scmi/clock.c:853:8: error: call to undeclared function 'scmi_clock_domain_lookup'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 853 | clk = scmi_clock_domain_lookup(ci, src_id);
> | ^
> >> drivers/firmware/arm_scmi/clock.c:853:6: error: incompatible integer to pointer conversion assigning to 'struct scmi_clock_info *' from 'int' [-Wint-conversion]
> 853 | clk = scmi_clock_domain_lookup(ci, src_id);
> | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 2 errors generated.
>
>
> vim +/scmi_clock_domain_lookup +853 drivers/firmware/arm_scmi/clock.c
>
> 842
> 843 static bool scmi_clk_notify_supported(const struct scmi_protocol_handle *ph,
> 844 u8 evt_id, u32 src_id)
> 845 {
> 846 bool supported;
> 847 struct scmi_clock_info *clk;
> 848 struct clock_info *ci = ph->get_priv(ph);
> 849
> 850 if (evt_id >= ARRAY_SIZE(evt_2_cmd))
> 851 return false;
> 852
> > 853 clk = scmi_clock_domain_lookup(ci, src_id);
> 854 if (IS_ERR(clk))
> 855 return false;
> 856
> 857 if (evt_id == SCMI_EVENT_CLOCK_RATE_CHANGED)
> 858 supported = clk->rate_changed_notifications;
> 859 else
> 860 supported = clk->rate_change_requested_notifications;
> 861
> 862 return supported;
> 863 }
> 864
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-13 8:49 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 12:32 [PATCH 00/11] Add SCMI core checks for notification support Cristian Marussi
2024-02-12 12:32 ` Cristian Marussi
2024-02-12 12:32 ` [PATCH 01/11] firmware: arm_scmi: Check " Cristian Marussi
2024-02-12 12:32 ` Cristian Marussi
2024-02-12 12:32 ` [PATCH 02/11] firmware: arm_scmi: Add a common helper to check if a message is supported Cristian Marussi
2024-02-12 12:32 ` Cristian Marussi
2024-02-12 12:32 ` [PATCH 03/11] firmware: arm_scmi: Implement Perf .is_notify_supported callback Cristian Marussi
2024-02-12 12:32 ` Cristian Marussi
2024-02-12 12:32 ` [PATCH 04/11] firmware: arm_scmi: Implement Power " Cristian Marussi
2024-02-12 12:32 ` Cristian Marussi
2024-02-12 12:32 ` [PATCH 05/11] firmware: arm_scmi: Implement SysPower " Cristian Marussi
2024-02-12 12:32 ` Cristian Marussi
2024-02-12 12:32 ` [PATCH 06/11] firmware: arm_scmi: Implement Clock " Cristian Marussi
2024-02-12 12:32 ` Cristian Marussi
2024-02-12 23:00 ` kernel test robot
2024-02-12 23:00 ` kernel test robot
2024-02-12 23:20 ` kernel test robot
2024-02-12 23:20 ` kernel test robot
2024-02-13 2:58 ` kernel test robot
2024-02-13 2:58 ` kernel test robot
2024-02-13 8:49 ` Cristian Marussi [this message]
2024-02-13 8:49 ` Cristian Marussi
2024-02-13 18:24 ` Nikunj Kela
2024-02-13 18:24 ` Nikunj Kela
2024-02-14 18:21 ` Cristian Marussi
2024-02-14 18:21 ` Cristian Marussi
2024-02-12 12:32 ` [PATCH 07/11] firmware: arm_scmi: Implement Sensor " Cristian Marussi
2024-02-12 12:32 ` Cristian Marussi
2024-02-12 12:32 ` [PATCH 08/11] firmware: arm_scmi: Implement Reset " Cristian Marussi
2024-02-12 12:32 ` Cristian Marussi
2024-02-12 12:32 ` [PATCH 09/11] firmware: arm_scmi: Implement Powercap " Cristian Marussi
2024-02-12 12:32 ` Cristian Marussi
2024-02-12 12:32 ` [PATCH 10/11] firmware: arm_scmi: Use opps_by_lvl to store opps Cristian Marussi
2024-02-12 12:32 ` Cristian Marussi
2024-02-12 12:32 ` [PATCH 11/11] firmware: arm_scmi: Report frequencies in Perf notifications Cristian Marussi
2024-02-12 12:32 ` Cristian Marussi
2024-02-22 9:09 ` [PATCH 00/11] Add SCMI core checks for notification support Sudeep Holla
2024-02-22 9:09 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcstL8tRVKIUFoBr@pluto \
--to=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=michal.simek@amd.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peng.fan@oss.nxp.com \
--cc=quic_nkela@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=souvik.chakravarty@arm.com \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.