From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com, pavel@ucw.cz, lee@kernel.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/4] ARM: dts: marvell: Indicate USB activity on x530
Date: Mon, 4 Mar 2024 21:16:41 +0200 [thread overview]
Message-ID: <ZeYeGRGTuil-TsMg@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdVuiYdjV46aS2fqPsFdW-vGK7zm_sY-LbWGYg4U0Ar5yQ@mail.gmail.com>
On Mon, Mar 04, 2024 at 08:01:58PM +0100, Geert Uytterhoeven wrote:
> On Mon, Mar 4, 2024 at 7:17 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Mon, Mar 4, 2024 at 11:57 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > On Sun, Mar 3, 2024 at 9:43 PM Andy Shevchenko
> > > <andy.shevchenko@gmail.com> wrote:
...
> > > So IMHO it would be a bad idea to make the DP mandatory.
> >
> > But I'm not talking about making it mandatory, I'm talking about the
>
> OK.
>
> > DP to be used as DP when it _is_ present and wired. If current
> > platform wants to use DP for something else, I'm pretty much worried
> > that this is the right thing to do.
>
> There is not much we can do about that. People can already model
> such displays as individual LEDs, too.
> And in some sense, the auxdisplay/linedisp driver for
> "generic-gpio-7seg" imposes a policy, too.
Does it? It's exactly targeting very specific HW configuration. The only
question here is DP.
> What if people want to e.g. use 4 7-seg displays to show a continuously
> running snake?
We have an ABI to update a "character" mapping, so it's possible to do, but
it is not a main purpose of line display library.
Free running 7-segment display does probably belong to LED framework in that
sense (as just represents a 7 LEDs that user configured in a specific way in
the physical world). In such case it's just the 7 LEDs on a single PCB.
If you consider these limits as "policy", okay, but it's _hardware driven_
one, and not software.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com, pavel@ucw.cz, lee@kernel.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/4] ARM: dts: marvell: Indicate USB activity on x530
Date: Mon, 4 Mar 2024 21:16:41 +0200 [thread overview]
Message-ID: <ZeYeGRGTuil-TsMg@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdVuiYdjV46aS2fqPsFdW-vGK7zm_sY-LbWGYg4U0Ar5yQ@mail.gmail.com>
On Mon, Mar 04, 2024 at 08:01:58PM +0100, Geert Uytterhoeven wrote:
> On Mon, Mar 4, 2024 at 7:17 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Mon, Mar 4, 2024 at 11:57 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > On Sun, Mar 3, 2024 at 9:43 PM Andy Shevchenko
> > > <andy.shevchenko@gmail.com> wrote:
...
> > > So IMHO it would be a bad idea to make the DP mandatory.
> >
> > But I'm not talking about making it mandatory, I'm talking about the
>
> OK.
>
> > DP to be used as DP when it _is_ present and wired. If current
> > platform wants to use DP for something else, I'm pretty much worried
> > that this is the right thing to do.
>
> There is not much we can do about that. People can already model
> such displays as individual LEDs, too.
> And in some sense, the auxdisplay/linedisp driver for
> "generic-gpio-7seg" imposes a policy, too.
Does it? It's exactly targeting very specific HW configuration. The only
question here is DP.
> What if people want to e.g. use 4 7-seg displays to show a continuously
> running snake?
We have an ABI to update a "character" mapping, so it's possible to do, but
it is not a main purpose of line display library.
Free running 7-segment display does probably belong to LED framework in that
sense (as just represents a 7 LEDs that user configured in a specific way in
the physical world). In such case it's just the 7 LEDs on a single PCB.
If you consider these limits as "policy", okay, but it's _hardware driven_
one, and not software.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-04 19:16 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 1:41 [PATCH v3 0/4] auxdisplay: 7 segment LED display Chris Packham
2024-03-01 1:41 ` Chris Packham
2024-03-01 1:42 ` [PATCH v3 1/4] auxdisplay: Add 7-segment LED display driver Chris Packham
2024-03-01 1:42 ` Chris Packham
2024-03-01 18:18 ` Andy Shevchenko
2024-03-01 18:18 ` Andy Shevchenko
2024-03-03 19:58 ` Chris Packham
2024-03-03 19:58 ` Chris Packham
2024-03-03 20:35 ` Andy Shevchenko
2024-03-03 20:35 ` Andy Shevchenko
2024-03-03 20:56 ` Yury Norov
2024-03-03 20:56 ` Yury Norov
2024-03-04 0:45 ` Chris Packham
2024-03-04 0:45 ` Chris Packham
2024-03-04 0:46 ` Chris Packham
2024-03-04 0:46 ` Chris Packham
2024-03-01 1:42 ` [PATCH v3 2/4] dt-bindings: auxdisplay: Add bindings for generic 7-segment LED Chris Packham
2024-03-01 1:42 ` Chris Packham
2024-03-01 18:21 ` Andy Shevchenko
2024-03-01 18:21 ` Andy Shevchenko
2024-03-01 1:42 ` [PATCH v3 3/4] ARM: dts: marvell: Add 7-segment LED display on x530 Chris Packham
2024-03-01 1:42 ` Chris Packham
2024-03-01 18:22 ` Andy Shevchenko
2024-03-01 18:22 ` Andy Shevchenko
2024-03-01 1:42 ` [PATCH v3 4/4] ARM: dts: marvell: Indicate USB activity " Chris Packham
2024-03-01 1:42 ` Chris Packham
2024-03-01 18:24 ` Andy Shevchenko
2024-03-01 18:24 ` Andy Shevchenko
2024-03-03 9:48 ` Geert Uytterhoeven
2024-03-03 9:48 ` Geert Uytterhoeven
2024-03-03 20:11 ` Chris Packham
2024-03-03 20:11 ` Chris Packham
2024-03-03 20:43 ` Andy Shevchenko
2024-03-03 20:43 ` Andy Shevchenko
2024-03-04 9:57 ` Geert Uytterhoeven
2024-03-04 9:57 ` Geert Uytterhoeven
2024-03-04 18:17 ` Andy Shevchenko
2024-03-04 18:17 ` Andy Shevchenko
2024-03-04 19:01 ` Geert Uytterhoeven
2024-03-04 19:01 ` Geert Uytterhoeven
2024-03-04 19:16 ` Andy Shevchenko [this message]
2024-03-04 19:16 ` Andy Shevchenko
2024-03-01 18:31 ` [PATCH v3 0/4] auxdisplay: 7 segment LED display Andy Shevchenko
2024-03-01 18:31 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeYeGRGTuil-TsMg@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.