From: Peter Xu <peterx@redhat.com>
To: Muchun Song <muchun.song@linux.dev>
Cc: linux-arm-kernel@lists.infradead.org,
Andreas Larsson <andreas@gaisler.com>,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Linux-MM <linux-mm@kvack.org>, Jason Gunthorpe <jgg@nvidia.com>,
sparclinux@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
"David S . Miller" <davem@davemloft.net>,
Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v2 05/14] mm/sparc: Change pXd_huge() behavior to exclude swap entries
Date: Tue, 19 Mar 2024 10:04:31 -0400 [thread overview]
Message-ID: <Zfmbb82ErXU8WXt3@x1n> (raw)
In-Reply-To: <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev>
On Tue, Mar 19, 2024 at 12:25:39PM +0800, Muchun Song wrote:
> > @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct *mm, unsigned long addr,
> >
> > int pmd_huge(pmd_t pmd)
> > {
> > - return !pmd_none(pmd) &&
> > - (pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) != _PAGE_VALID;
> > + return pmd_leaf(pmd);;
>
> There is a redundant semicolon in the end.
Will touch it up, thanks. PS: This will be dropped as a whole in patch 12.
--
Peter Xu
WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: Muchun Song <muchun.song@linux.dev>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, Mike Rapoport <rppt@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
sparclinux@vger.kernel.org, Jason Gunthorpe <jgg@nvidia.com>,
linuxppc-dev@lists.ozlabs.org,
Christophe Leroy <christophe.leroy@csgroup.eu>,
linux-arm-kernel@lists.infradead.org,
"David S . Miller" <davem@davemloft.net>,
Andreas Larsson <andreas@gaisler.com>
Subject: Re: [PATCH v2 05/14] mm/sparc: Change pXd_huge() behavior to exclude swap entries
Date: Tue, 19 Mar 2024 10:04:31 -0400 [thread overview]
Message-ID: <Zfmbb82ErXU8WXt3@x1n> (raw)
In-Reply-To: <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev>
On Tue, Mar 19, 2024 at 12:25:39PM +0800, Muchun Song wrote:
> > @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct *mm, unsigned long addr,
> >
> > int pmd_huge(pmd_t pmd)
> > {
> > - return !pmd_none(pmd) &&
> > - (pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) != _PAGE_VALID;
> > + return pmd_leaf(pmd);;
>
> There is a redundant semicolon in the end.
Will touch it up, thanks. PS: This will be dropped as a whole in patch 12.
--
Peter Xu
WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: Muchun Song <muchun.song@linux.dev>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, Mike Rapoport <rppt@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
sparclinux@vger.kernel.org, Jason Gunthorpe <jgg@nvidia.com>,
linuxppc-dev@lists.ozlabs.org,
Christophe Leroy <christophe.leroy@csgroup.eu>,
linux-arm-kernel@lists.infradead.org,
"David S . Miller" <davem@davemloft.net>,
Andreas Larsson <andreas@gaisler.com>
Subject: Re: [PATCH v2 05/14] mm/sparc: Change pXd_huge() behavior to exclude swap entries
Date: Tue, 19 Mar 2024 10:04:31 -0400 [thread overview]
Message-ID: <Zfmbb82ErXU8WXt3@x1n> (raw)
In-Reply-To: <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev>
On Tue, Mar 19, 2024 at 12:25:39PM +0800, Muchun Song wrote:
> > @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct *mm, unsigned long addr,
> >
> > int pmd_huge(pmd_t pmd)
> > {
> > - return !pmd_none(pmd) &&
> > - (pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) != _PAGE_VALID;
> > + return pmd_leaf(pmd);;
>
> There is a redundant semicolon in the end.
Will touch it up, thanks. PS: This will be dropped as a whole in patch 12.
--
Peter Xu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-19 14:05 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 20:03 [PATCH v2 00/14] mm/treewide: Remove pXd_huge() API peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` [PATCH v2 01/14] mm/hmm: Process pud swap entry without pud_huge() peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` [PATCH v2 02/14] mm/gup: Cache p4d in follow_p4d_mask() peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` [PATCH v2 03/14] mm/gup: Check p4d presence before going on peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` [PATCH v2 04/14] mm/x86: Change pXd_huge() behavior to exclude swap entries peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` [PATCH v2 05/14] mm/sparc: " peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` peterx
2024-03-19 4:25 ` Muchun Song
2024-03-19 4:25 ` Muchun Song
2024-03-19 4:25 ` Muchun Song
2024-03-19 14:04 ` Peter Xu [this message]
2024-03-19 14:04 ` Peter Xu
2024-03-19 14:04 ` Peter Xu
2024-03-18 20:03 ` [PATCH v2 06/14] mm/arm: Use macros to define pmd/pud helpers peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` [PATCH v2 07/14] mm/arm: Redefine pmd_huge() with pmd_leaf() peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` [PATCH v2 08/14] mm/arm64: Merge pXd_huge() and pXd_leaf() definitions peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` [PATCH v2 09/14] mm/powerpc: Redefine pXd_huge() with pXd_leaf() peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:03 ` peterx
2024-03-18 20:04 ` [PATCH v2 10/14] mm/gup: Merge pXd huge mapping checks peterx
2024-03-18 20:04 ` peterx
2024-03-18 20:04 ` peterx
2024-03-18 20:04 ` [PATCH v2 11/14] mm/treewide: Replace pXd_huge() with pXd_leaf() peterx
2024-03-18 20:04 ` peterx
2024-03-18 20:04 ` peterx
2024-03-18 20:04 ` [PATCH v2 12/14] mm/treewide: Remove pXd_huge() peterx
2024-03-18 20:04 ` peterx
2024-03-18 20:04 ` peterx
2024-05-27 6:03 ` Christophe Leroy
2024-05-27 6:03 ` Christophe Leroy
2024-05-27 6:03 ` Christophe Leroy
2024-05-27 15:43 ` Peter Xu
2024-05-27 15:43 ` Peter Xu
2024-05-27 15:43 ` Peter Xu
2024-03-18 20:04 ` [PATCH v2 13/14] mm/arm: Remove pmd_thp_or_huge() peterx
2024-03-18 20:04 ` peterx
2024-03-18 20:04 ` peterx
2024-03-18 20:04 ` [PATCH v2 14/14] mm: Document pXd_leaf() API peterx
2024-03-18 20:04 ` peterx
2024-03-18 20:04 ` peterx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zfmbb82ErXU8WXt3@x1n \
--to=peterx@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=jgg@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=muchun.song@linux.dev \
--cc=rppt@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.