All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Aiuto <fabio.aiuto@engicam.com>
To: Shawn Guo <shawnguo2@yeah.net>
Cc: Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Matteo Lisi <matteo.lisi@engicam.com>,
	Mirko Ardinghi <mirko.ardinghi@engicam.com>
Subject: Re: [PATCH v3 2/3] arm64: dts: imx93: add Engicam i.Core MX93 SoM
Date: Thu, 25 Apr 2024 09:30:51 +0200	[thread overview]
Message-ID: <ZioGq1/zlRP1o7dj@engicam> (raw)
In-Reply-To: <ZioFaJtxYsUlchfW@dragon>

Dear Shawn,

Il Thu, Apr 25, 2024 at 03:25:28PM +0800, Shawn Guo ha scritto:
> On Fri, Apr 19, 2024 at 04:49:52PM +0200, Fabio Aiuto wrote:
<snip>
> > +			MX93_PAD_SD2_DATA3__USDHC2_DATA3        0x130e
> > +			MX93_PAD_SD2_VSELECT__USDHC2_VSELECT	0x51e
> 
> Could you try to align the indents, so that those hex values appear at
> the same column?

thanks for your review, I will send a v5.

kr,

fabio

> 
> Shawn
> 
> > +		>;
> > +	};
> > +
> > +	pinctrl_usdhc2_gpio: usdhc2gpiogrp {
> > +		fsl,pins = <
> > +			MX93_PAD_SD2_CD_B__GPIO3_IO00		0x31e
> > +		>;
> > +	};
> > +};
> > -- 
> > 2.34.1
> > 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Fabio Aiuto <fabio.aiuto@engicam.com>
To: Shawn Guo <shawnguo2@yeah.net>
Cc: Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Matteo Lisi <matteo.lisi@engicam.com>,
	Mirko Ardinghi <mirko.ardinghi@engicam.com>
Subject: Re: [PATCH v3 2/3] arm64: dts: imx93: add Engicam i.Core MX93 SoM
Date: Thu, 25 Apr 2024 09:30:51 +0200	[thread overview]
Message-ID: <ZioGq1/zlRP1o7dj@engicam> (raw)
In-Reply-To: <ZioFaJtxYsUlchfW@dragon>

Dear Shawn,

Il Thu, Apr 25, 2024 at 03:25:28PM +0800, Shawn Guo ha scritto:
> On Fri, Apr 19, 2024 at 04:49:52PM +0200, Fabio Aiuto wrote:
<snip>
> > +			MX93_PAD_SD2_DATA3__USDHC2_DATA3        0x130e
> > +			MX93_PAD_SD2_VSELECT__USDHC2_VSELECT	0x51e
> 
> Could you try to align the indents, so that those hex values appear at
> the same column?

thanks for your review, I will send a v5.

kr,

fabio

> 
> Shawn
> 
> > +		>;
> > +	};
> > +
> > +	pinctrl_usdhc2_gpio: usdhc2gpiogrp {
> > +		fsl,pins = <
> > +			MX93_PAD_SD2_CD_B__GPIO3_IO00		0x31e
> > +		>;
> > +	};
> > +};
> > -- 
> > 2.34.1
> > 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-04-25  7:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19 14:49 [PATCH v3 0/3] arm64: dts: imx93: add i.Core MX93 EDIMM 2.0 board Fabio Aiuto
2024-04-19 14:49 ` Fabio Aiuto
2024-04-19 14:49 ` [PATCH v3 1/3] dt-bindings: arm: fsl: add Engicam i.Core MX93 EDIMM 2.0 Starter Kit Fabio Aiuto
2024-04-19 14:49   ` Fabio Aiuto
2024-04-19 14:49 ` [PATCH v3 2/3] arm64: dts: imx93: add Engicam i.Core MX93 SoM Fabio Aiuto
2024-04-19 14:49   ` Fabio Aiuto
2024-04-25  7:25   ` Shawn Guo
2024-04-25  7:25     ` Shawn Guo
2024-04-25  7:30     ` Fabio Aiuto [this message]
2024-04-25  7:30       ` Fabio Aiuto
2024-04-19 14:49 ` [PATCH v3 3/3] arm64: dts: imx93: Add Engicam i.Core MX93 EDIMM 2.0 Starter Kit Fabio Aiuto
2024-04-19 14:49   ` Fabio Aiuto
2024-04-25  7:44   ` Shawn Guo
2024-04-25  7:44     ` Shawn Guo
2024-04-25  8:08     ` Fabio Aiuto
2024-04-25  8:08       ` Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZioGq1/zlRP1o7dj@engicam \
    --to=fabio.aiuto@engicam.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matteo.lisi@engicam.com \
    --cc=mirko.ardinghi@engicam.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo2@yeah.net \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.