From: William McVicker <willmcvicker@google.com>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
David Lechner <david@lechnology.com>,
Bjorn Andersson <andersson@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v3] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE
Date: Mon, 13 May 2024 00:19:01 -0700 [thread overview]
Message-ID: <ZkG-5YbtJtjEojeF@google.com> (raw)
In-Reply-To: <CAPLW+4kYE7mnEUrQM4qRs0Uhr2RcXXVCu0XLvX7-czJUZ_Fd1w@mail.gmail.com>
On 05/10/2024, Sam Protsenko wrote:
> On Fri, May 10, 2024 at 2:07 AM Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
> >
> > Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to
> > module driver") this driver is instantiated as MFD-cell (matched by
> > platform device name) not as a real platform device created by OF code.
> > Remove then of_match_table and change related MODULE_DEVICE_TABLE to
> > simple MODULE_ALIAS to avoid further confusion.
> >
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > ---
> > v3:
> > - Use '#define DRV_NAME' based alias. I see no point bloating the driver
> > with another platform device IDs array, as I don't expect this driver to
> > be used with any other platform device ID. Driver variants are already
> > selected based on the parent PMU device compatible.
Sure, I'm fine with this either way. Thanks for following up!
> >
> > v2:
> > - added MODULE_ALIAS
> > ---
>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Reviewed-by: Will McVicker <willmcvicker@google.com>
>
> [snip]
WARNING: multiple messages have this Message-ID (diff)
From: William McVicker <willmcvicker@google.com>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
David Lechner <david@lechnology.com>,
Bjorn Andersson <andersson@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v3] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE
Date: Mon, 13 May 2024 00:19:01 -0700 [thread overview]
Message-ID: <ZkG-5YbtJtjEojeF@google.com> (raw)
In-Reply-To: <CAPLW+4kYE7mnEUrQM4qRs0Uhr2RcXXVCu0XLvX7-czJUZ_Fd1w@mail.gmail.com>
On 05/10/2024, Sam Protsenko wrote:
> On Fri, May 10, 2024 at 2:07 AM Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
> >
> > Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to
> > module driver") this driver is instantiated as MFD-cell (matched by
> > platform device name) not as a real platform device created by OF code.
> > Remove then of_match_table and change related MODULE_DEVICE_TABLE to
> > simple MODULE_ALIAS to avoid further confusion.
> >
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > ---
> > v3:
> > - Use '#define DRV_NAME' based alias. I see no point bloating the driver
> > with another platform device IDs array, as I don't expect this driver to
> > be used with any other platform device ID. Driver variants are already
> > selected based on the parent PMU device compatible.
Sure, I'm fine with this either way. Thanks for following up!
> >
> > v2:
> > - added MODULE_ALIAS
> > ---
>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Reviewed-by: Will McVicker <willmcvicker@google.com>
>
> [snip]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-13 7:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240510070700eucas1p10ed1c978c78366b412770fdae6d4f384@eucas1p1.samsung.com>
2024-05-10 7:06 ` [PATCH v3] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE Marek Szyprowski
2024-05-10 7:06 ` Marek Szyprowski
2024-05-10 18:30 ` Sam Protsenko
2024-05-10 18:30 ` Sam Protsenko
2024-05-13 7:19 ` William McVicker [this message]
2024-05-13 7:19 ` William McVicker
2024-05-27 9:20 ` Krzysztof Kozlowski
2024-05-27 9:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkG-5YbtJtjEojeF@google.com \
--to=willmcvicker@google.com \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=david@lechnology.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.