* [PATCH v3] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE
@ 2024-05-10 7:06 ` Marek Szyprowski
0 siblings, 0 replies; 8+ messages in thread
From: Marek Szyprowski @ 2024-05-10 7:06 UTC (permalink / raw)
To: linux-samsung-soc, linux-clk, linux-arm-kernel
Cc: Marek Szyprowski, Krzysztof Kozlowski, Sylwester Nawrocki,
Chanwoo Choi, Alim Akhtar, Michael Turquette, Stephen Boyd,
Rob Herring, David Lechner, Bjorn Andersson, Dmitry Baryshkov,
William McVicker
Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to
module driver") this driver is instantiated as MFD-cell (matched by
platform device name) not as a real platform device created by OF code.
Remove then of_match_table and change related MODULE_DEVICE_TABLE to
simple MODULE_ALIAS to avoid further confusion.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
v3:
- Use '#define DRV_NAME' based alias. I see no point bloating the driver
with another platform device IDs array, as I don't expect this driver to
be used with any other platform device ID. Driver variants are already
selected based on the parent PMU device compatible.
v2:
- added MODULE_ALIAS
---
drivers/clk/samsung/clk-exynos-clkout.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c
index 503c6f5b20d5..89cf2000884f 100644
--- a/drivers/clk/samsung/clk-exynos-clkout.c
+++ b/drivers/clk/samsung/clk-exynos-clkout.c
@@ -17,6 +17,8 @@
#include <linux/platform_device.h>
#include <linux/pm.h>
+#define DRV_NAME "exynos-clkout"
+
#define EXYNOS_CLKOUT_NR_CLKS 1
#define EXYNOS_CLKOUT_PARENTS 32
@@ -75,7 +77,6 @@ static const struct of_device_id exynos_clkout_ids[] = {
.data = &exynos_clkout_exynos5,
}, { }
};
-MODULE_DEVICE_TABLE(of, exynos_clkout_ids);
/*
* Device will be instantiated as child of PMU device without its own
@@ -236,8 +237,7 @@ static SIMPLE_DEV_PM_OPS(exynos_clkout_pm_ops, exynos_clkout_suspend,
static struct platform_driver exynos_clkout_driver = {
.driver = {
- .name = "exynos-clkout",
- .of_match_table = exynos_clkout_ids,
+ .name = DRV_NAME,
.pm = &exynos_clkout_pm_ops,
},
.probe = exynos_clkout_probe,
@@ -248,4 +248,5 @@ module_platform_driver(exynos_clkout_driver);
MODULE_AUTHOR("Krzysztof Kozlowski <krzk@kernel.org>");
MODULE_AUTHOR("Tomasz Figa <tomasz.figa@gmail.com>");
MODULE_DESCRIPTION("Samsung Exynos clock output driver");
+MODULE_ALIAS("platform:" DRV_NAME);
MODULE_LICENSE("GPL");
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v3] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE
2024-05-10 7:06 ` Marek Szyprowski
@ 2024-05-10 18:30 ` Sam Protsenko
-1 siblings, 0 replies; 8+ messages in thread
From: Sam Protsenko @ 2024-05-10 18:30 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-samsung-soc, linux-clk, linux-arm-kernel,
Krzysztof Kozlowski, Sylwester Nawrocki, Chanwoo Choi,
Alim Akhtar, Michael Turquette, Stephen Boyd, Rob Herring,
David Lechner, Bjorn Andersson, Dmitry Baryshkov,
William McVicker
On Fri, May 10, 2024 at 2:07 AM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to
> module driver") this driver is instantiated as MFD-cell (matched by
> platform device name) not as a real platform device created by OF code.
> Remove then of_match_table and change related MODULE_DEVICE_TABLE to
> simple MODULE_ALIAS to avoid further confusion.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> v3:
> - Use '#define DRV_NAME' based alias. I see no point bloating the driver
> with another platform device IDs array, as I don't expect this driver to
> be used with any other platform device ID. Driver variants are already
> selected based on the parent PMU device compatible.
>
> v2:
> - added MODULE_ALIAS
> ---
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
[snip]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE
@ 2024-05-10 18:30 ` Sam Protsenko
0 siblings, 0 replies; 8+ messages in thread
From: Sam Protsenko @ 2024-05-10 18:30 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-samsung-soc, linux-clk, linux-arm-kernel,
Krzysztof Kozlowski, Sylwester Nawrocki, Chanwoo Choi,
Alim Akhtar, Michael Turquette, Stephen Boyd, Rob Herring,
David Lechner, Bjorn Andersson, Dmitry Baryshkov,
William McVicker
On Fri, May 10, 2024 at 2:07 AM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to
> module driver") this driver is instantiated as MFD-cell (matched by
> platform device name) not as a real platform device created by OF code.
> Remove then of_match_table and change related MODULE_DEVICE_TABLE to
> simple MODULE_ALIAS to avoid further confusion.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> v3:
> - Use '#define DRV_NAME' based alias. I see no point bloating the driver
> with another platform device IDs array, as I don't expect this driver to
> be used with any other platform device ID. Driver variants are already
> selected based on the parent PMU device compatible.
>
> v2:
> - added MODULE_ALIAS
> ---
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
[snip]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE
2024-05-10 18:30 ` Sam Protsenko
@ 2024-05-13 7:19 ` William McVicker
-1 siblings, 0 replies; 8+ messages in thread
From: William McVicker @ 2024-05-13 7:19 UTC (permalink / raw)
To: Sam Protsenko
Cc: Marek Szyprowski, linux-samsung-soc, linux-clk, linux-arm-kernel,
Krzysztof Kozlowski, Sylwester Nawrocki, Chanwoo Choi,
Alim Akhtar, Michael Turquette, Stephen Boyd, Rob Herring,
David Lechner, Bjorn Andersson, Dmitry Baryshkov
On 05/10/2024, Sam Protsenko wrote:
> On Fri, May 10, 2024 at 2:07 AM Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
> >
> > Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to
> > module driver") this driver is instantiated as MFD-cell (matched by
> > platform device name) not as a real platform device created by OF code.
> > Remove then of_match_table and change related MODULE_DEVICE_TABLE to
> > simple MODULE_ALIAS to avoid further confusion.
> >
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > ---
> > v3:
> > - Use '#define DRV_NAME' based alias. I see no point bloating the driver
> > with another platform device IDs array, as I don't expect this driver to
> > be used with any other platform device ID. Driver variants are already
> > selected based on the parent PMU device compatible.
Sure, I'm fine with this either way. Thanks for following up!
> >
> > v2:
> > - added MODULE_ALIAS
> > ---
>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Reviewed-by: Will McVicker <willmcvicker@google.com>
>
> [snip]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE
@ 2024-05-13 7:19 ` William McVicker
0 siblings, 0 replies; 8+ messages in thread
From: William McVicker @ 2024-05-13 7:19 UTC (permalink / raw)
To: Sam Protsenko
Cc: Marek Szyprowski, linux-samsung-soc, linux-clk, linux-arm-kernel,
Krzysztof Kozlowski, Sylwester Nawrocki, Chanwoo Choi,
Alim Akhtar, Michael Turquette, Stephen Boyd, Rob Herring,
David Lechner, Bjorn Andersson, Dmitry Baryshkov
On 05/10/2024, Sam Protsenko wrote:
> On Fri, May 10, 2024 at 2:07 AM Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
> >
> > Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to
> > module driver") this driver is instantiated as MFD-cell (matched by
> > platform device name) not as a real platform device created by OF code.
> > Remove then of_match_table and change related MODULE_DEVICE_TABLE to
> > simple MODULE_ALIAS to avoid further confusion.
> >
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > ---
> > v3:
> > - Use '#define DRV_NAME' based alias. I see no point bloating the driver
> > with another platform device IDs array, as I don't expect this driver to
> > be used with any other platform device ID. Driver variants are already
> > selected based on the parent PMU device compatible.
Sure, I'm fine with this either way. Thanks for following up!
> >
> > v2:
> > - added MODULE_ALIAS
> > ---
>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Reviewed-by: Will McVicker <willmcvicker@google.com>
>
> [snip]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE
2024-05-10 7:06 ` Marek Szyprowski
@ 2024-05-27 9:20 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-05-27 9:20 UTC (permalink / raw)
To: linux-samsung-soc, linux-clk, linux-arm-kernel, Marek Szyprowski
Cc: Krzysztof Kozlowski, Sylwester Nawrocki, Chanwoo Choi,
Alim Akhtar, Michael Turquette, Stephen Boyd, Rob Herring,
David Lechner, Bjorn Andersson, Dmitry Baryshkov,
William McVicker
On Fri, 10 May 2024 09:06:53 +0200, Marek Szyprowski wrote:
> Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to
> module driver") this driver is instantiated as MFD-cell (matched by
> platform device name) not as a real platform device created by OF code.
> Remove then of_match_table and change related MODULE_DEVICE_TABLE to
> simple MODULE_ALIAS to avoid further confusion.
>
>
> [...]
Applied, thanks!
[1/1] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE
https://git.kernel.org/krzk/linux/c/b363a45913d211990b9a42123690518dd3f499c4
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE
@ 2024-05-27 9:20 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-05-27 9:20 UTC (permalink / raw)
To: linux-samsung-soc, linux-clk, linux-arm-kernel, Marek Szyprowski
Cc: Krzysztof Kozlowski, Sylwester Nawrocki, Chanwoo Choi,
Alim Akhtar, Michael Turquette, Stephen Boyd, Rob Herring,
David Lechner, Bjorn Andersson, Dmitry Baryshkov,
William McVicker
On Fri, 10 May 2024 09:06:53 +0200, Marek Szyprowski wrote:
> Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to
> module driver") this driver is instantiated as MFD-cell (matched by
> platform device name) not as a real platform device created by OF code.
> Remove then of_match_table and change related MODULE_DEVICE_TABLE to
> simple MODULE_ALIAS to avoid further confusion.
>
>
> [...]
Applied, thanks!
[1/1] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE
https://git.kernel.org/krzk/linux/c/b363a45913d211990b9a42123690518dd3f499c4
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread