* [PATCH] drm/panic: Add missing static inline to drm_panic_is_enabled()
@ 2024-07-19 10:36 Jocelyn Falempe
2024-07-19 11:39 ` Imre Deak
0 siblings, 1 reply; 5+ messages in thread
From: Jocelyn Falempe @ 2024-07-19 10:36 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Javier Martinez Canillas, Jocelyn Falempe,
dri-devel, Imre Deak
This breaks build if DRM_PANIC is not enabled.
Fixes: de338c754d40 ("drm/panic: Add missing static inline to drm_panic_is_enabled()")
Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
---
drivers/gpu/drm/drm_crtc_internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h
index c10de39cbe83..bbac5350774e 100644
--- a/drivers/gpu/drm/drm_crtc_internal.h
+++ b/drivers/gpu/drm/drm_crtc_internal.h
@@ -321,7 +321,7 @@ drm_edid_load_firmware(struct drm_connector *connector)
#ifdef CONFIG_DRM_PANIC
bool drm_panic_is_enabled(struct drm_device *dev);
#else
-bool drm_panic_is_enabled(struct drm_device *dev) {return false; }
+static inline bool drm_panic_is_enabled(struct drm_device *dev) {return false; }
#endif
#endif /* __DRM_CRTC_INTERNAL_H__ */
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/panic: Add missing static inline to drm_panic_is_enabled()
2024-07-19 10:36 [PATCH] drm/panic: Add missing static inline to drm_panic_is_enabled() Jocelyn Falempe
@ 2024-07-19 11:39 ` Imre Deak
2024-07-19 11:43 ` Imre Deak
0 siblings, 1 reply; 5+ messages in thread
From: Imre Deak @ 2024-07-19 11:39 UTC (permalink / raw)
To: Jocelyn Falempe
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Javier Martinez Canillas, dri-devel
On Fri, Jul 19, 2024 at 12:36:08PM +0200, Jocelyn Falempe wrote:
> This breaks build if DRM_PANIC is not enabled.
>
> Fixes: de338c754d40 ("drm/panic: Add missing static inline to drm_panic_is_enabled()")
> Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
Thanks for the quick fix:
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/drm_crtc_internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h
> index c10de39cbe83..bbac5350774e 100644
> --- a/drivers/gpu/drm/drm_crtc_internal.h
> +++ b/drivers/gpu/drm/drm_crtc_internal.h
> @@ -321,7 +321,7 @@ drm_edid_load_firmware(struct drm_connector *connector)
> #ifdef CONFIG_DRM_PANIC
> bool drm_panic_is_enabled(struct drm_device *dev);
> #else
> -bool drm_panic_is_enabled(struct drm_device *dev) {return false; }
> +static inline bool drm_panic_is_enabled(struct drm_device *dev) {return false; }
> #endif
>
> #endif /* __DRM_CRTC_INTERNAL_H__ */
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/panic: Add missing static inline to drm_panic_is_enabled()
2024-07-19 11:39 ` Imre Deak
@ 2024-07-19 11:43 ` Imre Deak
2024-07-19 12:01 ` Imre Deak
0 siblings, 1 reply; 5+ messages in thread
From: Imre Deak @ 2024-07-19 11:43 UTC (permalink / raw)
To: Jocelyn Falempe, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter,
Javier Martinez Canillas, dri-devel
On Fri, Jul 19, 2024 at 02:39:11PM +0300, Imre Deak wrote:
> On Fri, Jul 19, 2024 at 12:36:08PM +0200, Jocelyn Falempe wrote:
> > This breaks build if DRM_PANIC is not enabled.
> >
> > Fixes: de338c754d40 ("drm/panic: Add missing static inline to drm_panic_is_enabled()")
The fix is actually for 9f774c42a908 ("drm/panic: Add drm_panic_is_enabled()")
> > Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
>
> Thanks for the quick fix:
> Reviewed-by: Imre Deak <imre.deak@intel.com>
>
> > ---
> > drivers/gpu/drm/drm_crtc_internal.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h
> > index c10de39cbe83..bbac5350774e 100644
> > --- a/drivers/gpu/drm/drm_crtc_internal.h
> > +++ b/drivers/gpu/drm/drm_crtc_internal.h
> > @@ -321,7 +321,7 @@ drm_edid_load_firmware(struct drm_connector *connector)
> > #ifdef CONFIG_DRM_PANIC
> > bool drm_panic_is_enabled(struct drm_device *dev);
> > #else
> > -bool drm_panic_is_enabled(struct drm_device *dev) {return false; }
> > +static inline bool drm_panic_is_enabled(struct drm_device *dev) {return false; }
> > #endif
> >
> > #endif /* __DRM_CRTC_INTERNAL_H__ */
> > --
> > 2.45.2
> >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/panic: Add missing static inline to drm_panic_is_enabled()
2024-07-19 11:43 ` Imre Deak
@ 2024-07-19 12:01 ` Imre Deak
2024-07-19 12:17 ` Jocelyn Falempe
0 siblings, 1 reply; 5+ messages in thread
From: Imre Deak @ 2024-07-19 12:01 UTC (permalink / raw)
To: Jocelyn Falempe, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter,
Javier Martinez Canillas, dri-devel
On Fri, Jul 19, 2024 at 02:43:27PM +0300, Imre Deak wrote:
> On Fri, Jul 19, 2024 at 02:39:11PM +0300, Imre Deak wrote:
> > On Fri, Jul 19, 2024 at 12:36:08PM +0200, Jocelyn Falempe wrote:
> > > This breaks build if DRM_PANIC is not enabled.
> > >
> > > Fixes: de338c754d40 ("drm/panic: Add missing static inline to drm_panic_is_enabled()")
>
> The fix is actually for 9f774c42a908 ("drm/panic: Add drm_panic_is_enabled()")
A related issue, DRM_CONFIG_PANIC=y is also borked for me:
CC [M] drivers/gpu/drm/drm_panic.o
drivers/gpu/drm/drm_panic.c:712:6: error: no previous prototype for ‘drm_panic_is_enabled’ [-Werror=missing-prototypes]
712 | bool drm_panic_is_enabled(struct drm_device *dev)
| ^~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
> > > Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
> >
> > Thanks for the quick fix:
> > Reviewed-by: Imre Deak <imre.deak@intel.com>
> >
> > > ---
> > > drivers/gpu/drm/drm_crtc_internal.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h
> > > index c10de39cbe83..bbac5350774e 100644
> > > --- a/drivers/gpu/drm/drm_crtc_internal.h
> > > +++ b/drivers/gpu/drm/drm_crtc_internal.h
> > > @@ -321,7 +321,7 @@ drm_edid_load_firmware(struct drm_connector *connector)
> > > #ifdef CONFIG_DRM_PANIC
> > > bool drm_panic_is_enabled(struct drm_device *dev);
> > > #else
> > > -bool drm_panic_is_enabled(struct drm_device *dev) {return false; }
> > > +static inline bool drm_panic_is_enabled(struct drm_device *dev) {return false; }
> > > #endif
> > >
> > > #endif /* __DRM_CRTC_INTERNAL_H__ */
> > > --
> > > 2.45.2
> > >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/panic: Add missing static inline to drm_panic_is_enabled()
2024-07-19 12:01 ` Imre Deak
@ 2024-07-19 12:17 ` Jocelyn Falempe
0 siblings, 0 replies; 5+ messages in thread
From: Jocelyn Falempe @ 2024-07-19 12:17 UTC (permalink / raw)
To: imre.deak, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Javier Martinez Canillas, dri-devel
On 19/07/2024 14:01, Imre Deak wrote:
> On Fri, Jul 19, 2024 at 02:43:27PM +0300, Imre Deak wrote:
>> On Fri, Jul 19, 2024 at 02:39:11PM +0300, Imre Deak wrote:
>>> On Fri, Jul 19, 2024 at 12:36:08PM +0200, Jocelyn Falempe wrote:
>>>> This breaks build if DRM_PANIC is not enabled.
>>>>
>>>> Fixes: de338c754d40 ("drm/panic: Add missing static inline to drm_panic_is_enabled()")
>>
>> The fix is actually for 9f774c42a908 ("drm/panic: Add drm_panic_is_enabled()")
Yes, picked up the wrong sha1.
>
> A related issue, DRM_CONFIG_PANIC=y is also borked for me:
>
> CC [M] drivers/gpu/drm/drm_panic.o
> drivers/gpu/drm/drm_panic.c:712:6: error: no previous prototype for ‘drm_panic_is_enabled’ [-Werror=missing-prototypes]
> 712 | bool drm_panic_is_enabled(struct drm_device *dev)
> | ^~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
ok it's missing the #include "drm_crtc_internal.h" in drm_panic.c.
how did I missed that :(
let me send a v2.
--
Jocelyn
>>>> Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
>>>
>>> Thanks for the quick fix:
>>> Reviewed-by: Imre Deak <imre.deak@intel.com>
>>>
>>>> ---
>>>> drivers/gpu/drm/drm_crtc_internal.h | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h
>>>> index c10de39cbe83..bbac5350774e 100644
>>>> --- a/drivers/gpu/drm/drm_crtc_internal.h
>>>> +++ b/drivers/gpu/drm/drm_crtc_internal.h
>>>> @@ -321,7 +321,7 @@ drm_edid_load_firmware(struct drm_connector *connector)
>>>> #ifdef CONFIG_DRM_PANIC
>>>> bool drm_panic_is_enabled(struct drm_device *dev);
>>>> #else
>>>> -bool drm_panic_is_enabled(struct drm_device *dev) {return false; }
>>>> +static inline bool drm_panic_is_enabled(struct drm_device *dev) {return false; }
>>>> #endif
>>>>
>>>> #endif /* __DRM_CRTC_INTERNAL_H__ */
>>>> --
>>>> 2.45.2
>>>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-19 12:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-19 10:36 [PATCH] drm/panic: Add missing static inline to drm_panic_is_enabled() Jocelyn Falempe
2024-07-19 11:39 ` Imre Deak
2024-07-19 11:43 ` Imre Deak
2024-07-19 12:01 ` Imre Deak
2024-07-19 12:17 ` Jocelyn Falempe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.