All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jiqian Chen <Jiqian.Chen@amd.com>
Cc: xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	George Dunlap <gwd@xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony@xenproject.org>,
	Juergen Gross <jgross@suse.com>,
	"Daniel P . Smith" <dpsmith@apertussolutions.com>,
	Stewart Hildebrand <Stewart.Hildebrand@amd.com>,
	Huang Rui <ray.huang@amd.com>
Subject: Re: [XEN PATCH v12 4/7] x86/domctl: Add hypercall to set the access of x86 gsi
Date: Fri, 2 Aug 2024 10:08:14 +0200	[thread overview]
Message-ID: <ZqyT7ocbP6AZEb_S@macbook> (raw)
In-Reply-To: <20240708114124.407797-5-Jiqian.Chen@amd.com>

On Mon, Jul 08, 2024 at 07:41:21PM +0800, Jiqian Chen wrote:
> Some type of domains don't have PIRQs, like PVH, it doesn't do
> PHYSDEVOP_map_pirq for each gsi. When passthrough a device
> to guest base on PVH dom0, callstack
> pci_add_dm_done->XEN_DOMCTL_irq_permission will fail at function
> domain_pirq_to_irq, because PVH has no mapping of gsi, pirq and
> irq on Xen side.
> What's more, current hypercall XEN_DOMCTL_irq_permission requires
> passing in pirq to set the access of irq, it is not suitable for
> dom0 that doesn't have PIRQs.
> 
> So, add a new hypercall XEN_DOMCTL_gsi_permission to grant/deny
> the permission of irq(translate from x86 gsi) to dumU when dom0
> has no PIRQs.

I've been wondering about this, and if the hypercall is strictly to
resolve GSIs into IRQs, isn't that the case that Xen identity maps GSI
into the IRQ space, and hence no translation is required?

Thanks, Roger.


  parent reply	other threads:[~2024-08-02  8:16 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-08 11:41 [XEN PATCH v12 0/7] Support device passthrough when dom0 is PVH on Xen Jiqian Chen
2024-07-08 11:41 ` [XEN PATCH v12 1/7] xen/pci: Add hypercall to support reset of pcidev Jiqian Chen
2024-07-08 14:56   ` Jan Beulich
2024-07-09  2:47     ` Chen, Jiqian
2024-07-09  6:01       ` Jan Beulich
2024-07-31 15:55   ` Roger Pau Monné
2024-07-31 15:58     ` Jan Beulich
2024-07-31 16:13       ` Roger Pau Monné
2024-08-01  6:49         ` Jan Beulich
2024-08-02  2:56           ` Chen, Jiqian
2024-08-02  2:55     ` Chen, Jiqian
2024-08-02  6:25       ` Jan Beulich
2024-08-02  7:41         ` Chen, Jiqian
2024-08-02  7:43           ` Jan Beulich
2024-08-02  7:44         ` Roger Pau Monné
2024-07-08 11:41 ` [XEN PATCH v12 2/7] x86/pvh: Allow (un)map_pirq when dom0 is PVH Jiqian Chen
2024-07-08 14:58   ` Jan Beulich
2024-07-22 21:37   ` Stefano Stabellini
2024-07-30 13:09   ` Andrew Cooper
2024-07-31  1:47     ` Chen, Jiqian
2024-07-31  8:31     ` Chen, Jiqian
2024-07-31  8:42       ` Jan Beulich
2024-07-31  7:50   ` Roger Pau Monné
2024-07-31  7:58     ` Jan Beulich
2024-07-31  8:24       ` Roger Pau Monné
2024-07-31  8:40         ` Jan Beulich
2024-07-31  8:51           ` Roger Pau Monné
2024-07-31  9:02             ` Jan Beulich
2024-07-31  9:37               ` Roger Pau Monné
2024-07-31  9:55                 ` Jan Beulich
2024-07-31 11:29                   ` Roger Pau Monné
2024-07-31 11:39                     ` Jan Beulich
2024-07-31 13:03                       ` Roger Pau Monné
2024-08-02  2:37                         ` Chen, Jiqian
2024-08-02  8:11                           ` Roger Pau Monné
2024-08-02  8:17                             ` Chen, Jiqian
2024-08-02  8:35                               ` Roger Pau Monné
2024-08-02  8:40                                 ` Chen, Jiqian
2024-08-02  9:17                                   ` Jan Beulich
2024-08-02  9:37                             ` Jan Beulich
2024-07-31  8:39     ` Chen, Jiqian
2024-07-08 11:41 ` [XEN PATCH v12 3/7] x86/pvh: Add PHYSDEVOP_setup_gsi for PVH dom0 Jiqian Chen
2024-07-10  8:01   ` Chen, Jiqian
2024-07-11  7:58   ` Chen, Jiqian
2024-07-22 21:38   ` Stefano Stabellini
2024-07-08 11:41 ` [XEN PATCH v12 4/7] x86/domctl: Add hypercall to set the access of x86 gsi Jiqian Chen
2024-07-09 13:08   ` Jan Beulich
2024-07-26  6:55     ` Chen, Jiqian
2024-07-22 22:10   ` Stefano Stabellini
2024-07-26  6:53     ` Chen, Jiqian
2024-07-26 20:16       ` Stefano Stabellini
2024-08-01 11:06   ` Roger Pau Monné
2024-08-01 11:36     ` Jan Beulich
2024-08-01 12:41       ` Roger Pau Monné
2024-08-01 13:11         ` Jan Beulich
2024-08-02  3:10     ` Chen, Jiqian
2024-08-02  6:27       ` Jan Beulich
2024-08-02  7:44         ` Chen, Jiqian
2024-08-02  7:59       ` Roger Pau Monné
2024-08-02  8:08   ` Roger Pau Monné [this message]
2024-08-02  8:23     ` Chen, Jiqian
2024-08-02  9:40     ` Jan Beulich
2024-08-02 12:05       ` Roger Pau Monné
2024-07-08 11:41 ` [XEN PATCH v12 5/7] tools/libxc: Allow gsi be mapped into a free pirq Jiqian Chen
2024-07-09 13:26   ` Jan Beulich
2024-07-10  7:55     ` Chen, Jiqian
2024-08-01 12:55     ` Roger Pau Monné
2024-07-08 11:41 ` [RFC XEN PATCH v12 6/7] tools: Add new function to get gsi from dev Jiqian Chen
2024-07-08 13:27   ` Anthony PERARD
2024-07-09  3:35     ` Chen, Jiqian
2024-07-29 16:30       ` Anthony PERARD
2024-08-01 13:01   ` Roger Pau Monné
2024-08-02  3:13     ` Chen, Jiqian
2024-07-08 11:41 ` [RFC XEN PATCH v12 7/7] tools: Add new function to do PIRQ (un)map on PVH dom0 Jiqian Chen
2024-07-08 14:57   ` Anthony PERARD
2024-07-09  6:18     ` Chen, Jiqian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZqyT7ocbP6AZEb_S@macbook \
    --to=roger.pau@citrix.com \
    --cc=Jiqian.Chen@amd.com \
    --cc=Stewart.Hildebrand@amd.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony@xenproject.org \
    --cc=dpsmith@apertussolutions.com \
    --cc=gwd@xenproject.org \
    --cc=jbeulich@suse.com \
    --cc=jgross@suse.com \
    --cc=julien@xen.org \
    --cc=ray.huang@amd.com \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.