Re: [PATCH v4 1/6] i3c: mipi-i3c-hci: Add AMDI5017 ACPI ID to the I3C Support List

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Guruvendra Punugupati <Guruvendra.Punugupati@amd.com>,
	Krishnamoorthi M <krishnamoorthi.m@amd.com>,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/6] i3c: mipi-i3c-hci: Add AMDI5017 ACPI ID to the I3C Support List
Date: Wed, 21 Aug 2024 18:39:04 +0300	[thread overview]
Message-ID: <ZsYKGOLN3_2VU6Ld@smile.fi.intel.com> (raw)
In-Reply-To: <236aa6d9-bb5d-4854-86e3-5473f5ea6337@amd.com>

On Wed, Aug 21, 2024 at 08:42:12PM +0530, Shyam Sundar S K wrote:
> On 8/21/2024 19:26, Andy Shevchenko wrote:
> > On Wed, Aug 21, 2024 at 07:07:45PM +0530, Shyam Sundar S K wrote:
> >> On 8/21/2024 19:05, Shyam Sundar S K wrote:

...

> >>> This update adds the AMDI5017 ACPI ID to the list of supported IDs.

s/This update adds/Add/

> > Please, provide a DSDT excerpt to show how it will look like in the ACPI
> > tables.
> 
>     Scope (_SB)
>     {
> 	...
> 
>         Name (HCID, "AMDI5017")
>         Device (I3CA)
>         {
>             Method (_HID, 0, Serialized)  // _HID: Hardware ID
>             {
>                 If ((I30M == Zero))
>                 {
>                     If (CondRefOf (HCIB))
>                     {
>                         Return (HCID) /* \_SB_.HCID */
>                     }
>                     Else
>                     {
>                         Return (I3ID) /* \_SB_.I3ID */

Do I understand correctly that I3ID is the old one (as per another path I have
seen last week or so), i.o.w. *not* a MIPI allocated one?

If it's the case, feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
from ACPI ID perspective.

>                     }
>                 }
>                 Else
>                 {
>                     Return (I2ID) /* \_SB_.I2ID */
>                 }
>             }
> 	
> 	...
>     }

-- 
With Best Regards,
Andy Shevchenko

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c