All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Dave Vasilevsky <dave@vasilevsky.ca>
Cc: glaubitz@physik.fu-berlin.de, linuxppc-dev@lists.ozlabs.org,
	linux-sh@vger.kernel.org, mpe@ellerman.id.au,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	"Reimar Döffinger" <Reimar.Doeffinger@gmx.de>
Subject: Re: [PATCH] crash: Default to CRASH_DUMP=n when support for it is unlikely
Date: Fri, 30 Aug 2024 11:15:51 +0800	[thread overview]
Message-ID: <ZtE5Z/gDR1WixG9S@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20240823125156.104775-1-dave@vasilevsky.ca>

Hi Dave,

On 08/23/24 at 08:51am, Dave Vasilevsky wrote:
......snip..
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 1aa3c4a0c5b2..b04cfa23378c 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -549,6 +549,9 @@ config ARCH_SUPPORTS_KEXEC
>  config ARCH_SUPPORTS_CRASH_DUMP
>  	def_bool BROKEN_ON_SMP
>  
> +config ARCH_DEFAULT_CRASH_DUMP
> +	def_bool n

If we don't add ARCH_DEFAULT_CRASH_DUMP at all in sh arch, the
CRASH_DUMP will be off by default according to the below new definition
of CRASH_DUMP?

Thanks
Baoquan

> +
>  config ARCH_SUPPORTS_KEXEC_JUMP
>  	def_bool y
>  
......  
> diff --git a/kernel/Kconfig.kexec b/kernel/Kconfig.kexec
> index 6c34e63c88ff..4d111f871951 100644
> --- a/kernel/Kconfig.kexec
> +++ b/kernel/Kconfig.kexec
> @@ -97,7 +97,7 @@ config KEXEC_JUMP
>  
>  config CRASH_DUMP
>  	bool "kernel crash dumps"
> -	default y
> +	default ARCH_DEFAULT_CRASH_DUMP
>  	depends on ARCH_SUPPORTS_CRASH_DUMP
>  	depends on KEXEC_CORE
>  	select VMCORE_INFO
> -- 
> 2.34.1
> 


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Dave Vasilevsky <dave@vasilevsky.ca>
Cc: glaubitz@physik.fu-berlin.de, linuxppc-dev@lists.ozlabs.org,
	linux-sh@vger.kernel.org, mpe@ellerman.id.au,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	"Reimar Döffinger" <Reimar.Doeffinger@gmx.de>
Subject: Re: [PATCH] crash: Default to CRASH_DUMP=n when support for it is unlikely
Date: Fri, 30 Aug 2024 11:15:51 +0800	[thread overview]
Message-ID: <ZtE5Z/gDR1WixG9S@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20240823125156.104775-1-dave@vasilevsky.ca>

Hi Dave,

On 08/23/24 at 08:51am, Dave Vasilevsky wrote:
......snip..
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 1aa3c4a0c5b2..b04cfa23378c 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -549,6 +549,9 @@ config ARCH_SUPPORTS_KEXEC
>  config ARCH_SUPPORTS_CRASH_DUMP
>  	def_bool BROKEN_ON_SMP
>  
> +config ARCH_DEFAULT_CRASH_DUMP
> +	def_bool n

If we don't add ARCH_DEFAULT_CRASH_DUMP at all in sh arch, the
CRASH_DUMP will be off by default according to the below new definition
of CRASH_DUMP?

Thanks
Baoquan

> +
>  config ARCH_SUPPORTS_KEXEC_JUMP
>  	def_bool y
>  
......  
> diff --git a/kernel/Kconfig.kexec b/kernel/Kconfig.kexec
> index 6c34e63c88ff..4d111f871951 100644
> --- a/kernel/Kconfig.kexec
> +++ b/kernel/Kconfig.kexec
> @@ -97,7 +97,7 @@ config KEXEC_JUMP
>  
>  config CRASH_DUMP
>  	bool "kernel crash dumps"
> -	default y
> +	default ARCH_DEFAULT_CRASH_DUMP
>  	depends on ARCH_SUPPORTS_CRASH_DUMP
>  	depends on KEXEC_CORE
>  	select VMCORE_INFO
> -- 
> 2.34.1
> 


  parent reply	other threads:[~2024-08-30  3:16 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-23 12:51 [PATCH] crash: Default to CRASH_DUMP=n when support for it is unlikely Dave Vasilevsky
2024-08-23 12:51 ` Dave Vasilevsky
2024-08-23 13:13 ` Geert Uytterhoeven
2024-08-23 13:13   ` Geert Uytterhoeven
2024-08-23 18:16   ` John Paul Adrian Glaubitz
2024-08-23 18:16     ` John Paul Adrian Glaubitz
2024-08-27  6:22     ` Baoquan He
2024-08-27  6:22       ` Baoquan He
2024-08-27  6:37       ` John Paul Adrian Glaubitz
2024-08-27  6:37         ` John Paul Adrian Glaubitz
2024-08-27  9:01         ` Baoquan He
2024-08-27  9:01           ` Baoquan He
2024-08-26  2:02   ` Michael Ellerman
2024-08-26  2:02     ` Michael Ellerman
2024-08-26  5:38     ` John Paul Adrian Glaubitz
2024-08-26  5:38       ` John Paul Adrian Glaubitz
2024-08-26  6:03       ` Dave Vasilevsky
2024-08-26  6:03         ` Dave Vasilevsky
2024-08-30  3:15 ` Baoquan He [this message]
2024-08-30  3:15   ` Baoquan He
2024-08-30  3:37   ` Dave Vasilevsky
2024-08-30  3:37     ` Dave Vasilevsky
2024-08-30  6:30     ` Baoquan He
2024-08-30  6:30       ` Baoquan He
2024-08-30  6:35 ` Baoquan He
2024-08-30  6:35   ` Baoquan He
2024-08-30  7:24   ` Dave Vasilevsky
2024-08-30  7:24     ` Dave Vasilevsky
2024-09-08 19:57 ` Dave Vasilevsky
2024-09-08 19:57   ` Dave Vasilevsky
2024-09-09  2:35   ` Baoquan He
2024-09-09  2:35     ` Baoquan He
2024-09-09  6:40   ` Michael Ellerman
2024-09-09  6:40     ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtE5Z/gDR1WixG9S@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=Reimar.Doeffinger@gmx.de \
    --cc=dave@vasilevsky.ca \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.