Re: [PATCH 05/16] drm/i915/display: Add debugfs support to avoid joiner

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Mon, Sep 23, 2024 at 11:43:25PM +0530, Ankit Nautiyal wrote:
> Currently debugfs for joiner can take a value of 0->dont care and
> 2->join 2 pipes. Add option to force to use only 1 pipe.
> 
> If debugfs is set to 1, force to exactly one pipe (ie. no
> joiner despite what the automagic logic is saying).
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 80c499d642dc..af164e340cb3 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -1344,6 +1344,8 @@ static ssize_t i915_joiner_write(struct file *file,
>  	switch (force_joined_pipes) {
>  	case 0:
>  		break;
> +	case 1:
> +		fallthrough;

The 'fallthrough' is still redundant.

>  	case 2:
>  		connector->force_joined_pipes = force_joined_pipes;
>  		break;
> -- 
> 2.45.2

-- 
Ville Syrjälä
Intel