From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
suraj.kandpal@intel.com
Subject: Re: [PATCH 15/16] drm/i915/display: Consider ultrajoiner for computing maxdotclock
Date: Mon, 23 Sep 2024 22:08:11 +0300 [thread overview]
Message-ID: <ZvG8mwXNn5PgFPK7@intel.com> (raw)
In-Reply-To: <20240923181336.3303940-16-ankit.k.nautiyal@intel.com>
On Mon, Sep 23, 2024 at 11:43:35PM +0530, Ankit Nautiyal wrote:
> Use the check for ultrajoiner while computing maxdotclock.
>
> v2: Add Check for HAS_UNCOMPRESSED_JOINER. (Ville)
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 22ff3e225140..4c31d398ca4b 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -8189,8 +8189,10 @@ static int max_dotclock(struct drm_i915_private *i915)
> {
> int max_dotclock = i915->display.cdclk.max_dotclk_freq;
>
> - /* icl+ might use joiner */
> - if (HAS_BIGJOINER(i915))
> + if (HAS_ULTRAJOINER(i915))
> + max_dotclock *= 4;
> +
Extraneous newline. With that removed
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> + else if (HAS_UNCOMPRESSED_JOINER(i915) || HAS_BIGJOINER(i915))
> max_dotclock *= 2;
>
> return max_dotclock;
> --
> 2.45.2
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2024-09-23 19:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 18:13 [PATCH 00/16] Ultrajoiner basic functionality series Ankit Nautiyal
2024-09-23 18:13 ` [PATCH 01/16] drm/i915/display_device: Add Check HAS_DSC for bigjoiner Ankit Nautiyal
2024-09-23 18:30 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 02/16] drm/i915/display_debugfs: Allow force joiner only if supported Ankit Nautiyal
2024-09-23 18:34 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 03/16] drm/i915/display: Modify debugfs for joiner to force n pipes Ankit Nautiyal
2024-09-23 18:36 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 04/16] drm/i915/dp: Add helper to compute num pipes required Ankit Nautiyal
2024-09-23 18:13 ` [PATCH 05/16] drm/i915/display: Add debugfs support to avoid joiner Ankit Nautiyal
2024-09-23 18:38 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 06/16] drm/i915: Split current joiner hw state readout Ankit Nautiyal
2024-09-23 18:13 ` [PATCH 07/16] drm/i915: Add bigjoiner and uncompressed joiner hw readout sanity checks Ankit Nautiyal
2024-09-23 18:13 ` [PATCH 08/16] drm/i915/display: Add macro HAS_ULTRAJOINER() Ankit Nautiyal
2024-09-23 18:39 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 09/16] drm/i915: Implement hw state readout and checks for ultrajoiner Ankit Nautiyal
2024-09-23 18:44 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 10/16] drm/i915/display: Refactor enable_joiner_pipes Ankit Nautiyal
2024-09-23 18:52 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 11/16] drm/i915/display/vdsc: Add ultrajoiner support with DSC Ankit Nautiyal
2024-09-23 18:54 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 12/16] drm/i915/dp: Modify compressed bpp limitations for ultrajoiner Ankit Nautiyal
2024-09-23 18:32 ` Ankit Nautiyal
2024-09-23 18:13 ` [PATCH 13/16] drm/i915/dp: Modify helper to get slice count " Ankit Nautiyal
2024-09-23 19:04 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 14/16] drm/i915: Compute config and mode valid changes " Ankit Nautiyal
2024-09-23 19:06 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 15/16] drm/i915/display: Consider ultrajoiner for computing maxdotclock Ankit Nautiyal
2024-09-23 19:08 ` Ville Syrjälä [this message]
2024-09-23 18:13 ` [PATCH 16/16] drm/i915/intel_dp: Add support for forcing ultrajoiner Ankit Nautiyal
2024-09-23 19:09 ` Ville Syrjälä
2024-09-25 22:13 ` ✓ CI.Patch_applied: success for Ultrajoiner basic functionality series (rev3) Patchwork
2024-09-25 22:13 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-25 22:15 ` ✓ CI.KUnit: success " Patchwork
2024-09-25 22:26 ` ✓ CI.Build: " Patchwork
2024-09-25 22:29 ` ✓ CI.Hooks: " Patchwork
2024-09-25 22:30 ` ✗ CI.checksparse: warning " Patchwork
2024-09-25 22:59 ` ✗ CI.BAT: failure " Patchwork
2024-09-26 2:40 ` ✗ CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvG8mwXNn5PgFPK7@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=suraj.kandpal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.