All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/9] drm/xe: Remove double pageflip
@ 2024-11-07 10:01 Maarten Lankhorst
  2024-11-07 10:01 ` [PATCH 2/9] drm/xe/display: Add intel_plane_initial_vblank_wait Maarten Lankhorst
                   ` (23 more replies)
  0 siblings, 24 replies; 40+ messages in thread
From: Maarten Lankhorst @ 2024-11-07 10:01 UTC (permalink / raw)
  To: intel-xe
  Cc: intel-gfx, Maarten Lankhorst, Ville Syrjälä,
	Vinod Govindapillai, Lucas De Marchi, Maarten, Lankhorst, dev

This is already handled below by fixup_initial_plane_config.

Fixes: a8153627520a ("drm/i915: Try to relocate the BIOS fb to the start of ggtt")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241105121857.17389-1-maarten.lankhorst@linux.intel.com
Signed-off-by: Maarten Lankhorst,,, <dev@lankhorst.se>
---
 drivers/gpu/drm/xe/display/xe_plane_initial.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c b/drivers/gpu/drm/xe/display/xe_plane_initial.c
index 8c113463a3d55..668f544a7ac80 100644
--- a/drivers/gpu/drm/xe/display/xe_plane_initial.c
+++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c
@@ -194,8 +194,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
 		to_intel_plane(crtc->base.primary);
 	struct intel_plane_state *plane_state =
 		to_intel_plane_state(plane->base.state);
-	struct intel_crtc_state *crtc_state =
-		to_intel_crtc_state(crtc->base.state);
 	struct drm_framebuffer *fb;
 	struct i915_vma *vma;
 
@@ -241,14 +239,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
 	atomic_or(plane->frontbuffer_bit, &to_intel_frontbuffer(fb)->bits);
 
 	plane_config->vma = vma;
-
-	/*
-	 * Flip to the newly created mapping ASAP, so we can re-use the
-	 * first part of GGTT for WOPCM, prevent flickering, and prevent
-	 * the lookup of sysmem scratch pages.
-	 */
-	plane->check_plane(crtc_state, plane_state);
-	plane->async_flip(NULL, plane, crtc_state, plane_state, true);
 	return;
 
 nofb:
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 40+ messages in thread
* [PATCH 1/9] drm/xe: Remove double pageflip
@ 2024-11-05 12:18 Maarten Lankhorst
  2024-11-05 12:18 ` [PATCH 5/9] drm/xe/display: Use a single early init call for display Maarten Lankhorst
  0 siblings, 1 reply; 40+ messages in thread
From: Maarten Lankhorst @ 2024-11-05 12:18 UTC (permalink / raw)
  To: intel-xe
  Cc: intel-gfx, Maarten Lankhorst, Ville Syrjälä,
	Vinod Govindapillai, Lucas De Marchi

This is already handled below by fixup_initial_plane_config.

Fixes: a8153627520a ("drm/i915: Try to relocate the BIOS fb to the start of ggtt")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 drivers/gpu/drm/xe/display/xe_plane_initial.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c b/drivers/gpu/drm/xe/display/xe_plane_initial.c
index 8c113463a3d55..668f544a7ac80 100644
--- a/drivers/gpu/drm/xe/display/xe_plane_initial.c
+++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c
@@ -194,8 +194,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
 		to_intel_plane(crtc->base.primary);
 	struct intel_plane_state *plane_state =
 		to_intel_plane_state(plane->base.state);
-	struct intel_crtc_state *crtc_state =
-		to_intel_crtc_state(crtc->base.state);
 	struct drm_framebuffer *fb;
 	struct i915_vma *vma;
 
@@ -241,14 +239,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
 	atomic_or(plane->frontbuffer_bit, &to_intel_frontbuffer(fb)->bits);
 
 	plane_config->vma = vma;
-
-	/*
-	 * Flip to the newly created mapping ASAP, so we can re-use the
-	 * first part of GGTT for WOPCM, prevent flickering, and prevent
-	 * the lookup of sysmem scratch pages.
-	 */
-	plane->check_plane(crtc_state, plane_state);
-	plane->async_flip(NULL, plane, crtc_state, plane_state, true);
 	return;
 
 nofb:
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 40+ messages in thread

end of thread, other threads:[~2024-11-15 20:51 UTC | newest]

Thread overview: 40+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-07 10:01 [PATCH 1/9] drm/xe: Remove double pageflip Maarten Lankhorst
2024-11-07 10:01 ` [PATCH 2/9] drm/xe/display: Add intel_plane_initial_vblank_wait Maarten Lankhorst
2024-11-07 11:36   ` [PATCH] " Maarten Lankhorst
2024-11-07 12:21     ` Ville Syrjälä
2024-11-07 17:45       ` Maarten Lankhorst
2024-11-07 10:01 ` [PATCH 3/9] drm/xe: Move suballocator init to after display init Maarten Lankhorst
2024-11-12 18:18   ` Rodrigo Vivi
2024-11-07 10:01 ` [PATCH 4/9] drm/xe: Defer irq init until after xe_display_init_noaccel Maarten Lankhorst
2024-11-12 18:21   ` Rodrigo Vivi
2024-11-07 10:01 ` [PATCH 5/9] drm/xe/display: Use a single early init call for display Maarten Lankhorst
2024-11-12 18:39   ` Rodrigo Vivi
2024-11-13 10:30     ` Maarten Lankhorst
2024-11-14 16:05       ` Rodrigo Vivi
2024-11-07 10:01 ` [PATCH 6/9] drm/xe/sriov: Move VF bootstrap and query_config to vf_guc_init Maarten Lankhorst
2024-11-14 16:09   ` Rodrigo Vivi
2024-11-15 14:21     ` Maarten Lankhorst
2024-11-15 19:06       ` Rodrigo Vivi
2024-11-15 19:50         ` Maarten Lankhorst
2024-11-15 20:02           ` Rodrigo Vivi
2024-11-15 20:51             ` Maarten Lankhorst
2024-11-07 10:01 ` [PATCH 7/9] drm/xe: Simplify GuC early initialisation Maarten Lankhorst
2024-11-07 10:01 ` [PATCH 8/9] drm/xe: Make it possible to read instance0 MCR registers after xe_gt_mcr_init_early Maarten Lankhorst
2024-11-07 10:01 ` [PATCH 9/9] drm/xe: Split init of xe_gt_init_hwconfig to xe_gt_init and *_early Maarten Lankhorst
2024-11-07 10:08 ` ✓ CI.Patch_applied: success for series starting with [1/9] drm/xe: Remove double pageflip Patchwork
2024-11-07 10:08 ` ✗ CI.checkpatch: warning " Patchwork
2024-11-07 10:09 ` ✓ CI.KUnit: success " Patchwork
2024-11-07 10:14 ` ✗ CI.Build: failure " Patchwork
2024-11-07 10:16 ` ✗ Fi.CI.BUILD: " Patchwork
2024-11-07 12:23 ` ✓ Fi.CI.BAT: success for series starting with [1/9] drm/xe: Remove double pageflip (rev2) Patchwork
2024-11-07 12:23 ` ✗ Fi.CI.SPARSE: warning " Patchwork
2024-11-07 12:57 ` ✓ CI.Patch_applied: success " Patchwork
2024-11-07 12:57 ` ✗ CI.checkpatch: warning " Patchwork
2024-11-07 12:59 ` ✓ CI.KUnit: success " Patchwork
2024-11-07 13:10 ` ✓ CI.Build: " Patchwork
2024-11-07 13:12 ` ✓ CI.Hooks: " Patchwork
2024-11-07 13:14 ` ✗ CI.checksparse: warning " Patchwork
2024-11-07 13:52 ` ✓ CI.BAT: success " Patchwork
2024-11-07 13:57 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-11-08 20:13 ` ✗ CI.FULL: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-11-05 12:18 [PATCH 1/9] drm/xe: Remove double pageflip Maarten Lankhorst
2024-11-05 12:18 ` [PATCH 5/9] drm/xe/display: Use a single early init call for display Maarten Lankhorst

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.