* [RFC PATCH] ceph: fix the debug message for calc_layout
@ 2020-02-03 4:01 xiubli
2020-02-03 10:25 ` Ilya Dryomov
0 siblings, 1 reply; 3+ messages in thread
From: xiubli @ 2020-02-03 4:01 UTC (permalink / raw)
To: jlayton, idryomov, zyan; +Cc: sage, pdonnell, ceph-devel, Xiubo Li
From: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Xiubo Li <xiubli@redhat.com>
---
net/ceph/osd_client.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
index 108c9457d629..6afe36ffc1ba 100644
--- a/net/ceph/osd_client.c
+++ b/net/ceph/osd_client.c
@@ -113,10 +113,11 @@ static int calc_layout(struct ceph_file_layout *layout, u64 off, u64 *plen,
if (*objlen < orig_len) {
*plen = *objlen;
dout(" skipping last %llu, final file extent %llu~%llu\n",
- orig_len - *plen, off, *plen);
+ orig_len - *plen, off, off + *plen);
}
- dout("calc_layout objnum=%llx %llu~%llu\n", *objnum, *objoff, *objlen);
+ dout("calc_layout objnum=%llx, object extent %llu~%llu\n", *objnum,
+ *objoff, *objoff + *objlen);
return 0;
}
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RFC PATCH] ceph: fix the debug message for calc_layout
2020-02-03 4:01 [RFC PATCH] ceph: fix the debug message for calc_layout xiubli
@ 2020-02-03 10:25 ` Ilya Dryomov
2020-02-03 10:46 ` Xiubo Li
0 siblings, 1 reply; 3+ messages in thread
From: Ilya Dryomov @ 2020-02-03 10:25 UTC (permalink / raw)
To: Xiubo Li
Cc: Jeff Layton, Yan, Zheng, Sage Weil, Patrick Donnelly,
Ceph Development
On Mon, Feb 3, 2020 at 5:02 AM <xiubli@redhat.com> wrote:
>
> From: Xiubo Li <xiubli@redhat.com>
>
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
> net/ceph/osd_client.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
> index 108c9457d629..6afe36ffc1ba 100644
> --- a/net/ceph/osd_client.c
> +++ b/net/ceph/osd_client.c
> @@ -113,10 +113,11 @@ static int calc_layout(struct ceph_file_layout *layout, u64 off, u64 *plen,
> if (*objlen < orig_len) {
> *plen = *objlen;
> dout(" skipping last %llu, final file extent %llu~%llu\n",
> - orig_len - *plen, off, *plen);
> + orig_len - *plen, off, off + *plen);
> }
>
> - dout("calc_layout objnum=%llx %llu~%llu\n", *objnum, *objoff, *objlen);
> + dout("calc_layout objnum=%llx, object extent %llu~%llu\n", *objnum,
> + *objoff, *objoff + *objlen);
Hi Xiubo,
offset~length is how extents are printed both on the OSD side and
elsewhere in the kernel client.
Thanks,
Ilya
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFC PATCH] ceph: fix the debug message for calc_layout
2020-02-03 10:25 ` Ilya Dryomov
@ 2020-02-03 10:46 ` Xiubo Li
0 siblings, 0 replies; 3+ messages in thread
From: Xiubo Li @ 2020-02-03 10:46 UTC (permalink / raw)
To: Ilya Dryomov
Cc: Jeff Layton, Yan, Zheng, Sage Weil, Patrick Donnelly,
Ceph Development
On 2020/2/3 18:25, Ilya Dryomov wrote:
> On Mon, Feb 3, 2020 at 5:02 AM <xiubli@redhat.com> wrote:
>> From: Xiubo Li <xiubli@redhat.com>
>>
>> Signed-off-by: Xiubo Li <xiubli@redhat.com>
>> ---
>> net/ceph/osd_client.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
>> index 108c9457d629..6afe36ffc1ba 100644
>> --- a/net/ceph/osd_client.c
>> +++ b/net/ceph/osd_client.c
>> @@ -113,10 +113,11 @@ static int calc_layout(struct ceph_file_layout *layout, u64 off, u64 *plen,
>> if (*objlen < orig_len) {
>> *plen = *objlen;
>> dout(" skipping last %llu, final file extent %llu~%llu\n",
>> - orig_len - *plen, off, *plen);
>> + orig_len - *plen, off, off + *plen);
>> }
>>
>> - dout("calc_layout objnum=%llx %llu~%llu\n", *objnum, *objoff, *objlen);
>> + dout("calc_layout objnum=%llx, object extent %llu~%llu\n", *objnum,
>> + *objoff, *objoff + *objlen);
> Hi Xiubo,
>
> offset~length is how extents are printed both on the OSD side and
> elsewhere in the kernel client.
Okay, so my understanding is not correct then.
Thanks.
> Thanks,
>
> Ilya
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-03 10:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-03 4:01 [RFC PATCH] ceph: fix the debug message for calc_layout xiubli
2020-02-03 10:25 ` Ilya Dryomov
2020-02-03 10:46 ` Xiubo Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.