All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Wesley Cheng <quic_wcheng@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: phy: qcom: Relax required supplies
Date: Sat, 17 Oct 2026 09:51:07 +0200	[thread overview]
Message-ID: <a093e1ba-95cf-4767-82dc-c84db08a1edb@kernel.org> (raw)
In-Reply-To: <20260921232603.3129898-1-robh@kernel.org>

On 22/09/2026 01:26, Rob Herring (Arm) wrote:
> For the QUSB2 PHY binding, keep the three regulator supplies required
> except for legacy IPQ6018 nodes that do not describe the board rails.
> 
> Assisted-by: LLM
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
> 

I think this is fine. These devices do not expose controllable supplies,
so the supplies are there, but all other IPQxxxx variants just use
regulator-fixed stubs.

We can fix it by relaxing constraints or adding semi-fake regulator stubs.

With checkpatch warning fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Wesley Cheng <quic_wcheng@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: phy: qcom: Relax required supplies
Date: Sat, 17 Oct 2026 09:51:07 +0200	[thread overview]
Message-ID: <a093e1ba-95cf-4767-82dc-c84db08a1edb@kernel.org> (raw)
In-Reply-To: <20260921232603.3129898-1-robh@kernel.org>

On 22/09/2026 01:26, Rob Herring (Arm) wrote:
> For the QUSB2 PHY binding, keep the three regulator supplies required
> except for legacy IPQ6018 nodes that do not describe the board rails.
> 
> Assisted-by: LLM
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
> 

I think this is fine. These devices do not expose controllable supplies,
so the supplies are there, but all other IPQxxxx variants just use
regulator-fixed stubs.

We can fix it by relaxing constraints or adding semi-fake regulator stubs.

With checkpatch warning fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  parent reply	other threads:[~2026-10-17  7:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 23:26 [PATCH] dt-bindings: phy: qcom: Relax required supplies Rob Herring (Arm)
2026-09-21 23:26 ` Rob Herring (Arm)
2026-09-21 23:34 ` sashiko-bot
2026-09-21 23:34   ` sashiko-bot
2026-10-15 19:11   ` Rob Herring
2026-10-15 19:11     ` Rob Herring
2026-10-12 16:18 ` Manivannan Sadhasivam
2026-10-12 16:18   ` Manivannan Sadhasivam
2026-10-17  7:51 ` Krzysztof Kozlowski [this message]
2026-10-17  7:51   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a093e1ba-95cf-4767-82dc-c84db08a1edb@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mani@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_wcheng@quicinc.com \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.