From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Perry Yuan <Perry.Yuan@dell.com>,
oder_chiou@realtek.com, perex@perex.cz, tiwai@suse.com
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
broonie@kernel.org, lgirdwood@gmail.com,
Limonciello Mario <Mario.Limonciello@dell.com>
Subject: Re: [PATCH v2 2/2] ASoC: rt715:add Mic Mute LED control support
Date: Mon, 11 Jan 2021 12:07:11 -0600 [thread overview]
Message-ID: <a12075b1-09f3-a993-eace-008224ca5f52@linux.intel.com> (raw)
In-Reply-To: <20201228133831.17464-1-Perry_Yuan@Dell.com>
> @@ -268,6 +269,7 @@ static int rt715_sdca_put_volsw(struct snd_kcontrol *kcontrol,
> unsigned int reg2 = mc->rreg;
> unsigned int reg = mc->reg;
> unsigned int max = mc->max;
> + unsigned int val0, val1;
> int err;
>
> val = ucontrol->value.integer.value[0];
> @@ -286,7 +288,22 @@ static int rt715_sdca_put_volsw(struct snd_kcontrol *kcontrol,
> if (err < 0)
> return err;
> }
> -
> +#if IS_ENABLED(CONFIG_DELL_PRIVACY)
> + /* Privacy LED Trigger State Changed by muted/unmute switch */
> + if (mc->invert) {
> + val0 = ucontrol->value.integer.value[0];
> + val1 = ucontrol->value.integer.value[1];
> + if (val0 == 1 && val1 == 1) {
> + rt715->micmute_led = LED_OFF;
> + ledtrig_audio_set(LED_AUDIO_MICMUTE,
> + rt715->micmute_led ? LED_ON : LED_OFF);
> + } else if (val0 == 0 && val1 == 0) {
> + rt715->micmute_led = LED_ON;
> + ledtrig_audio_set(LED_AUDIO_MICMUTE,
> + rt715->micmute_led ? LED_ON : LED_OFF);
> + }
> + }
> +#endif
Should this be activated for specific DMI quirks? This driver is used in
non-Dell platforms (I am thinking of Intel RVPs or Realtek
daughterboards), I am not sure if a build-time behavior change makes sense.
Or conversely could we just set the LEDs unconditionally if doing so is
harmless?
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Perry Yuan <Perry.Yuan@dell.com>,
oder_chiou@realtek.com, perex@perex.cz, tiwai@suse.com
Cc: alsa-devel@alsa-project.org,
Limonciello Mario <Mario.Limonciello@dell.com>,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
broonie@kernel.org
Subject: Re: [PATCH v2 2/2] ASoC: rt715:add Mic Mute LED control support
Date: Mon, 11 Jan 2021 12:07:11 -0600 [thread overview]
Message-ID: <a12075b1-09f3-a993-eace-008224ca5f52@linux.intel.com> (raw)
In-Reply-To: <20201228133831.17464-1-Perry_Yuan@Dell.com>
> @@ -268,6 +269,7 @@ static int rt715_sdca_put_volsw(struct snd_kcontrol *kcontrol,
> unsigned int reg2 = mc->rreg;
> unsigned int reg = mc->reg;
> unsigned int max = mc->max;
> + unsigned int val0, val1;
> int err;
>
> val = ucontrol->value.integer.value[0];
> @@ -286,7 +288,22 @@ static int rt715_sdca_put_volsw(struct snd_kcontrol *kcontrol,
> if (err < 0)
> return err;
> }
> -
> +#if IS_ENABLED(CONFIG_DELL_PRIVACY)
> + /* Privacy LED Trigger State Changed by muted/unmute switch */
> + if (mc->invert) {
> + val0 = ucontrol->value.integer.value[0];
> + val1 = ucontrol->value.integer.value[1];
> + if (val0 == 1 && val1 == 1) {
> + rt715->micmute_led = LED_OFF;
> + ledtrig_audio_set(LED_AUDIO_MICMUTE,
> + rt715->micmute_led ? LED_ON : LED_OFF);
> + } else if (val0 == 0 && val1 == 0) {
> + rt715->micmute_led = LED_ON;
> + ledtrig_audio_set(LED_AUDIO_MICMUTE,
> + rt715->micmute_led ? LED_ON : LED_OFF);
> + }
> + }
> +#endif
Should this be activated for specific DMI quirks? This driver is used in
non-Dell platforms (I am thinking of Intel RVPs or Realtek
daughterboards), I am not sure if a build-time behavior change makes sense.
Or conversely could we just set the LEDs unconditionally if doing so is
harmless?
next prev parent reply other threads:[~2021-01-11 20:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 13:38 [PATCH v2 2/2] ASoC: rt715:add Mic Mute LED control support Perry Yuan
2020-12-28 13:38 ` Perry Yuan
2020-12-29 12:40 ` Mark Brown
2020-12-29 12:40 ` Mark Brown
2021-01-04 9:10 ` Yuan, Perry
2021-01-04 9:10 ` Yuan, Perry
2021-01-04 19:31 ` Limonciello, Mario
2021-01-04 19:31 ` Limonciello, Mario
2021-01-11 18:07 ` Pierre-Louis Bossart [this message]
2021-01-11 18:07 ` Pierre-Louis Bossart
2021-01-12 5:27 ` Yuan, Perry
2021-01-12 5:27 ` Yuan, Perry
2021-01-12 14:47 ` Limonciello, Mario
2021-01-12 14:47 ` Limonciello, Mario
2021-01-13 1:44 ` Yuan, Perry
2021-01-13 1:44 ` Yuan, Perry
2021-01-13 2:41 ` Pierre-Louis Bossart
2021-01-13 6:28 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a12075b1-09f3-a993-eace-008224ca5f52@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Mario.Limonciello@dell.com \
--cc=Perry.Yuan@dell.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.