[PATCH] drm/i915: Remove success dmesg noise for intel_rotate_pages()

[PATCH] drm/i915: Remove success dmesg noise for intel_rotate_pages()

[Chris Wilson]

During selftesting intel_rotate_pages() is very, very verbose without
giving us any information. Suppress the noise.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index e101b9a98957..41a203e0c160 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -3737,9 +3737,6 @@ intel_rotate_pages(struct intel_rotation_info *rot_info,
 				  rot_info->plane[i].stride, st, sg);
 	}
 
-	DRM_DEBUG_KMS("Created rotated page mapping for object size %zu (%ux%u tiles, %u pages)\n",
-		      obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
-
 	kvfree(page_addr_list);
 
 	return st;
@@ -3749,8 +3746,8 @@ intel_rotate_pages(struct intel_rotation_info *rot_info,
 err_st_alloc:
 	kvfree(page_addr_list);
 
-	DRM_DEBUG_KMS("Failed to create rotated mapping for object size %zu! (%ux%u tiles, %u pages)\n",
-		      obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
+	DRM_DEBUG_DRIVER("Failed to create rotated mapping for object size %zu! (%ux%u tiles, %u pages)\n",
+			 obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
 
 	return ERR_PTR(ret);
 }
-- 
2.15.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: Remove success dmesg noise for intel_rotate_pages()

[Patchwork]

== Series Details ==

Series: drm/i915: Remove success dmesg noise for intel_rotate_pages()
URL   : https://patchwork.freedesktop.org/series/34233/
State : success

== Summary ==

Series 34233v1 drm/i915: Remove success dmesg noise for intel_rotate_pages()
https://patchwork.freedesktop.org/api/1.0/series/34233/revisions/1/mbox/

Test gem_ringfill:
        Subgroup basic-default-hang:
                dmesg-warn -> PASS       (fi-blb-e6850) fdo#101600

fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:448s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:448s
fi-blb-e6850     total:289  pass:224  dwarn:0   dfail:0   fail:0   skip:65  time:378s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:557s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:277s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:501s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:509s
fi-byt-j1900     total:289  pass:254  dwarn:0   dfail:0   fail:0   skip:35  time:508s
fi-byt-n2820     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:487s
fi-cfl-s2        total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:612s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:431s
fi-gdg-551       total:289  pass:178  dwarn:1   dfail:0   fail:1   skip:109 time:265s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:544s
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:429s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:437s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:426s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:475s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:466s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:482s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:527s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:479s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:537s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:576s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:459s
fi-skl-6600u     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:543s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:566s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:520s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:502s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:463s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:551s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:419s
Blacklisted hosts:
fi-cnl-y         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:562s
fi-glk-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:496s

368de251cb3d8b5a69ea4e2731a2b53d329c8485 drm-tip: 2017y-11m-22d-11h-27m-26s UTC integration manifest
53e078049fba drm/i915: Remove success dmesg noise for intel_rotate_pages()

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7234/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for drm/i915: Remove success dmesg noise for intel_rotate_pages()

[Patchwork]

== Series Details ==

Series: drm/i915: Remove success dmesg noise for intel_rotate_pages()
URL   : https://patchwork.freedesktop.org/series/34233/
State : success

== Summary ==

Test kms_flip:
        Subgroup plain-flip-ts-check-interruptible:
                fail       -> PASS       (shard-hsw) fdo#100368
Test kms_setmode:
        Subgroup basic:
                pass       -> FAIL       (shard-hsw) fdo#99912
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
                pass       -> FAIL       (shard-snb) fdo#101623
Test perf:
        Subgroup oa-exponents:
                pass       -> FAIL       (shard-hsw) fdo#102254

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#102254 https://bugs.freedesktop.org/show_bug.cgi?id=102254

shard-hsw        total:2632 pass:1496 dwarn:9   dfail:1   fail:15  skip:1110 time:9007s
shard-snb        total:2632 pass:1279 dwarn:8   dfail:0   fail:17  skip:1327 time:7530s
Blacklisted hosts:
shard-apl        total:2667 pass:1683 dwarn:9   dfail:0   fail:21  skip:954 time:12340s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7234/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Remove success dmesg noise for intel_rotate_pages()

[Tvrtko Ursulin]

On 22/11/2017 14:56, Chris Wilson wrote:
> During selftesting intel_rotate_pages() is very, very verbose without
> giving us any information. Suppress the noise.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_gem_gtt.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index e101b9a98957..41a203e0c160 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -3737,9 +3737,6 @@ intel_rotate_pages(struct intel_rotation_info *rot_info,
>   				  rot_info->plane[i].stride, st, sg);
>   	}
>   
> -	DRM_DEBUG_KMS("Created rotated page mapping for object size %zu (%ux%u tiles, %u pages)\n",
> -		      obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
> -

Fair.

>   	kvfree(page_addr_list);
>   
>   	return st;
> @@ -3749,8 +3746,8 @@ intel_rotate_pages(struct intel_rotation_info *rot_info,
>   err_st_alloc:
>   	kvfree(page_addr_list);
>   
> -	DRM_DEBUG_KMS("Failed to create rotated mapping for object size %zu! (%ux%u tiles, %u pages)\n",
> -		      obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
> +	DRM_DEBUG_DRIVER("Failed to create rotated mapping for object size %zu! (%ux%u tiles, %u pages)\n",
> +			 obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);

Keep the failure perhaps?

Regards,

Tvrtko

>   
>   	return ERR_PTR(ret);
>   }
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Remove success dmesg noise for intel_rotate_pages()

[Chris Wilson]

Quoting Tvrtko Ursulin (2017-11-22 17:02:14)
> 
> On 22/11/2017 14:56, Chris Wilson wrote:
> > During selftesting intel_rotate_pages() is very, very verbose without
> > giving us any information. Suppress the noise.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> >   drivers/gpu/drm/i915/i915_gem_gtt.c | 7 ++-----
> >   1 file changed, 2 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > index e101b9a98957..41a203e0c160 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > @@ -3737,9 +3737,6 @@ intel_rotate_pages(struct intel_rotation_info *rot_info,
> >                                 rot_info->plane[i].stride, st, sg);
> >       }
> >   
> > -     DRM_DEBUG_KMS("Created rotated page mapping for object size %zu (%ux%u tiles, %u pages)\n",
> > -                   obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
> > -
> 
> Fair.
> 
> >       kvfree(page_addr_list);
> >   
> >       return st;
> > @@ -3749,8 +3746,8 @@ intel_rotate_pages(struct intel_rotation_info *rot_info,
> >   err_st_alloc:
> >       kvfree(page_addr_list);
> >   
> > -     DRM_DEBUG_KMS("Failed to create rotated mapping for object size %zu! (%ux%u tiles, %u pages)\n",
> > -                   obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
> > +     DRM_DEBUG_DRIVER("Failed to create rotated mapping for object size %zu! (%ux%u tiles, %u pages)\n",
> > +                      obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
> 
> Keep the failure perhaps?

I did? We're not KMS here, we are the driver allocating a view.
KMS/ATOMIC will get their turn to complain when they couldn't pin the
vma. I have to admit I was tempted to remove it, but thought that was a
step too far.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Remove success dmesg noise for intel_rotate_pages()

[Tvrtko Ursulin]

On 22/11/2017 17:12, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2017-11-22 17:02:14)
>>
>> On 22/11/2017 14:56, Chris Wilson wrote:
>>> During selftesting intel_rotate_pages() is very, very verbose without
>>> giving us any information. Suppress the noise.
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>> ---
>>>    drivers/gpu/drm/i915/i915_gem_gtt.c | 7 ++-----
>>>    1 file changed, 2 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
>>> index e101b9a98957..41a203e0c160 100644
>>> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
>>> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
>>> @@ -3737,9 +3737,6 @@ intel_rotate_pages(struct intel_rotation_info *rot_info,
>>>                                  rot_info->plane[i].stride, st, sg);
>>>        }
>>>    
>>> -     DRM_DEBUG_KMS("Created rotated page mapping for object size %zu (%ux%u tiles, %u pages)\n",
>>> -                   obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
>>> -
>>
>> Fair.
>>
>>>        kvfree(page_addr_list);
>>>    
>>>        return st;
>>> @@ -3749,8 +3746,8 @@ intel_rotate_pages(struct intel_rotation_info *rot_info,
>>>    err_st_alloc:
>>>        kvfree(page_addr_list);
>>>    
>>> -     DRM_DEBUG_KMS("Failed to create rotated mapping for object size %zu! (%ux%u tiles, %u pages)\n",
>>> -                   obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
>>> +     DRM_DEBUG_DRIVER("Failed to create rotated mapping for object size %zu! (%ux%u tiles, %u pages)\n",
>>> +                      obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
>>
>> Keep the failure perhaps?
> 
> I did? We're not KMS here, we are the driver allocating a view.
> KMS/ATOMIC will get their turn to complain when they couldn't pin the
> vma. I have to admit I was tempted to remove it, but thought that was a
> step too far.

Joke is on me. :)

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Remove success dmesg noise for intel_rotate_pages()

[Chris Wilson]

Quoting Tvrtko Ursulin (2017-11-22 17:24:13)
> 
> On 22/11/2017 17:12, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2017-11-22 17:02:14)
> >>
> >> On 22/11/2017 14:56, Chris Wilson wrote:
> >>> During selftesting intel_rotate_pages() is very, very verbose without
> >>> giving us any information. Suppress the noise.
> >>>
> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>> ---
> >>>    drivers/gpu/drm/i915/i915_gem_gtt.c | 7 ++-----
> >>>    1 file changed, 2 insertions(+), 5 deletions(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> >>> index e101b9a98957..41a203e0c160 100644
> >>> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> >>> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> >>> @@ -3737,9 +3737,6 @@ intel_rotate_pages(struct intel_rotation_info *rot_info,
> >>>                                  rot_info->plane[i].stride, st, sg);
> >>>        }
> >>>    
> >>> -     DRM_DEBUG_KMS("Created rotated page mapping for object size %zu (%ux%u tiles, %u pages)\n",
> >>> -                   obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
> >>> -
> >>
> >> Fair.
> >>
> >>>        kvfree(page_addr_list);
> >>>    
> >>>        return st;
> >>> @@ -3749,8 +3746,8 @@ intel_rotate_pages(struct intel_rotation_info *rot_info,
> >>>    err_st_alloc:
> >>>        kvfree(page_addr_list);
> >>>    
> >>> -     DRM_DEBUG_KMS("Failed to create rotated mapping for object size %zu! (%ux%u tiles, %u pages)\n",
> >>> -                   obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
> >>> +     DRM_DEBUG_DRIVER("Failed to create rotated mapping for object size %zu! (%ux%u tiles, %u pages)\n",
> >>> +                      obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
> >>
> >> Keep the failure perhaps?
> > 
> > I did? We're not KMS here, we are the driver allocating a view.
> > KMS/ATOMIC will get their turn to complain when they couldn't pin the
> > vma. I have to admit I was tempted to remove it, but thought that was a
> > step too far.
> 
> Joke is on me. :)
> 
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Ta, pushed.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx