All of lore.kernel.org
 help / color / mirror / Atom feed
From: thor.thayer@linux.intel.com (Thor Thayer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] arm64: dts: stratix10: Add QSPI support for Stratix10
Date: Tue, 15 May 2018 15:10:41 -0500	[thread overview]
Message-ID: <a61cbfaf-86e9-ec89-5d05-4d6f210aeec8@linux.intel.com> (raw)
In-Reply-To: <20b33e1d-0609-78dd-dc9c-922658a11f18@kernel.org>

On 05/15/2018 10:11 AM, Dinh Nguyen wrote:
> 
> On 05/11/2018 11:10 AM, thor.thayer at linux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>
>> Add qspi_clock
>>     The qspi_clk frequency is updated by U-Boot before starting Linux.
>> Add QSPI interface node.
>> Add QSPI flash memory child node.
>>     Setup the QSPI memory in 2 partitions.
>>
>> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
>> ---
>> v2  s/_/-/ in qspi-clk
>>      rename flash node.
>>      use partition child node notation<snip>>> +		qspi: spi at ff8d2000 {
>> +			compatible = "cdns,qspi-nor";
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			reg = <0xff8d2000 0x100>,
>> +			      <0xff900000 0x100000>;
>> +			interrupts = <0 3 4>;
>> +			cdns,fifo-depth = <128>;
>> +			cdns,fifo-width = <4>;
>> +			cdns,trigger-address = <0x00000000>;
>> +			clocks = <&qspi_clk>;
>> +			bus-num = <1>;
> 
> I don't you need "bus-num" anymore right? I don't see it getting used
> anywhere in the driver.
> 
> Dinh
> 

Yes, I missed that holdover. Thanks, I'll correct that.

WARNING: multiple messages have this Message-ID (diff)
From: Thor Thayer <thor.thayer@linux.intel.com>
To: Dinh Nguyen <dinguyen@kernel.org>,
	robh+dt@kernel.org, mark.rutland@arm.com
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] arm64: dts: stratix10: Add QSPI support for Stratix10
Date: Tue, 15 May 2018 15:10:41 -0500	[thread overview]
Message-ID: <a61cbfaf-86e9-ec89-5d05-4d6f210aeec8@linux.intel.com> (raw)
In-Reply-To: <20b33e1d-0609-78dd-dc9c-922658a11f18@kernel.org>

On 05/15/2018 10:11 AM, Dinh Nguyen wrote:
> 
> On 05/11/2018 11:10 AM, thor.thayer@linux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>
>> Add qspi_clock
>>     The qspi_clk frequency is updated by U-Boot before starting Linux.
>> Add QSPI interface node.
>> Add QSPI flash memory child node.
>>     Setup the QSPI memory in 2 partitions.
>>
>> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
>> ---
>> v2  s/_/-/ in qspi-clk
>>      rename flash node.
>>      use partition child node notation<snip>>> +		qspi: spi@ff8d2000 {
>> +			compatible = "cdns,qspi-nor";
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			reg = <0xff8d2000 0x100>,
>> +			      <0xff900000 0x100000>;
>> +			interrupts = <0 3 4>;
>> +			cdns,fifo-depth = <128>;
>> +			cdns,fifo-width = <4>;
>> +			cdns,trigger-address = <0x00000000>;
>> +			clocks = <&qspi_clk>;
>> +			bus-num = <1>;
> 
> I don't you need "bus-num" anymore right? I don't see it getting used
> anywhere in the driver.
> 
> Dinh
> 

Yes, I missed that holdover. Thanks, I'll correct that.

  reply	other threads:[~2018-05-15 20:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-11 16:10 [PATCHv2] arm64: dts: stratix10: Add QSPI support for Stratix10 thor.thayer at linux.intel.com
2018-05-11 16:10 ` thor.thayer
2018-05-15 15:11 ` Dinh Nguyen
2018-05-15 15:11   ` Dinh Nguyen
2018-05-15 20:10   ` Thor Thayer [this message]
2018-05-15 20:10     ` Thor Thayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a61cbfaf-86e9-ec89-5d05-4d6f210aeec8@linux.intel.com \
    --to=thor.thayer@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.