All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anilkumar Kolli <akolli@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless-owner@vger.kernel.org,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 4/4] ath10k: add debugfs support to dump per sta tx stats
Date: Tue, 04 Sep 2018 14:24:06 +0530	[thread overview]
Message-ID: <a6754e61eee013bd38dc9ba5463e2275@codeaurora.org> (raw)
In-Reply-To: <20180828133640.7D55E6044E@smtp.codeaurora.org>

On 2018-08-28 19:06, Kalle Valo wrote:
> Anilkumar Kolli <akolli@codeaurora.org> wrote:
> 
>> This patch adds 'tx_stats' in per station debugfs entry.
>> 
>> Use this command to dump tx_stats:
>> cat /sys/kernel/debug/ieee80211/phy0/netdev\:wlan0/
>>     stations/<MACADDR>/tx_stats
>> 
>> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> 
> kbuild bot found new warnings:
> 
>    drivers/net/wireless/ath/ath10k/debugfs_sta.c: In function
> 'ath10k_dbg_sta_dump_tx_stats':
>>> drivers/net/wireless/ath/ath10k/debugfs_sta.c:714:1: warning: the 
>>> frame size of 1088 bytes is larger than 1024 bytes 
>>> [-Wframe-larger-than=]
>     }
>     ^
> 
>    drivers/net/wireless/ath/ath10k/debugfs_sta.c: In function
> 'ath10k_sta_add_debugfs':
>>> drivers/net/wireless/ath/ath10k/debugfs_sta.c:737:41: error: 'struct 
>>> ath10k' has no member named 'debug'
>      if (ath10k_peer_stats_enabled(ar) && 
> ar->debug.enable_extd_tx_stats)
>                                             ^~

Please drop this patch series, I sent V2 addressing these issues.

Thanks
Anil.

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Anilkumar Kolli <akolli@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH 4/4] ath10k: add debugfs support to dump per sta tx stats
Date: Tue, 04 Sep 2018 14:24:06 +0530	[thread overview]
Message-ID: <a6754e61eee013bd38dc9ba5463e2275@codeaurora.org> (raw)
In-Reply-To: <20180828133640.7D55E6044E@smtp.codeaurora.org>

On 2018-08-28 19:06, Kalle Valo wrote:
> Anilkumar Kolli <akolli@codeaurora.org> wrote:
> 
>> This patch adds 'tx_stats' in per station debugfs entry.
>> 
>> Use this command to dump tx_stats:
>> cat /sys/kernel/debug/ieee80211/phy0/netdev\:wlan0/
>>     stations/<MACADDR>/tx_stats
>> 
>> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> 
> kbuild bot found new warnings:
> 
>    drivers/net/wireless/ath/ath10k/debugfs_sta.c: In function
> 'ath10k_dbg_sta_dump_tx_stats':
>>> drivers/net/wireless/ath/ath10k/debugfs_sta.c:714:1: warning: the 
>>> frame size of 1088 bytes is larger than 1024 bytes 
>>> [-Wframe-larger-than=]
>     }
>     ^
> 
>    drivers/net/wireless/ath/ath10k/debugfs_sta.c: In function
> 'ath10k_sta_add_debugfs':
>>> drivers/net/wireless/ath/ath10k/debugfs_sta.c:737:41: error: 'struct 
>>> ath10k' has no member named 'debug'
>      if (ath10k_peer_stats_enabled(ar) && 
> ar->debug.enable_extd_tx_stats)
>                                             ^~

Please drop this patch series, I sent V2 addressing these issues.

Thanks
Anil.

  reply	other threads:[~2018-09-04  8:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-06 13:13 [PATCH 0/4] Add support to dump tx stats histogram Anilkumar Kolli
2018-08-06 13:13 ` Anilkumar Kolli
2018-08-06 13:13 ` [PATCH 1/4] ath10k: get the legacy rate index to update the txrate table Anilkumar Kolli
2018-08-06 13:13   ` Anilkumar Kolli
2018-08-06 13:13 ` [PATCH 2/4] ath10k: add debugfs entry to enable extended tx stats Anilkumar Kolli
2018-08-06 13:13   ` Anilkumar Kolli
2018-08-06 13:13 ` [PATCH 3/4] ath10k: add extended per sta tx statistics support Anilkumar Kolli
2018-08-06 13:13   ` Anilkumar Kolli
2018-08-28 13:35   ` Kalle Valo
2018-08-28 13:35   ` Kalle Valo
2018-08-31 11:59   ` Kalle Valo
2018-08-31 11:59     ` Kalle Valo
2018-08-06 13:13 ` [PATCH 4/4] ath10k: add debugfs support to dump per sta tx stats Anilkumar Kolli
2018-08-06 13:13   ` Anilkumar Kolli
2018-08-28 13:36   ` Kalle Valo
2018-08-28 13:36   ` Kalle Valo
2018-09-04  8:54     ` Anilkumar Kolli [this message]
2018-09-04  8:54       ` Anilkumar Kolli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6754e61eee013bd38dc9ba5463e2275@codeaurora.org \
    --to=akolli@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless-owner@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.