All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avihai Horon <avihaih@nvidia.com>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: "Maciej S . Szmigiero" <mail@maciej.szmigiero.name>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Zhiyi Guo" <zhguo@redhat.com>,
	"Juraj Marcin" <jmarcin@redhat.com>,
	"Prasad Pandit" <ppandit@redhat.com>,
	"Kirti Wankhede" <kwankhede@nvidia.com>,
	"Cédric Le Goater" <clg@redhat.com>,
	"Fabiano Rosas" <farosas@suse.de>,
	"Joao Martins" <joao.m.martins@oracle.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Alex Williamson" <alex@shazbot.org>
Subject: Re: [PATCH 03/14] vfio/migration: Cache stop size in VFIOMigration
Date: Mon, 13 Apr 2026 12:52:52 +0300	[thread overview]
Message-ID: <a6c3aaf4-bbd4-4cb7-888c-ac498b032b87@nvidia.com> (raw)
In-Reply-To: <20260408165559.157108-4-peterx@redhat.com>


On 4/8/2026 7:55 PM, Peter Xu wrote:
> External email: Use caution opening links or attachments
>
>
> Add a field to cache stop size.  Note that there's an initial value change
> in vfio_save_setup for the stop size default, but it shouldn't matter if it
> is followed with a math of MIN() against VFIO_MIG_DEFAULT_DATA_BUFFER_SIZE.
>
> Document that all the three sizes we read from VFIO's uAPI on dirty or stop
> sizes are estimates, so QEMU needs to always remember they can be anything.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>   hw/vfio/vfio-migration-internal.h |  8 +++++
>   hw/vfio/migration.c               | 50 ++++++++++++++++++-------------
>   2 files changed, 38 insertions(+), 20 deletions(-)

Reviewed-by: Avihai Horon <avihaih@nvidia.com>



  reply	other threads:[~2026-04-13  9:58 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08 16:55 [PATCH 00/14] migration/vfio: Fix a few issues on API misuse or statistic reports Peter Xu
2026-04-08 16:55 ` [PATCH 01/14] migration: Fix low possibility downtime violation Peter Xu
2026-04-08 16:55 ` [PATCH 02/14] migration/qapi: Rename MigrationStats to MigrationRAMStats Peter Xu
2026-04-09 17:08   ` Juraj Marcin
2026-04-10 11:10   ` Michal Prívozník
2026-04-15 16:09     ` Peter Xu
2026-04-08 16:55 ` [PATCH 03/14] vfio/migration: Cache stop size in VFIOMigration Peter Xu
2026-04-13  9:52   ` Avihai Horon [this message]
2026-04-08 16:55 ` [PATCH 04/14] migration/treewide: Merge @state_pending_{exact|estimate} APIs Peter Xu
2026-04-09 17:10   ` Juraj Marcin
2026-04-15 16:23     ` Peter Xu
2026-04-16  8:24       ` Juraj Marcin
2026-04-13  9:57   ` Avihai Horon
2026-04-16 14:01     ` Peter Xu
2026-04-16 14:18   ` Jason J. Herne
2026-04-08 16:55 ` [PATCH 05/14] migration: Use the new save_query_pending() API directly Peter Xu
2026-04-13  9:59   ` Avihai Horon
2026-04-08 16:55 ` [PATCH 06/14] migration: Introduce stopcopy_bytes in save_query_pending() Peter Xu
2026-04-09 17:13   ` Juraj Marcin
2026-04-09 17:36   ` Juraj Marcin
2026-04-16 17:20     ` Peter Xu
2026-04-17 10:18       ` Juraj Marcin
2026-04-13 10:34   ` Avihai Horon
2026-04-08 16:55 ` [PATCH 07/14] vfio/migration: Fix incorrect reporting for VFIO pending data Peter Xu
2026-04-13 10:56   ` Avihai Horon
2026-04-08 16:55 ` [PATCH 08/14] migration: Make qemu_savevm_query_pending() available anytime Peter Xu
2026-04-09 17:15   ` Juraj Marcin
2026-04-16 18:06     ` Peter Xu
2026-04-17 10:26       ` Juraj Marcin
2026-04-20 15:56         ` Peter Xu
2026-04-08 16:55 ` [PATCH 09/14] migration: Move iteration counter out of RAM Peter Xu
2026-04-09 22:14   ` Fabiano Rosas
2026-04-16 18:15     ` Peter Xu
2026-04-16 21:15       ` Fabiano Rosas
2026-04-08 16:55 ` [PATCH 10/14] migration: Introduce a helper to return switchover bw estimate Peter Xu
2026-04-08 16:55 ` [PATCH 11/14] migration: Calculate expected downtime on demand Peter Xu
2026-04-09 17:16   ` Juraj Marcin
2026-04-08 16:55 ` [PATCH 12/14] migration: Fix calculation of expected_downtime to take VFIO info Peter Xu
2026-04-09 17:17   ` Juraj Marcin
2026-04-09 22:17   ` Fabiano Rosas
2026-04-16 18:19     ` Peter Xu
2026-04-08 16:55 ` [PATCH 13/14] migration/qapi: Introduce system-wise "remaining" reports Peter Xu
2026-04-09 17:41   ` Juraj Marcin
2026-04-09 21:48   ` Dr. David Alan Gilbert
2026-04-16 18:25     ` Peter Xu
2026-04-09 22:21   ` Fabiano Rosas
2026-04-16 18:26     ` Peter Xu
2026-04-08 16:55 ` [PATCH 14/14] migration/qapi: Update unit for avail-switchover-bandwidth Peter Xu
2026-04-09 17:40   ` Juraj Marcin
2026-04-08 18:37 ` [PATCH 00/14] migration/vfio: Fix a few issues on API misuse or statistic reports Peter Xu
2026-04-13 16:09 ` Cédric Le Goater
2026-04-15 16:06   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6c3aaf4-bbd4-4cb7-888c-ac498b032b87@nvidia.com \
    --to=avihaih@nvidia.com \
    --cc=alex@shazbot.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=clg@redhat.com \
    --cc=farosas@suse.de \
    --cc=jmarcin@redhat.com \
    --cc=joao.m.martins@oracle.com \
    --cc=kwankhede@nvidia.com \
    --cc=mail@maciej.szmigiero.name \
    --cc=peterx@redhat.com \
    --cc=ppandit@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhguo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.