Re: [PATCH 04/14] migration/treewide: Merge @state_pending_{exact|estimate} APIs

[Peter Xu <peterx@redhat.com>]

On Mon, Apr 13, 2026 at 12:57:17PM +0300, Avihai Horon wrote:
> > @@ -50,13 +50,8 @@ VFIO implements the device hooks for the iterative approach as follows:
> >   * A ``load_setup`` function that sets the VFIO device on the destination in
> >     _RESUMING state.
> > 
> > -* A ``state_pending_estimate`` function that reports an estimate of the
> > -  remaining pre-copy data that the vendor driver has yet to save for the VFIO
> > -  device.
> > -
> > -* A ``state_pending_exact`` function that reads pending_bytes from the vendor
> > -  driver, which indicates the amount of data that the vendor driver has yet to
> > -  save for the VFIO device.
> > +* A ``save_query_pending`` function that reports the remaining pre-copy
> > +  data that the vendor driver has yet to save for the VFIO device.
> 
> Maybe drop "pre-copy" since we also report stopcopy bytes?

Sure.

[...]

> > +    pending->precopy_bytes += remain;
> > +
> > +    trace_vfio_state_pending(vbasedev->name, migration->stopcopy_size,
> > +                             migration->precopy_init_size,
> > +                             migration->precopy_dirty_size);
> 
> Let's also log "exact", I think it can be useful.

Sure.

> 
> With this and Juraj's comment fixed:
> Reviewed-by: Avihai Horon <avihaih@nvidia.com>

Thanks,

-- 
Peter Xu