Re: [PATCH 04/14] migration/treewide: Merge @state_pending_{exact|estimate} APIs

[Juraj Marcin <jmarcin@redhat.com>]

On 2026-04-15 12:23, Peter Xu wrote:
> On Thu, Apr 09, 2026 at 07:10:56PM +0200, Juraj Marcin wrote:
> > > -    /**
> > > -     * @state_pending_exact
> > > -     *
> > > -     * This calculates the exact remaining data to transfer
> > > +     * @save_query_pending
> > >       *
> > > -     * Sum of @can_postcopy and @must_postcopy is the whole amount of
> > > -     * pending data.
> > > +     * This estimates the remaining data to transfer on the source side.
> > > +     * It's highly suggested that the module should implement both fastpath
> > > +     * and slowpath version of it when it can be slow (for more information
> > > +     * please check pending->fastpath field).
> > 
> > There is no pending->fastpath field anymore.
> 
> Yep I missed it..  When at it, I rewrote this part to make it read better,
> latest version now:
> 
>     /**
>      * @save_query_pending
>      *
>      * This estimates the remaining data to transfer on the source side.
>      *
>      * When @exact is true, a module must report accurate results.  When
>      * @exact is false, a module may report estimates.
>      *
>      * It's highly recommended that modules implement a faster version of
>      * the query path (for example, by proper caching on the counters) if
>      * an accurate query will be time-consuming.
>      *
>      * @opaque: data pointer passed to register_savevm_live()
>      * @pending: pointer to a MigPendingData struct
>      * @exact: set to true for an accurate (slow) query
>      */
>

Looks good, thanks!

> 
> [...]
> 
> > Apart from that one comment above, it looks good to me!
> > 
> > Reviewed-by: Juraj Marcin <jmarcin@redhat.com>
> 
> Thanks, Juraj!
> 
> -- 
> Peter Xu
>