Re: [PATCH 3/4] ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200

From: Krzysztof Kozlowski <krzk@kernel.org>
To: arinc.unal@arinc9.com, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Hauke Mehrtens <hauke@hauke-m.de>,
	Rafal Milecki <zajec5@gmail.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>
Cc: Tom Brautaset <tbrautaset@gmail.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200
Date: Sun, 14 Apr 2024 16:13:21 +0200	[thread overview]
Message-ID: <a88385a4-afad-4bd8-afc1-37e185e781f4@kernel.org> (raw)
In-Reply-To: <20240414-for-soc-asus-rt-ac3200-ac5300-v1-3-118c90bae6e5@arinc9.com>

On 14/04/2024 13:46, Arınç ÜNAL via B4 Relay wrote:
> From: Arınç ÜNAL <arinc.unal@arinc9.com>
> 
> Add the device tree for ASUS RT-AC3200 which is an AC3200 router featuring
> 5 Ethernet ports over the integrated Broadcom switch.
> 
> Hardware info:
> * Processor: Broadcom BCM4709A0 dual-core @ 1.0 GHz
> * Switch: BCM53012 in BCM4709A0
> * DDR3 RAM: 256 MB
> * Flash: 128 MB
> * 2.4GHz: BCM43602 3x3 single chip 802.11b/g/n SoC
> * 5GHz: BCM43602 3x3 two chips 802.11a/n/ac SoC
> * Ports: 4 LAN Ports, 1 WAN Port
> 
> Co-developed-by: Tom Brautaset <tbrautaset@gmail.com>
> Signed-off-by: Tom Brautaset <tbrautaset@gmail.com>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
>  arch/arm/boot/dts/broadcom/Makefile                |   1 +
>  .../boot/dts/broadcom/bcm4709-asus-rt-ac3200.dts   | 164 +++++++++++++++++++++
>  2 files changed, 165 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/broadcom/Makefile b/arch/arm/boot/dts/broadcom/Makefile
> index 7099d9560033..c61fca514775 100644
> --- a/arch/arm/boot/dts/broadcom/Makefile
> +++ b/arch/arm/boot/dts/broadcom/Makefile
> @@ -64,6 +64,7 @@ dtb-$(CONFIG_ARCH_BCM_5301X) += \
>  	bcm47081-luxul-xap-1410.dtb \
>  	bcm47081-luxul-xwr-1200.dtb \
>  	bcm47081-tplink-archer-c5-v2.dtb \
> +	bcm4709-asus-rt-ac3200.dtb \
>  	bcm4709-asus-rt-ac87u.dtb \
>  	bcm4709-buffalo-wxr-1900dhp.dtb \
>  	bcm4709-linksys-ea9200.dtb \
> diff --git a/arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dts b/arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dts
> new file mode 100644
> index 000000000000..8640dda211ae
> --- /dev/null
> +++ b/arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dts
> @@ -0,0 +1,164 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Author: Tom Brautaset <tbrautaset@gmail.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "bcm4709.dtsi"
> +#include "bcm5301x-nand-cs0-bch8.dtsi"
> +
> +#include <dt-bindings/leds/common.h>
> +
> +/ {
> +	compatible = "asus,rt-ac3200", "brcm,bcm4709", "brcm,bcm4708";
> +	model = "ASUS RT-AC3200";
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200 earlycon";

1. Use stdout.
2. Drop earlycon, it is for debugging, not regular mainline usage.

> +	};
> +
> +	memory@0 {
> +		device_type = "memory";
> +		reg = <0x00000000 0x08000000>,
> +		      <0x88000000 0x08000000>;
> +	};
> +
> +	nvram@1c080000 {
> +		compatible = "brcm,nvram";
> +		reg = <0x1c080000 0x00180000>;

Why is this outside of soc? Both soc node and soc DTSI?

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel