All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/mtl: Increase guard pages when vt-d is enabled
@ 2023-11-02 16:06 Radhakrishna Sripada
  2023-11-02 16:35 ` Gustavo Sousa
                   ` (3 more replies)
  0 siblings, 4 replies; 14+ messages in thread
From: Radhakrishna Sripada @ 2023-11-02 16:06 UTC (permalink / raw)
  To: intel-gfx; +Cc: Chris Wilson

Experiments were conducted with different multipliers to VTD_GUARD macro
with multiplier of 185 we were observing occasional pipe faults when
running kms_cursor_legacy --run-subtest single-bo

There could possibly be an underlying issue that is being investigated, for
now bump the guard pages for MTL.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2017
Cc: Gustavo Sousa <gustavo.sousa@intel.com>
Cc: Chris Wilson <chris.p.wilson@linux.intel.com>
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_domain.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_domain.c b/drivers/gpu/drm/i915/gem/i915_gem_domain.c
index 3770828f2eaf..b65f84c6bb3f 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_domain.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_domain.c
@@ -456,6 +456,9 @@ i915_gem_object_pin_to_display_plane(struct drm_i915_gem_object *obj,
 	if (intel_scanout_needs_vtd_wa(i915)) {
 		unsigned int guard = VTD_GUARD;
 
+		if (IS_METEORLAKE(i915))
+			guard *= 200;
+
 		if (i915_gem_object_is_tiled(obj))
 			guard = max(guard,
 				    i915_gem_object_get_tile_row_size(obj));
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2023-11-03 22:23 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-02 16:06 [Intel-gfx] [PATCH] drm/i915/mtl: Increase guard pages when vt-d is enabled Radhakrishna Sripada
2023-11-02 16:35 ` Gustavo Sousa
2023-11-02 18:01   ` Gustavo Sousa
2023-11-03 15:35   ` Rodrigo Vivi
2023-11-03 17:38     ` Sripada, Radhakrishna
2023-11-02 16:58 ` Andrzej Hajda
2023-11-02 17:41   ` Tvrtko Ursulin
2023-11-02 22:14     ` Sripada, Radhakrishna
2023-11-03  8:30       ` Tvrtko Ursulin
2023-11-03 15:53         ` Sripada, Radhakrishna
2023-11-03 21:18           ` Andrzej Hajda
2023-11-03 22:23             ` Sripada, Radhakrishna
2023-11-03  1:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-11-03 17:43 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.