All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Keith Busch <kbusch@meta.com>,
	linux-block@vger.kernel.org, axboe@kernel.dk,
	Matthew Wilcox <willy@infradead.org>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Anuj Gupta <anuj20.g@samsung.com>
Subject: Re: [PATCH] block: integrity: Do not call set_page_dirty_lock()
Date: Wed, 16 Apr 2025 23:16:24 -0700	[thread overview]
Message-ID: <aACcuGpErEsBcxop@infradead.org> (raw)
In-Reply-To: <yq1v7r3ev9g.fsf@ca-mkp.ca.oracle.com>

On Wed, Apr 16, 2025 at 04:04:10PM -0400, Martin K. Petersen wrote:
> 
> Placing multiple protection information buffers inside the same page
> can lead to oopses because set_page_dirty_lock() can't be called from
> interrupt context.
> 
> Since a protection information buffer is not backed by a file there is
> no point in setting its page dirty, there is nothing to synchronize.
> Drop the call to set_page_dirty_lock() and remove the last argument to
> bio_integrity_unpin_bvec().

Who sais it it not backed by a file?  Which that would be a very unusual
use case, there is nothing limiting us from using integity or metadata
from a file mapping.  Instead we'll need to do the same thing for the
data path and defer the unmapping to a user context when needed.

(Assuming we can get rid of this entirely, about which we have another
discussion I don't have time to follow up on as I'm on vacation)


  parent reply	other threads:[~2025-04-17  6:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-16 20:04 [PATCH] block: integrity: Do not call set_page_dirty_lock() Martin K. Petersen
2025-04-16 20:15 ` Keith Busch
2025-04-16 22:01   ` Martin K. Petersen
2025-04-16 20:17 ` Jens Axboe
2025-04-17  6:16 ` Christoph Hellwig [this message]
2025-04-17 14:05   ` Martin K. Petersen
2025-04-21  5:12     ` Christoph Hellwig
2025-04-22  2:14       ` Martin K. Petersen
2025-04-22  6:13         ` Christoph Hellwig
2025-04-17 14:36 ` Matthew Wilcox
2025-04-21 12:06   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aACcuGpErEsBcxop@infradead.org \
    --to=hch@infradead.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=anuj20.g@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=kbusch@meta.com \
    --cc=linux-block@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.