From: Christoph Hellwig <hch@infradead.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, axboe@kernel.dk,
Matthew Wilcox <willy@infradead.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Anuj Gupta <anuj20.g@samsung.com>
Subject: Re: [PATCH] block: integrity: Do not call set_page_dirty_lock()
Date: Mon, 21 Apr 2025 23:13:07 -0700 [thread overview]
Message-ID: <aAczcwHDWmlDgtdy@infradead.org> (raw)
In-Reply-To: <yq1a5899caj.fsf@ca-mkp.ca.oracle.com>
On Mon, Apr 21, 2025 at 10:14:27PM -0400, Martin K. Petersen wrote:
> > I do not personally have a use case. But we support using file backed
> > memory right now and have since adding these user interfaces. Suddenly
> > removing the dirtying will cause silent data corruptions for these use
> > cases if they exist, which is not a good change.
>
> Oopsing in the common use case isn't desirable either, though :(
Agreed.
> In any case I'll work some more on this tomorrow unless you beat me to
> it.
I'm not going to get to this today, I'm still in holiday catchup mode
with a huge unread inbox.
next prev parent reply other threads:[~2025-04-22 6:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 20:04 [PATCH] block: integrity: Do not call set_page_dirty_lock() Martin K. Petersen
2025-04-16 20:15 ` Keith Busch
2025-04-16 22:01 ` Martin K. Petersen
2025-04-16 20:17 ` Jens Axboe
2025-04-17 6:16 ` Christoph Hellwig
2025-04-17 14:05 ` Martin K. Petersen
2025-04-21 5:12 ` Christoph Hellwig
2025-04-22 2:14 ` Martin K. Petersen
2025-04-22 6:13 ` Christoph Hellwig [this message]
2025-04-17 14:36 ` Matthew Wilcox
2025-04-21 12:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAczcwHDWmlDgtdy@infradead.org \
--to=hch@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.