From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Keith Busch <kbusch@kernel.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, axboe@kernel.dk,
Matthew Wilcox <willy@infradead.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Anuj Gupta <anuj20.g@samsung.com>
Subject: Re: [PATCH] block: integrity: Do not call set_page_dirty_lock()
Date: Wed, 16 Apr 2025 18:01:28 -0400 [thread overview]
Message-ID: <yq1plhbdbmq.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <aAAP-Kp5bxWe4ny1@kbusch-mbp.dhcp.thefacebook.com> (Keith Busch's message of "Wed, 16 Apr 2025 14:15:52 -0600")
Hi Keith!
> Thanks! I had just posted a test for this scenario earlier today for
> liburing:
>
> https://lore.kernel.org/io-uring/20250416162802.3614051-1-kbusch@meta.com/T/#u
>
> I was wondering why it didn't blow up.
It triggered on our end with a heavily threaded workload. Each thread is
reading fixed-size 8KB blocks. The small block size results in needing
small PI allocations. And with thousands of I/Os in flight at any point
in time, we are fairly likely to end up with PI allocations sharing a
page.
--
Martin K. Petersen
next prev parent reply other threads:[~2025-04-16 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 20:04 [PATCH] block: integrity: Do not call set_page_dirty_lock() Martin K. Petersen
2025-04-16 20:15 ` Keith Busch
2025-04-16 22:01 ` Martin K. Petersen [this message]
2025-04-16 20:17 ` Jens Axboe
2025-04-17 6:16 ` Christoph Hellwig
2025-04-17 14:05 ` Martin K. Petersen
2025-04-21 5:12 ` Christoph Hellwig
2025-04-22 2:14 ` Martin K. Petersen
2025-04-22 6:13 ` Christoph Hellwig
2025-04-17 14:36 ` Matthew Wilcox
2025-04-21 12:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1plhbdbmq.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.