All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peilin Ye <yepeilin@google.com>
To: Pu Lehui <pulehui@huawei.com>
Cc: bpf@vger.kernel.org, linux-riscv@lists.infradead.org,
	"Andrea Parri" <parri.andrea@gmail.com>,
	"Björn Töpel" <bjorn@kernel.org>,
	"Puranjay Mohan" <puranjay@kernel.org>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Martin KaFai Lau" <martin.lau@linux.dev>,
	"Eduard Zingerman" <eddyz87@gmail.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	"Song Liu" <song@kernel.org>,
	"Yonghong Song" <yonghong.song@linux.dev>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"KP Singh" <kpsingh@kernel.org>,
	"Stanislav Fomichev" <sdf@fomichev.me>,
	"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
	"Luke Nelson" <luke.r.nels@gmail.com>,
	"Xi Wang" <xi.wang@gmail.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	"Mykola Lysenko" <mykolal@fb.com>,
	"Shuah Khan" <shuah@kernel.org>, "Josh Don" <joshdon@google.com>,
	"Barret Rhoden" <brho@google.com>,
	"Neel Natu" <neelnatu@google.com>,
	"Benjamin Segall" <bsegall@google.com>
Subject: Re: [PATCH bpf-next 0/8] bpf, riscv64: Support load-acquire and store-release instructions
Date: Wed, 30 Apr 2025 19:47:42 +0000	[thread overview]
Message-ID: <aBJ-Xq8Aks4xHw3b@google.com> (raw)
In-Reply-To: <e6805e47-befa-427f-a73f-2dba92adf059@huawei.com>

Hi Lehui,

On Wed, Apr 30, 2025 at 11:56:03AM +0800, Pu Lehui wrote:
> On 2025/4/30 8:48, Peilin Ye wrote:
> > Andrea Parri (2):
> >    bpf, riscv64: Introduce emit_load_*() and emit_store_*()
> >    bpf, riscv64: Support load-acquire and store-release instructions
> > 
> > Peilin Ye (6):
> >    bpf/verifier: Handle BPF_LOAD_ACQ instructions in insn_def_regno()
> >    bpf, riscv64: Skip redundant zext instruction after load-acquire
> >    selftests/bpf: Use CAN_USE_LOAD_ACQ_STORE_REL when appropriate
> >    selftests/bpf: Avoid passing out-of-range values to __retval()
> >    selftests/bpf: Verify zero-extension behavior in load-acquire tests
> >    selftests/bpf: Enable non-arena load-acquire/store-release selftests
> >      for riscv64
> > 
> >   arch/riscv/net/bpf_jit.h                      |  15 +
> >   arch/riscv/net/bpf_jit_comp64.c               | 334 ++++++++++++------
> >   arch/riscv/net/bpf_jit_core.c                 |   3 +-
> >   kernel/bpf/verifier.c                         |  11 +-
> >   tools/testing/selftests/bpf/progs/bpf_misc.h  |   5 +-
> >   .../bpf/progs/verifier_load_acquire.c         |  48 ++-
> >   .../selftests/bpf/progs/verifier_precision.c  |   5 +-
> >   .../bpf/progs/verifier_store_release.c        |  39 +-
> >   8 files changed, 314 insertions(+), 146 deletions(-)
> 
> Hi Peilin, good to see the implementation of load-acquire and store-release
> instructions on RV64! But I'm about to start my vacation, so I'll test it
> once I'm back.

Thanks for the reviews, and have a great vacation!

Peilin Ye


WARNING: multiple messages have this Message-ID (diff)
From: Peilin Ye <yepeilin@google.com>
To: Pu Lehui <pulehui@huawei.com>
Cc: bpf@vger.kernel.org, linux-riscv@lists.infradead.org,
	"Andrea Parri" <parri.andrea@gmail.com>,
	"Björn Töpel" <bjorn@kernel.org>,
	"Puranjay Mohan" <puranjay@kernel.org>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Martin KaFai Lau" <martin.lau@linux.dev>,
	"Eduard Zingerman" <eddyz87@gmail.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	"Song Liu" <song@kernel.org>,
	"Yonghong Song" <yonghong.song@linux.dev>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"KP Singh" <kpsingh@kernel.org>,
	"Stanislav Fomichev" <sdf@fomichev.me>,
	"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
	"Luke Nelson" <luke.r.nels@gmail.com>,
	"Xi Wang" <xi.wang@gmail.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	"Mykola Lysenko" <mykolal@fb.com>,
	"Shuah Khan" <shuah@kernel.org>, "Josh Don" <joshdon@google.com>,
	"Barret Rhoden" <brho@google.com>,
	"Neel Natu" <neelnatu@google.com>,
	"Benjamin Segall" <bsegall@google.com>
Subject: Re: [PATCH bpf-next 0/8] bpf, riscv64: Support load-acquire and store-release instructions
Date: Wed, 30 Apr 2025 19:47:42 +0000	[thread overview]
Message-ID: <aBJ-Xq8Aks4xHw3b@google.com> (raw)
In-Reply-To: <e6805e47-befa-427f-a73f-2dba92adf059@huawei.com>

Hi Lehui,

On Wed, Apr 30, 2025 at 11:56:03AM +0800, Pu Lehui wrote:
> On 2025/4/30 8:48, Peilin Ye wrote:
> > Andrea Parri (2):
> >    bpf, riscv64: Introduce emit_load_*() and emit_store_*()
> >    bpf, riscv64: Support load-acquire and store-release instructions
> > 
> > Peilin Ye (6):
> >    bpf/verifier: Handle BPF_LOAD_ACQ instructions in insn_def_regno()
> >    bpf, riscv64: Skip redundant zext instruction after load-acquire
> >    selftests/bpf: Use CAN_USE_LOAD_ACQ_STORE_REL when appropriate
> >    selftests/bpf: Avoid passing out-of-range values to __retval()
> >    selftests/bpf: Verify zero-extension behavior in load-acquire tests
> >    selftests/bpf: Enable non-arena load-acquire/store-release selftests
> >      for riscv64
> > 
> >   arch/riscv/net/bpf_jit.h                      |  15 +
> >   arch/riscv/net/bpf_jit_comp64.c               | 334 ++++++++++++------
> >   arch/riscv/net/bpf_jit_core.c                 |   3 +-
> >   kernel/bpf/verifier.c                         |  11 +-
> >   tools/testing/selftests/bpf/progs/bpf_misc.h  |   5 +-
> >   .../bpf/progs/verifier_load_acquire.c         |  48 ++-
> >   .../selftests/bpf/progs/verifier_precision.c  |   5 +-
> >   .../bpf/progs/verifier_store_release.c        |  39 +-
> >   8 files changed, 314 insertions(+), 146 deletions(-)
> 
> Hi Peilin, good to see the implementation of load-acquire and store-release
> instructions on RV64! But I'm about to start my vacation, so I'll test it
> once I'm back.

Thanks for the reviews, and have a great vacation!

Peilin Ye


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2025-04-30 19:47 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30  0:48 [PATCH bpf-next 0/8] bpf, riscv64: Support load-acquire and store-release instructions Peilin Ye
2025-04-30  0:48 ` Peilin Ye
2025-04-30  0:50 ` [PATCH bpf-next 1/8] bpf/verifier: Handle BPF_LOAD_ACQ instructions in insn_def_regno() Peilin Ye
2025-04-30  0:50   ` Peilin Ye
2025-05-06 14:03   ` Pu Lehui
2025-05-06 14:03     ` Pu Lehui
2025-05-07  0:18     ` Peilin Ye
2025-05-07  0:18       ` Peilin Ye
2025-04-30  0:50 ` [PATCH bpf-next 2/8] bpf, riscv64: Introduce emit_load_*() and emit_store_*() Peilin Ye
2025-04-30  0:50   ` Peilin Ye
2025-04-30  3:48   ` Pu Lehui
2025-04-30  3:48     ` Pu Lehui
2025-04-30  0:50 ` [PATCH bpf-next 3/8] bpf, riscv64: Support load-acquire and store-release instructions Peilin Ye
2025-04-30  0:50   ` Peilin Ye
2025-04-30  3:48   ` Pu Lehui
2025-04-30  3:48     ` Pu Lehui
2025-05-06 14:20   ` Pu Lehui
2025-05-06 14:20     ` Pu Lehui
2025-05-07  0:23     ` Peilin Ye
2025-05-07  0:23       ` Peilin Ye
2025-04-30  0:50 ` [PATCH bpf-next 4/8] bpf, riscv64: Skip redundant zext instruction after load-acquire Peilin Ye
2025-04-30  0:50   ` Peilin Ye
2025-04-30  3:48   ` Pu Lehui
2025-04-30  3:48     ` Pu Lehui
2025-04-30  0:51 ` [PATCH bpf-next 5/8] selftests/bpf: Use CAN_USE_LOAD_ACQ_STORE_REL when appropriate Peilin Ye
2025-04-30  0:51   ` Peilin Ye
2025-05-06 14:22   ` Pu Lehui
2025-05-06 14:22     ` Pu Lehui
2025-04-30  0:51 ` [PATCH bpf-next 6/8] selftests/bpf: Avoid passing out-of-range values to __retval() Peilin Ye
2025-04-30  0:51   ` Peilin Ye
2025-05-06 14:23   ` Pu Lehui
2025-05-06 14:23     ` Pu Lehui
2025-04-30  0:51 ` [PATCH bpf-next 7/8] selftests/bpf: Verify zero-extension behavior in load-acquire tests Peilin Ye
2025-04-30  0:51   ` Peilin Ye
2025-05-06 14:23   ` Pu Lehui
2025-05-06 14:23     ` Pu Lehui
2025-04-30  0:51 ` [PATCH bpf-next 8/8] selftests/bpf: Enable non-arena load-acquire/store-release selftests for riscv64 Peilin Ye
2025-04-30  0:51   ` Peilin Ye
2025-05-06 14:23   ` Pu Lehui
2025-05-06 14:23     ` Pu Lehui
2025-04-30  3:56 ` [PATCH bpf-next 0/8] bpf, riscv64: Support load-acquire and store-release instructions Pu Lehui
2025-04-30  3:56   ` Pu Lehui
2025-04-30 19:47   ` Peilin Ye [this message]
2025-04-30 19:47     ` Peilin Ye
2025-05-02 15:43 ` Björn Töpel
2025-05-02 15:43   ` Björn Töpel
2025-05-03  1:03   ` Peilin Ye
2025-05-03  1:03     ` Peilin Ye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBJ-Xq8Aks4xHw3b@google.com \
    --to=yepeilin@google.com \
    --cc=alex@ghiti.fr \
    --cc=andrii@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=ast@kernel.org \
    --cc=bjorn@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brho@google.com \
    --cc=bsegall@google.com \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=joshdon@google.com \
    --cc=kpsingh@kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=luke.r.nels@gmail.com \
    --cc=martin.lau@linux.dev \
    --cc=mykolal@fb.com \
    --cc=neelnatu@google.com \
    --cc=palmer@dabbelt.com \
    --cc=parri.andrea@gmail.com \
    --cc=paul.walmsley@sifive.com \
    --cc=paulmck@kernel.org \
    --cc=pulehui@huawei.com \
    --cc=puranjay@kernel.org \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=xi.wang@gmail.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.