Re: [PATCH v3 20/23] mailbox/riscv-sbi-mpxy: Add ACPI support

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Sun, May 11, 2025 at 07:09:36PM +0530, Anup Patel wrote:
> From: Sunil V L <sunilvl@ventanamicro.com>
> 
> Add ACPI support for the RISC-V SBI message proxy (MPXY) based
> mailbox driver.

...

> -		if (is_of_node(dev_fwnode(dev)))
> +		if (is_of_node(dev_fwnode(dev))) {
>  			of_msi_configure(dev, to_of_node(dev_fwnode(dev)));
> +		} else {

You probably want to have this as

		} else if (is_acpi_..._node()) { // you should decide if it is data, device or any type of ACPI node you match with

> +			msi_domain = irq_find_matching_fwnode(imsic_acpi_get_fwnode(dev),
> +							      DOMAIN_BUS_PLATFORM_MSI);
> +			dev_set_msi_domain(dev, msi_domain);
> +		}
>  	}

...

> +#ifdef CONFIG_ACPI
> +	if (!acpi_disabled)

Hmm... Why do you need this check? What for?

> +		acpi_dev_clear_dependencies(ACPI_COMPANION(dev));
> +#endif

-- 
With Best Regards,
Andy Shevchenko