Re: [PATCH v3 9/9] scripts/checkpatch: reject license boilerplate on new files

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, May 15, 2025 at 06:19:45PM +0200, Cédric Le Goater wrote:
> On 5/15/25 18:06, Cédric Le Goater wrote:
> > On 5/15/25 18:05, Daniel P. Berrangé wrote:
> > > On Thu, May 15, 2025 at 02:59:36PM +0100, Daniel P. Berrangé wrote:
> > > > The previous commit mandates use of SPDX-License-Identifier on common
> > > > source files, and encourages it on all other files.
> > > > 
> > > > Some contributors are none the less still also including the license
> > > > boilerplate text. This is redundant and will potentially cause
> > > > trouble if inconsistent with the SPDX declaration.
> > > > 
> > > > Match common boilerplate text blurbs and report them as invalid,
> > > > for newly added files.
> > > > 
> > > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > > > ---
> > > >   scripts/checkpatch.pl | 16 ++++++++++++++++
> > > >   1 file changed, 16 insertions(+)


> It is now catching valid errors on :
> 
> 
> * https://lore.kernel.org/qemu-devel/20250512180230.50129-5-rreyes@linux.ibm.com/
>   ERROR: New file 'hw/s390x/ap-stub.c' must not have license boilerplate header text unless this file is copied from existing code with such text already present.
>   total: 1 errors, 0 warnings, 67 lines checked
> 
> * https://lore.kernel.org/qemu-devel/1747063973-124548-7-git-send-email-steven.sistare@oracle.com/
>   ERROR: New file 'hw/vfio/cpr-legacy.c' requires 'SPDX-License-Identifier'
>   ERROR: New file 'hw/vfio/cpr-legacy.c' must not have license boilerplate header text unless this file is copied from existing code with such text already present.
>   WARNING: added, moved or deleted file(s):
> 
> * https://lore.kernel.org/qemu-devel/1747063973-124548-36-git-send-email-steven.sistare@oracle.com/
>   ERROR: New file 'hw/vfio/cpr-iommufd.c' requires 'SPDX-License-Identifier'
>   ERROR: New file 'hw/vfio/cpr-iommufd.c' must not have license boilerplate header text unless this file is copied from existing code with such text already present.
>   WARNING: added, moved or deleted file(s):
>     hw/vfio/cpr-iommufd.c
>   Does MAINTAINERS need updating?
>   total: 2 errors, 1 warnings, 161 lines checked
> 
> * https://lore.kernel.org/qemu-devel/20250515154413.210315-1-john.levon@nutanix.com
>   ERROR: New file 'hw/vfio-user/container.h' must not have license boilerplate header text unless this file is copied from existing code with such text already present.
>   ERROR: New file 'hw/vfio-user/container.c' must not have license boilerplate header text unless this file is copied from existing code with such text already present.
>   ERROR: New file 'hw/vfio-user/pci.c' must not have license boilerplate header text unless this file is copied from existing code with such text already present.
>   WARNING: Does new file 'hw/vfio-user/meson.build' need 'SPDX-License-Identifier'?
>   total: 3 errors, 1 warnings, 490 lines checked
> 
> 
> and more.

That nicely demonstrates the value of this extra check :-)

> 
> 
> Tested-by: Cédric Le Goater <clg@redhat.com>
> Reviewed-by: Cédric Le Goater <clg@redhat.com>
> 
> Thanks,
> 
> C.
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|