Re: [PATCH v3 2/9] scripts/checkpatch.pl: fix various indentation mistakes

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, May 19, 2025 at 01:12:09PM +0100, Peter Maydell wrote:
> On Thu, 15 May 2025 at 14:59, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > Various checks in the code were under-indented relative to other
> > surrounding code.
> 
> Isn't the problem here not that they're under-indented,
> but that they don't follow the "indent with hard coded
> tab characters" style that the rest of the script does?
> 
> Looking at the patch on patchew it looks like these changes do
> make the code use hardcoded tabs, but I think it would be worth
> mentioning that in the commit message. (I assumed from the wording
> -- and also because my mail client was being misleading -- that
> these changes were adding 8-space indent.)

It was a mixture of problems. Some places where using 4 spaces instead
of 1 tab, other places used a mixture of tabs and 4 spaces and one place
used only tabs, but too few of them.

> 
> Otherwise
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> thanks
> -- PMM
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|