Re: [PATCH v3 4/9] scripts/checkpatch: use new hook for ACPI test data check

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, May 19, 2025 at 01:29:14PM +0100, Peter Maydell wrote:
> On Thu, 15 May 2025 at 14:59, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > The ACPI test data check needs to analyse a list of all files in a
> > commit, so can use the new hook for processing the file list.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  scripts/checkpatch.pl | 61 ++++++++++++++++++++-----------------------
> >  1 file changed, 29 insertions(+), 32 deletions(-)
> 
> 
> 
> > @@ -1770,9 +1769,7 @@ sub process {
> >                      $line =~ /^rename (?:from|to) [\w\/\.\-]+\s*$/ ||
> >                      ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ &&
> >                       (defined($1) || defined($2)))) &&
> > -                      !(($realfile ne '') &&
> > -                        defined($acpi_testexpected) &&
> > -                        ($realfile eq $acpi_testexpected))) {
> > +                   $realfile !~ m#^tests/data/acpi/#) {
> 
> Is the indentation off on this line?

It looks like it from this diff, but it is actually correct, as it was
moved outside the inner two sets of brackets.

> 
> >                         $reported_maintainer_file = 1;
> >                         WARN("added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr);
> >                 }
> > --
> 
> Otherwise
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> thanks
> -- PMM
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|