All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Frank Li <Frank.li@nxp.com>
Cc: Jorge Marques <jorge.marques@analog.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] i3c: master: Add driver for Analog Devices I3C Controller IP
Date: Thu, 5 Jun 2025 00:00:33 +0200	[thread overview]
Message-ID: <aEDCATbPA9173lGI@shikoro> (raw)
In-Reply-To: <aECaFQzkPYdfjagK@lizhi-Precision-Tower-5810>


[-- Attachment #1.1: Type: text/plain, Size: 1229 bytes --]

Hi everyone,

On Wed, Jun 04, 2025 at 03:10:13PM -0400, Frank Li wrote:
> On Wed, Jun 04, 2025 at 05:48:58PM +0200, Jorge Marques wrote:
> > Add support for Analog Devices I3C Controller IP, an AXI-interfaced IP
> > core that supports I3C and I2C devices, multiple speed-grades and
> > I3C IBIs.
> >
> > Signed-off-by: Jorge Marques <jorge.marques@analog.com>

Hmm, I didn't get the original patches. They are probably still in the
moderated queue?

> > +#define REG_VERSION			0x000
> > +#define REG_ENABLE			0x040
> > +#define REG_IRQ_MASK			0x080
> > +#define REG_IRQ_PENDING			0x084
> > +#define REG_CMD_FIFO			0x0d4
> > +#define REG_CMDR_FIFO			0x0d8
> > +#define REG_SDO_FIFO			0x0dc
> > +#define REG_SDI_FIFO			0x0e0
> > +#define REG_IBI_FIFO			0x0e4
> > +#define REG_FIFO_STATUS			0x0e8
> > +#define REG_OPS				0x100
> > +#define REG_IBI_CONFIG			0x140
> > +#define REG_DEV_CHAR			0x180

This register set has some 'cdns'-vibe to it. Maybe an earlier version?
Not sure merging this into the cdns-driver is a good idea, the register
set looks quite different to me. Note that I don't know cdns hardware, I
just grew a habit of comparing register sets of new drivers to avoid
duplicated drivers.

Happy hacking,

   Wolfram

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 111 bytes --]

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Frank Li <Frank.li@nxp.com>
Cc: Jorge Marques <jorge.marques@analog.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] i3c: master: Add driver for Analog Devices I3C Controller IP
Date: Thu, 5 Jun 2025 00:00:33 +0200	[thread overview]
Message-ID: <aEDCATbPA9173lGI@shikoro> (raw)
In-Reply-To: <aECaFQzkPYdfjagK@lizhi-Precision-Tower-5810>

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

Hi everyone,

On Wed, Jun 04, 2025 at 03:10:13PM -0400, Frank Li wrote:
> On Wed, Jun 04, 2025 at 05:48:58PM +0200, Jorge Marques wrote:
> > Add support for Analog Devices I3C Controller IP, an AXI-interfaced IP
> > core that supports I3C and I2C devices, multiple speed-grades and
> > I3C IBIs.
> >
> > Signed-off-by: Jorge Marques <jorge.marques@analog.com>

Hmm, I didn't get the original patches. They are probably still in the
moderated queue?

> > +#define REG_VERSION			0x000
> > +#define REG_ENABLE			0x040
> > +#define REG_IRQ_MASK			0x080
> > +#define REG_IRQ_PENDING			0x084
> > +#define REG_CMD_FIFO			0x0d4
> > +#define REG_CMDR_FIFO			0x0d8
> > +#define REG_SDO_FIFO			0x0dc
> > +#define REG_SDI_FIFO			0x0e0
> > +#define REG_IBI_FIFO			0x0e4
> > +#define REG_FIFO_STATUS			0x0e8
> > +#define REG_OPS				0x100
> > +#define REG_IBI_CONFIG			0x140
> > +#define REG_DEV_CHAR			0x180

This register set has some 'cdns'-vibe to it. Maybe an earlier version?
Not sure merging this into the cdns-driver is a good idea, the register
set looks quite different to me. Note that I don't know cdns hardware, I
just grew a habit of comparing register sets of new drivers to avoid
duplicated drivers.

Happy hacking,

   Wolfram

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-06-05  9:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-04 15:48 [PATCH 0/2] Add ADI I3C Controller Jorge Marques
2025-06-04 15:48 ` Jorge Marques
2025-06-04 15:48 ` [PATCH 1/2] dt-bindings: i3c: Add adi-i3c-master Jorge Marques
2025-06-04 15:48   ` Jorge Marques
2025-06-04 18:36   ` Frank Li
2025-06-04 18:36     ` Frank Li
2025-06-06  9:40     ` Jorge Marques
2025-06-06  9:40       ` Jorge Marques
2025-06-04 15:48 ` [PATCH 2/2] i3c: master: Add driver for Analog Devices I3C Controller IP Jorge Marques
2025-06-04 15:48   ` Jorge Marques
2025-06-04 19:10   ` Frank Li
2025-06-04 19:10     ` Frank Li
2025-06-04 22:00     ` Wolfram Sang [this message]
2025-06-04 22:00       ` Wolfram Sang
2025-06-06 10:15       ` Jorge Marques
2025-06-06 10:15         ` Jorge Marques
2025-06-05 20:14     ` Wolfram Sang
2025-06-05 20:14       ` Wolfram Sang
2025-06-06 10:05     ` Jorge Marques
2025-06-06 10:05       ` Jorge Marques
2025-06-05  2:05   ` kernel test robot
2025-06-05  2:05     ` kernel test robot
2025-06-05  5:12   ` kernel test robot
2025-06-05  5:12     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEDCATbPA9173lGI@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=Frank.li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jorge.marques@analog.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.