All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 6/7] tests: shell: Adjust to ifname-based hooks
Date: Thu, 12 Jun 2025 21:33:39 +0200	[thread overview]
Message-ID: <aEsrkwSJ_sXIgOvi@calendula> (raw)
In-Reply-To: <20250612115218.4066-7-phil@nwl.cc>

On Thu, Jun 12, 2025 at 01:52:17PM +0200, Phil Sutter wrote:
[...]
> diff --git a/tests/shell/testcases/transactions/0050rule_1 b/tests/shell/testcases/transactions/0050rule_1
> deleted file mode 100755
> index 89e5f42fc9f4d..0000000000000
> --- a/tests/shell/testcases/transactions/0050rule_1
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -#!/bin/bash

I would prefer this test does not go away, this is catching for a old
kernel bug if you take a look at the history, ie. it is an old
bug reproducer so...

> -
> -set -e
> -
> -RULESET="table inet filter {
> -	flowtable ftable {
> -		hook ingress priority 0; devices = { eno1, eno0, x };
> -	}
> -
> -chain forward {
> -	type filter hook forward priority 0; policy drop;
> -
> -	ip protocol { tcp, udp } ct mark and 1 == 1 counter flow add @ftable
> -	ip6 nexthdr { tcp, udp } ct mark and 2 == 2 counter flow add @ftable
> -	ct mark and 30 == 30 ct state established,related log prefix \"nftables accept: \" level info accept
> -	}
> -}"
> -
> -$NFT -f - <<< "$RULESET" >/dev/null || exit 0

maybe simply add here:

$NFT flush ruleset

to get the same behaviour in old and new kernels.

I did not look at other tests.

Please have a look at the history of other tests to check if they are
also catching very old kernel bugs.

  reply	other threads:[~2025-06-12 19:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12 11:52 [nft PATCH 0/7] Misc fixes Phil Sutter
2025-06-12 11:52 ` [nft PATCH 1/7] netlink: Fix for potential crash parsing a flowtable Phil Sutter
2025-06-12 11:52 ` [nft PATCH 2/7] netlink: Do not allocate a bogus flowtable priority expr Phil Sutter
2025-06-12 11:52 ` [nft PATCH 3/7] monitor: Correctly print flowtable updates Phil Sutter
2025-06-15  9:47   ` Pablo Neira Ayuso
2025-06-17 10:21     ` Phil Sutter
2025-06-12 11:52 ` [nft PATCH 4/7] json: Dump flowtable hook spec only if present Phil Sutter
2025-06-12 11:52 ` [nft PATCH 5/7] tests: monitor: Fix for single flag array avoidance Phil Sutter
2025-06-12 11:52 ` [nft PATCH 6/7] tests: shell: Adjust to ifname-based hooks Phil Sutter
2025-06-12 19:33   ` Pablo Neira Ayuso [this message]
2025-06-12 19:51     ` Phil Sutter
2025-06-12 11:52 ` [nft PATCH 7/7] tests: py: Properly fix JSON equivalents for netdev/reject.t Phil Sutter
2025-06-12 19:37 ` [nft PATCH 0/7] Misc fixes Pablo Neira Ayuso
2025-06-12 20:16   ` Phil Sutter
2025-06-12 21:16 ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEsrkwSJ_sXIgOvi@calendula \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.