All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 0/7] Misc fixes
Date: Thu, 12 Jun 2025 21:37:43 +0200	[thread overview]
Message-ID: <aEsshy3Re3E6j0XE@calendula> (raw)
In-Reply-To: <20250612115218.4066-1-phil@nwl.cc>

On Thu, Jun 12, 2025 at 01:52:11PM +0200, Phil Sutter wrote:
> Patch 1 is the most relevant one as an upcoming kernel fix will trigger
> the bug being fixed by it.
> 
> Patches 2-5 are related to monitor testsuite, either fixing monitor
> output or adjusting the test cases.
> 
> Patch 6 adjusts the shell testsuite for use with recent kernels (having
> name-based interface hooks).
> 
> Patch 7 is an accidental discovery, probably I missed to add a needed
> .json.output file when implementing new tests.

Series LGTM: Please keep test 0050_rule1 in place, I would prefer not
to lose coverage for very old bugs. Please double-check other test
updates in 6/7.

Aside from that silly nitpick of mine:

Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>

Thanks

  parent reply	other threads:[~2025-06-12 19:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12 11:52 [nft PATCH 0/7] Misc fixes Phil Sutter
2025-06-12 11:52 ` [nft PATCH 1/7] netlink: Fix for potential crash parsing a flowtable Phil Sutter
2025-06-12 11:52 ` [nft PATCH 2/7] netlink: Do not allocate a bogus flowtable priority expr Phil Sutter
2025-06-12 11:52 ` [nft PATCH 3/7] monitor: Correctly print flowtable updates Phil Sutter
2025-06-15  9:47   ` Pablo Neira Ayuso
2025-06-17 10:21     ` Phil Sutter
2025-06-12 11:52 ` [nft PATCH 4/7] json: Dump flowtable hook spec only if present Phil Sutter
2025-06-12 11:52 ` [nft PATCH 5/7] tests: monitor: Fix for single flag array avoidance Phil Sutter
2025-06-12 11:52 ` [nft PATCH 6/7] tests: shell: Adjust to ifname-based hooks Phil Sutter
2025-06-12 19:33   ` Pablo Neira Ayuso
2025-06-12 19:51     ` Phil Sutter
2025-06-12 11:52 ` [nft PATCH 7/7] tests: py: Properly fix JSON equivalents for netdev/reject.t Phil Sutter
2025-06-12 19:37 ` Pablo Neira Ayuso [this message]
2025-06-12 20:16   ` [nft PATCH 0/7] Misc fixes Phil Sutter
2025-06-12 21:16 ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEsshy3Re3E6j0XE@calendula \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.