All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 3/7] monitor: Correctly print flowtable updates
Date: Tue, 17 Jun 2025 12:21:51 +0200	[thread overview]
Message-ID: <aFFBv0XBCWL4dfd_@orbyte.nwl.cc> (raw)
In-Reply-To: <aE6Wf82Lf09Qo2WK@calendula>

Hi Pablo,

On Sun, Jun 15, 2025 at 11:47:20AM +0200, Pablo Neira Ayuso wrote:
> On Thu, Jun 12, 2025 at 01:52:14PM +0200, Phil Sutter wrote:
> > An update deleting a hook from a flowtable was indistinguishable from a
> > flowtable deletion.
> 
> tests/monitor fails:
> 
> --- /tmp/tmp.CxT9laP7kj/tmp.qTOOOcfTUY  2025-06-15 11:44:55.690784518 +0200
> +++ /tmp/tmp.CxT9laP7kj/tmp.JdiYcpuAKK  2025-06-15 11:44:56.337658195 +0200
> @@ -1 +1,2 @@
> -delete flowtable ip t ft
> +delete flowtable ip t ft { hook ingress priority 0; devices = { lo }; }
> +# new generation 3 by process 2954068 (nft)

Ah crap, this requires the kernel patch 'netfilter: nf_tables:
Reintroduce shortened deletion notifications'.

I don't see how user space could work around the old kernel behaviour,
so monitor testsuite will fail for old kernels with either this patch
applied or as soon as we add a test for a flowtable update removing a
hook spec.

The only way out I see is to accept the extra data unchecked in monitor
testsuite, i.e. practically disabling the tests for flowtable deletion
or updates, which obviously sucks. No idea how to move forward now.

Sorry, Phil

  reply	other threads:[~2025-06-17 10:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12 11:52 [nft PATCH 0/7] Misc fixes Phil Sutter
2025-06-12 11:52 ` [nft PATCH 1/7] netlink: Fix for potential crash parsing a flowtable Phil Sutter
2025-06-12 11:52 ` [nft PATCH 2/7] netlink: Do not allocate a bogus flowtable priority expr Phil Sutter
2025-06-12 11:52 ` [nft PATCH 3/7] monitor: Correctly print flowtable updates Phil Sutter
2025-06-15  9:47   ` Pablo Neira Ayuso
2025-06-17 10:21     ` Phil Sutter [this message]
2025-06-12 11:52 ` [nft PATCH 4/7] json: Dump flowtable hook spec only if present Phil Sutter
2025-06-12 11:52 ` [nft PATCH 5/7] tests: monitor: Fix for single flag array avoidance Phil Sutter
2025-06-12 11:52 ` [nft PATCH 6/7] tests: shell: Adjust to ifname-based hooks Phil Sutter
2025-06-12 19:33   ` Pablo Neira Ayuso
2025-06-12 19:51     ` Phil Sutter
2025-06-12 11:52 ` [nft PATCH 7/7] tests: py: Properly fix JSON equivalents for netdev/reject.t Phil Sutter
2025-06-12 19:37 ` [nft PATCH 0/7] Misc fixes Pablo Neira Ayuso
2025-06-12 20:16   ` Phil Sutter
2025-06-12 21:16 ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aFFBv0XBCWL4dfd_@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.