All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: "Usyskin, Alexander" <alexander.usyskin@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Of mei suspend/resume unused irq code
Date: Tue, 17 Jun 2025 00:36:15 +0000	[thread overview]
Message-ID: <aFC4f9Z9J1v84Il5@gallifrey> (raw)
In-Reply-To: <CY5PR11MB6366E9288400660CC23AA8A8ED70A@CY5PR11MB6366.namprd11.prod.outlook.com>

* Usyskin, Alexander (alexander.usyskin@intel.com) wrote:
> > Subject: Of mei suspend/resume unused irq code
> > 
> > Hi,
> >   My scripts noticed that vsc_tp_request_irq() and vsc_tp_free_irq()
> > were unused, since your:
> > 
> > commit 9b5e045029d8 ("mei: vsc: Don't stop/restart mei device during
> > system suspend/resume")
> > 
> > they were only added just before that one, in the patch that fixes;
> > so I wondered whether those should be deleted as well?
> > 
> > (I've been doing unused function deleting - but don't normally do
> > recent ones, so thought I'd ask).
> 
> It looks like the oversight while removing actual HW operations from
> suspend /resume flow.
> These functions can be safely removed.

Thanks, please see the patch I've just sent:
 ' [PATCH] mei: vsc: Remove unused irq functions'

Dave

> - - 
> Thanks,
> Sasha
> 
> 
> > 
> > Dave
> > --
> >  -----Open up your eyes, open up your mind, open up your code -------
> > / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> > \        dave @ treblig.org |                               | In Hex /
> >  \ _________________________|_____ http://www.treblig.org   |_______/
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

      reply	other threads:[~2025-06-17  0:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-15 22:41 Of mei suspend/resume unused irq code Dr. David Alan Gilbert
2025-06-16  6:49 ` Usyskin, Alexander
2025-06-17  0:36   ` Dr. David Alan Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aFC4f9Z9J1v84Il5@gallifrey \
    --to=linux@treblig.org \
    --cc=alexander.usyskin@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.