Of mei suspend/resume unused irq code

Of mei suspend/resume unused irq code

[Dr. David Alan Gilbert]

Hi,
  My scripts noticed that vsc_tp_request_irq() and vsc_tp_free_irq()
were unused, since your:

commit 9b5e045029d8 ("mei: vsc: Don't stop/restart mei device during system suspend/resume")

they were only added just before that one, in the patch that fixes;
so I wondered whether those should be deleted as well?

(I've been doing unused function deleting - but don't normally do
recent ones, so thought I'd ask).

Dave
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

RE: Of mei suspend/resume unused irq code

[Usyskin, Alexander]

> Subject: Of mei suspend/resume unused irq code
> 
> Hi,
>   My scripts noticed that vsc_tp_request_irq() and vsc_tp_free_irq()
> were unused, since your:
> 
> commit 9b5e045029d8 ("mei: vsc: Don't stop/restart mei device during
> system suspend/resume")
> 
> they were only added just before that one, in the patch that fixes;
> so I wondered whether those should be deleted as well?
> 
> (I've been doing unused function deleting - but don't normally do
> recent ones, so thought I'd ask).

It looks like the oversight while removing actual HW operations from
suspend /resume flow.
These functions can be safely removed.

- - 
Thanks,
Sasha


> 
> Dave
> --
>  -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/

Re: Of mei suspend/resume unused irq code

[Dr. David Alan Gilbert]

* Usyskin, Alexander (alexander.usyskin@intel.com) wrote:
> > Subject: Of mei suspend/resume unused irq code
> > 
> > Hi,
> >   My scripts noticed that vsc_tp_request_irq() and vsc_tp_free_irq()
> > were unused, since your:
> > 
> > commit 9b5e045029d8 ("mei: vsc: Don't stop/restart mei device during
> > system suspend/resume")
> > 
> > they were only added just before that one, in the patch that fixes;
> > so I wondered whether those should be deleted as well?
> > 
> > (I've been doing unused function deleting - but don't normally do
> > recent ones, so thought I'd ask).
> 
> It looks like the oversight while removing actual HW operations from
> suspend /resume flow.
> These functions can be safely removed.

Thanks, please see the patch I've just sent:
 ' [PATCH] mei: vsc: Remove unused irq functions'

Dave

> - - 
> Thanks,
> Sasha
> 
> 
> > 
> > Dave
> > --
> >  -----Open up your eyes, open up your mind, open up your code -------
> > / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> > \        dave @ treblig.org |                               | In Hex /
> >  \ _________________________|_____ http://www.treblig.org   |_______/
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/