* Of mei suspend/resume unused irq code
@ 2025-06-15 22:41 Dr. David Alan Gilbert
2025-06-16 6:49 ` Usyskin, Alexander
0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2025-06-15 22:41 UTC (permalink / raw)
To: wentong.wu, alexander.usyskin; +Cc: linux-kernel
Hi,
My scripts noticed that vsc_tp_request_irq() and vsc_tp_free_irq()
were unused, since your:
commit 9b5e045029d8 ("mei: vsc: Don't stop/restart mei device during system suspend/resume")
they were only added just before that one, in the patch that fixes;
so I wondered whether those should be deleted as well?
(I've been doing unused function deleting - but don't normally do
recent ones, so thought I'd ask).
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: Of mei suspend/resume unused irq code
2025-06-15 22:41 Of mei suspend/resume unused irq code Dr. David Alan Gilbert
@ 2025-06-16 6:49 ` Usyskin, Alexander
2025-06-17 0:36 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Usyskin, Alexander @ 2025-06-16 6:49 UTC (permalink / raw)
To: Dr. David Alan Gilbert, wentong.wu@intel.com; +Cc: linux-kernel@vger.kernel.org
> Subject: Of mei suspend/resume unused irq code
>
> Hi,
> My scripts noticed that vsc_tp_request_irq() and vsc_tp_free_irq()
> were unused, since your:
>
> commit 9b5e045029d8 ("mei: vsc: Don't stop/restart mei device during
> system suspend/resume")
>
> they were only added just before that one, in the patch that fixes;
> so I wondered whether those should be deleted as well?
>
> (I've been doing unused function deleting - but don't normally do
> recent ones, so thought I'd ask).
It looks like the oversight while removing actual HW operations from
suspend /resume flow.
These functions can be safely removed.
- -
Thanks,
Sasha
>
> Dave
> --
> -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
> \ dave @ treblig.org | | In Hex /
> \ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Of mei suspend/resume unused irq code
2025-06-16 6:49 ` Usyskin, Alexander
@ 2025-06-17 0:36 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2025-06-17 0:36 UTC (permalink / raw)
To: Usyskin, Alexander; +Cc: linux-kernel@vger.kernel.org
* Usyskin, Alexander (alexander.usyskin@intel.com) wrote:
> > Subject: Of mei suspend/resume unused irq code
> >
> > Hi,
> > My scripts noticed that vsc_tp_request_irq() and vsc_tp_free_irq()
> > were unused, since your:
> >
> > commit 9b5e045029d8 ("mei: vsc: Don't stop/restart mei device during
> > system suspend/resume")
> >
> > they were only added just before that one, in the patch that fixes;
> > so I wondered whether those should be deleted as well?
> >
> > (I've been doing unused function deleting - but don't normally do
> > recent ones, so thought I'd ask).
>
> It looks like the oversight while removing actual HW operations from
> suspend /resume flow.
> These functions can be safely removed.
Thanks, please see the patch I've just sent:
' [PATCH] mei: vsc: Remove unused irq functions'
Dave
> - -
> Thanks,
> Sasha
>
>
> >
> > Dave
> > --
> > -----Open up your eyes, open up your mind, open up your code -------
> > / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
> > \ dave @ treblig.org | | In Hex /
> > \ _________________________|_____ http://www.treblig.org |_______/
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-17 0:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-15 22:41 Of mei suspend/resume unused irq code Dr. David Alan Gilbert
2025-06-16 6:49 ` Usyskin, Alexander
2025-06-17 0:36 ` Dr. David Alan Gilbert
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.