From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Daniel Díaz" <daniel.diaz@linaro.org>
Subject: Re: [PATCH v1 1/1] x86/defconfigs: Explicitly unset CONFIG_64BIT in i386_defconfig
Date: Mon, 23 Jun 2025 12:48:25 +0300 [thread overview]
Message-ID: <aFki6aGz60hIWvH1@smile.fi.intel.com> (raw)
In-Reply-To: <aFkihZmJXj8Z6pE2@smile.fi.intel.com>
On Mon, Jun 23, 2025 at 12:46:45PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 23, 2025 at 11:31:56AM +0200, Borislav Petkov wrote:
> > On Mon, Jun 23, 2025 at 12:21:03PM +0300, Andy Shevchenko wrote:
> > > Ah, this is just a cherry-pick (with fixing conflicts, updated Fixes
> > > and removed the last paragraph) of 5y.o. 76366050eb1b ("x86/defconfigs:
> > > Explicitly unset CONFIG_64BIT in i386_defconfig"),
> >
>> > > What?
FWIW< the bug is repetitive (third time already?) that the i386_defconfig was
refreshed with ARCH=x86_64 or so and in the result the CONFIG_64BIT is set to
'y' for 32-bit code.
> > A 5yo patch cherrypicked from somewhere has as a Fixes tag a patch from 10
> > days ago?!?!
>
> The base for my patch was the 5.y.o. patch.
>
> > > it should be standalone patch. I borrowed the commit message. So, whatever
> > > you prefer: I can send it again as the original one, one of x86 maintainers
> > > can do themselves the cherry-picking / conflict resolution, or I can resend
> > > it as mine.
> >
> > You should do a proper patch as it is done and not do a mish-mash of old and
> > new things, clarify with Daniel who's going to be the author and you should
> > write a commit message which explains the situation properly, not borrow one.
>
> It is describes situation properly. Just a test was different in this case.
> Okay, let me try again in v2.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-06-23 9:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 7:25 [PATCH v1 1/1] x86/defconfigs: Explicitly unset CONFIG_64BIT in i386_defconfig Andy Shevchenko
2025-06-23 9:06 ` Borislav Petkov
2025-06-23 9:21 ` Andy Shevchenko
2025-06-23 9:31 ` Borislav Petkov
2025-06-23 9:46 ` Andy Shevchenko
2025-06-23 9:48 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFki6aGz60hIWvH1@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=daniel.diaz@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.