From: Christoph Hellwig <hch@infradead.org>
To: Yuwen Chen <ywen.chen@foxmail.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org,
chao@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] f2fs: improve the performance of f2fs_lookup
Date: Thu, 3 Jul 2025 01:56:22 -0700 [thread overview]
Message-ID: <aGZFtmIxHDLKL6mc@infradead.org> (raw)
In-Reply-To: <tencent_0D8BB6ABAB0880DB7BFCCE35EDBC3DCFF505@qq.com>
On Thu, Jul 03, 2025 at 04:21:30PM +0800, Yuwen Chen wrote:
> On the Android system, the file creation operation will call
> the f2fs_lookup function. When there are too many files in a
> directory, the generic_ci_match operation will be called
> repeatedly in large quantities. In extreme cases, the file
> creation speed will drop to three times per second.
This files to explain what you are changing in detail, and why
(except for the very highlevel problem statement here).
>
> Signed-off-by: Yuwen Chen <ywen.chen@foxmail.com>
> ---
> fs/ext4/namei.c | 2 +-
> fs/f2fs/dir.c | 24 +++++++++++++++++-------
> fs/f2fs/f2fs.h | 3 ++-
> fs/f2fs/inline.c | 3 ++-
> fs/libfs.c | 32 +++++++++++++++++++++++++++++---
> include/linux/fs.h | 8 +++++++-
Also please split generic infrastructure changes from f2fs ones.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Yuwen Chen <ywen.chen@foxmail.com>
Cc: brauner@kernel.org, tytso@mit.edu, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, adilger.kernel@dilger.ca,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
jaegeuk@kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: improve the performance of f2fs_lookup
Date: Thu, 3 Jul 2025 01:56:22 -0700 [thread overview]
Message-ID: <aGZFtmIxHDLKL6mc@infradead.org> (raw)
In-Reply-To: <tencent_0D8BB6ABAB0880DB7BFCCE35EDBC3DCFF505@qq.com>
On Thu, Jul 03, 2025 at 04:21:30PM +0800, Yuwen Chen wrote:
> On the Android system, the file creation operation will call
> the f2fs_lookup function. When there are too many files in a
> directory, the generic_ci_match operation will be called
> repeatedly in large quantities. In extreme cases, the file
> creation speed will drop to three times per second.
This files to explain what you are changing in detail, and why
(except for the very highlevel problem statement here).
>
> Signed-off-by: Yuwen Chen <ywen.chen@foxmail.com>
> ---
> fs/ext4/namei.c | 2 +-
> fs/f2fs/dir.c | 24 +++++++++++++++++-------
> fs/f2fs/f2fs.h | 3 ++-
> fs/f2fs/inline.c | 3 ++-
> fs/libfs.c | 32 +++++++++++++++++++++++++++++---
> include/linux/fs.h | 8 +++++++-
Also please split generic infrastructure changes from f2fs ones.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2025-07-03 8:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 8:21 [PATCH] f2fs: improve the performance of f2fs_lookup Yuwen Chen
2025-07-03 8:21 ` [f2fs-dev] " Yuwen Chen
2025-07-03 8:56 ` Christoph Hellwig [this message]
2025-07-03 8:56 ` Christoph Hellwig
2025-07-04 2:43 ` [PATCH v3 1/2] libfs: reduce the number of memory allocations in generic_ci_match Yuwen Chen
2025-07-04 2:43 ` [f2fs-dev] " Yuwen Chen
2025-07-04 6:02 ` Eric Biggers
2025-07-04 6:02 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-07-07 5:27 ` Christoph Hellwig
2025-07-07 5:27 ` [f2fs-dev] " Christoph Hellwig
2025-07-08 7:11 ` Yuwen Chen
2025-07-08 7:11 ` [f2fs-dev] " Yuwen Chen
[not found] ` <tencent_3B7E5FEB5DB445A5DC50E3F3AE4DE72A7908@qq.com>
2025-07-08 9:40 ` 回复： " Christoph Hellwig
2025-07-08 9:40 ` [f2fs-dev] " Christoph Hellwig
2025-07-04 2:44 ` [PATCH v3 2/2] f2fs: improve the performance of f2fs_lookup Yuwen Chen
2025-07-04 2:44 ` [f2fs-dev] " Yuwen Chen
2025-07-03 9:54 ` [PATCH v2] " Yuwen Chen
2025-07-03 9:54 ` [f2fs-dev] " Yuwen Chen
2025-07-08 6:41 ` [PATCH v4 1/2] libfs: reduce the number of memory allocations in generic_ci_match Yuwen Chen
2025-07-08 6:41 ` [f2fs-dev] " Yuwen Chen
2025-07-09 2:42 ` [PATCH] f2fs: improve the performance of f2fs_lookup kernel test robot
2025-07-09 2:42 ` [f2fs-dev] " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGZFtmIxHDLKL6mc@infradead.org \
--to=hch@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=ywen.chen@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.