From: Christoph Hellwig <hch@infradead.org>
To: "ywen.chen" <ywen.chen@foxmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Eric Biggers <ebiggers@kernel.org>, brauner <brauner@kernel.org>,
tytso <tytso@mit.edu>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>,
"adilger.kernel" <adilger.kernel@dilger.ca>,
viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
jaegeuk <jaegeuk@kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: 回复： [PATCH v3 1/2] libfs: reduce the number of memory allocations in generic_ci_match
Date: Tue, 8 Jul 2025 02:40:30 -0700 [thread overview]
Message-ID: <aGznjhBVCkifc6BD@infradead.org> (raw)
In-Reply-To: <tencent_3B7E5FEB5DB445A5DC50E3F3AE4DE72A7908@qq.com>
On Tue, Jul 08, 2025 at 10:36:07AM +0800, ywen.chen wrote:
> 1. Use the latest version of the fsck.f2fs tool to correct
> the file system.
> 2. Use a relatively new version of the kernel. (For example,
> linear search cannot be turned off in v6.6)
>
>
> The performance gain of this commit is very obvious in scenarios
> where linear search is not turned off. In scenarios where linear
> search is turned off, no performance problems will be introduced
> either.
Turning off hashed lookups was a stupid idea and should not last. Hashed
directory lookups are the one file system improvement that significantly
improved lookup performance. So don't work around it, because otherwise
you will be creating more optimizations to work around the lack of
hashed lookups.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: "ywen.chen" <ywen.chen@foxmail.com>
Cc: Eric Biggers <ebiggers@kernel.org>, brauner <brauner@kernel.org>,
tytso <tytso@mit.edu>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>,
Christoph Hellwig <hch@infradead.org>,
"adilger.kernel" <adilger.kernel@dilger.ca>,
viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
jaegeuk <jaegeuk@kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [f2fs-dev] 回复： [PATCH v3 1/2] libfs: reduce the number of memory allocations in generic_ci_match
Date: Tue, 8 Jul 2025 02:40:30 -0700 [thread overview]
Message-ID: <aGznjhBVCkifc6BD@infradead.org> (raw)
In-Reply-To: <tencent_3B7E5FEB5DB445A5DC50E3F3AE4DE72A7908@qq.com>
On Tue, Jul 08, 2025 at 10:36:07AM +0800, ywen.chen wrote:
> 1. Use the latest version of the fsck.f2fs tool to correct
> the file system.
> 2. Use a relatively new version of the kernel. (For example,
> linear search cannot be turned off in v6.6)
>
>
> The performance gain of this commit is very obvious in scenarios
> where linear search is not turned off. In scenarios where linear
> search is turned off, no performance problems will be introduced
> either.
Turning off hashed lookups was a stupid idea and should not last. Hashed
directory lookups are the one file system improvement that significantly
improved lookup performance. So don't work around it, because otherwise
you will be creating more optimizations to work around the lack of
hashed lookups.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2025-07-08 9:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 8:21 [PATCH] f2fs: improve the performance of f2fs_lookup Yuwen Chen
2025-07-03 8:21 ` [f2fs-dev] " Yuwen Chen
2025-07-03 8:56 ` Christoph Hellwig
2025-07-03 8:56 ` [f2fs-dev] " Christoph Hellwig
2025-07-04 2:43 ` [PATCH v3 1/2] libfs: reduce the number of memory allocations in generic_ci_match Yuwen Chen
2025-07-04 2:43 ` [f2fs-dev] " Yuwen Chen
2025-07-04 6:02 ` Eric Biggers
2025-07-04 6:02 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-07-07 5:27 ` Christoph Hellwig
2025-07-07 5:27 ` [f2fs-dev] " Christoph Hellwig
2025-07-08 7:11 ` Yuwen Chen
2025-07-08 7:11 ` [f2fs-dev] " Yuwen Chen
[not found] ` <tencent_3B7E5FEB5DB445A5DC50E3F3AE4DE72A7908@qq.com>
2025-07-08 9:40 ` Christoph Hellwig [this message]
2025-07-08 9:40 ` [f2fs-dev] 回复： " Christoph Hellwig
2025-07-04 2:44 ` [PATCH v3 2/2] f2fs: improve the performance of f2fs_lookup Yuwen Chen
2025-07-04 2:44 ` [f2fs-dev] " Yuwen Chen
2025-07-03 9:54 ` [PATCH v2] " Yuwen Chen
2025-07-03 9:54 ` [f2fs-dev] " Yuwen Chen
2025-07-08 6:41 ` [PATCH v4 1/2] libfs: reduce the number of memory allocations in generic_ci_match Yuwen Chen
2025-07-08 6:41 ` [f2fs-dev] " Yuwen Chen
2025-07-09 2:42 ` [PATCH] f2fs: improve the performance of f2fs_lookup kernel test robot
2025-07-09 2:42 ` [f2fs-dev] " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGznjhBVCkifc6BD@infradead.org \
--to=hch@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=ywen.chen@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.