[PATCH] dl: fix grub_dl_is_persistent() for EMU

[PATCH] dl: fix grub_dl_is_persistent() for EMU

[Gary Lin via Grub-devel]

When attempting to build grub-emu, the compilation failed with the
following error message:

include/grub/dl.h: In function ‘grub_dl_is_persistent’:
include/grub/dl.h:262:1: error: no return statement in function returning non-void [-Werror=return-type]

To avoid the erorr, make the function always return 0.

Fixes: ba8eadde6be1 (dl: Provide a fake grub_dl_set_persistent() and grub_dl_is_persistent() for the emu target)

Signed-off-by: Gary Lin <glin@suse.com>
Cc: Daniel Axtens <dja@axtens.net>
Cc: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
---
 include/grub/dl.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/grub/dl.h b/include/grub/dl.h
index b8135c8f3..53bf9abdb 100644
--- a/include/grub/dl.h
+++ b/include/grub/dl.h
@@ -259,6 +259,7 @@ grub_dl_set_persistent (grub_dl_t mod __attribute__((unused)))
 static inline int
 grub_dl_is_persistent (grub_dl_t mod __attribute__((unused)))
 {
+  return 0;
 }
 #else
 static inline void
-- 
2.43.0


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] dl: fix grub_dl_is_persistent() for EMU

[Sudhakar Kuppusamy]

Reviewed-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>


> On 3 Jul 2025, at 11:39 AM, Gary Lin <glin@suse.com> wrote:
> 
> When attempting to build grub-emu, the compilation failed with the
> following error message:
> 
> include/grub/dl.h: In function ‘grub_dl_is_persistent’:
> include/grub/dl.h:262:1: error: no return statement in function returning non-void [-Werror=return-type]
> 
> To avoid the erorr, make the function always return 0.
> 
> Fixes: ba8eadde6be1 (dl: Provide a fake grub_dl_set_persistent() and grub_dl_is_persistent() for the emu target)
> 
> Signed-off-by: Gary Lin <glin@suse.com>
> Cc: Daniel Axtens <dja@axtens.net>
> Cc: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
> ---
> include/grub/dl.h | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/include/grub/dl.h b/include/grub/dl.h
> index b8135c8f3..53bf9abdb 100644
> --- a/include/grub/dl.h
> +++ b/include/grub/dl.h
> @@ -259,6 +259,7 @@ grub_dl_set_persistent (grub_dl_t mod __attribute__((unused)))
> static inline int
> grub_dl_is_persistent (grub_dl_t mod __attribute__((unused)))
> {
> +  return 0;
> }
> #else
> static inline void
> -- 
> 2.43.0
> 


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] dl: fix grub_dl_is_persistent() for EMU

[Daniel Kiper via Grub-devel]

On Thu, Jul 03, 2025 at 12:41:26PM +0530, Sudhakar Kuppusamy wrote:
> Reviewed-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel