Re: [PATCH net 3/3] riscv: dts: thead: Add APB clocks for TH1520 GMACs

From: Drew Fustini <fustini@kernel.org>
To: Yao Zi <ziyao@disroot.org>
Cc: Guo Ren <guoren@kernel.org>, Fu Wei <wefu@redhat.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>,
	Jisheng Zhang <jszhang@kernel.org>,
	linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 3/3] riscv: dts: thead: Add APB clocks for TH1520 GMACs
Date: Tue, 29 Jul 2025 10:45:54 -0700	[thread overview]
Message-ID: <aIkI0vHDD1CfxAkl@x1> (raw)
In-Reply-To: <20250729093734.40132-4-ziyao@disroot.org>

On Tue, Jul 29, 2025 at 09:37:34AM +0000, Yao Zi wrote:
> Describe perisys-apb4-hclk as the APB clock for TH1520 SoC, which is
> essential for accessing GMAC glue registers.
> 
> Fixes: 7e756671a664 ("riscv: dts: thead: Add TH1520 ethernet nodes")
> Signed-off-by: Yao Zi <ziyao@disroot.org>
> ---
>  arch/riscv/boot/dts/thead/th1520.dtsi | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> index 42724bf7e90e..03f1d7319049 100644
> --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> @@ -297,8 +297,9 @@ gmac1: ethernet@ffe7060000 {
>  			reg-names = "dwmac", "apb";
>  			interrupts = <67 IRQ_TYPE_LEVEL_HIGH>;
>  			interrupt-names = "macirq";
> -			clocks = <&clk CLK_GMAC_AXI>, <&clk CLK_GMAC1>;
> -			clock-names = "stmmaceth", "pclk";
> +			clocks = <&clk CLK_GMAC_AXI>, <&clk CLK_GMAC1>,
> +				 <&clk CLK_PERISYS_APB4_HCLK>;
> +			clock-names = "stmmaceth", "pclk", "apb";
>  			snps,pbl = <32>;
>  			snps,fixed-burst;
>  			snps,multicast-filter-bins = <64>;
> @@ -319,8 +320,9 @@ gmac0: ethernet@ffe7070000 {
>  			reg-names = "dwmac", "apb";
>  			interrupts = <66 IRQ_TYPE_LEVEL_HIGH>;
>  			interrupt-names = "macirq";
> -			clocks = <&clk CLK_GMAC_AXI>, <&clk CLK_GMAC0>;
> -			clock-names = "stmmaceth", "pclk";
> +			clocks = <&clk CLK_GMAC_AXI>, <&clk CLK_GMAC0>,
> +				 <&clk CLK_PERISYS_APB4_HCLK>;
> +			clock-names = "stmmaceth", "pclk", "apb";
>  			snps,pbl = <32>;
>  			snps,fixed-burst;
>  			snps,multicast-filter-bins = <64>;
> -- 
> 2.50.1
> 

Thank you for determining that this clock is needed for the GMAC.

Reviewed-by: Drew Fustini <fustini@kernel.org>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv