Re: [PATCH net 1/3] dt-bindings: net: thead,th1520-gmac: Describe APB interface clock

From: Yao Zi <ziyao@disroot.org>
To: Conor Dooley <conor@kernel.org>
Cc: Drew Fustini <fustini@kernel.org>, Guo Ren <guoren@kernel.org>,
	Fu Wei <wefu@redhat.com>, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>,
	Jisheng Zhang <jszhang@kernel.org>,
	linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/3] dt-bindings: net: thead,th1520-gmac: Describe APB interface clock
Date: Wed, 30 Jul 2025 02:37:09 +0000	[thread overview]
Message-ID: <aImFVW1Pl_QHijWx@pie> (raw)
In-Reply-To: <20250729-canal-stimuli-492b4550108c@spud>

On Tue, Jul 29, 2025 at 06:43:42PM +0100, Conor Dooley wrote:
> On Tue, Jul 29, 2025 at 09:37:32AM +0000, Yao Zi wrote:
> > Besides ones for GMAC core and peripheral registers, the TH1520 GMAC
> > requires one more clock for configuring APB glue registers. Describe
> > it in the binding.
> > 
> > Though the clock is essential for operation, it's not marked as required
> > for now to avoid introducing new dt-binding warnings to existing dts.
> 
> Nah, introduce the warnings. If the clock is required for operation, it
> should be marked as such. You've made it optional in the driver, which
> is the important part (backwards compatible) and you've got the dts
> patch in the series.

Thanks for the confirmation, will remove minItems in v2.

Regards,
Yao Zi

> > 
> > Fixes: f920ce04c399 ("dt-bindings: net: Add T-HEAD dwmac support")
> > Signed-off-by: Yao Zi <ziyao@disroot.org>
> > ---
> >  .../devicetree/bindings/net/thead,th1520-gmac.yaml        | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml b/Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml
> > index 6d9de3303762..fea9fbc1d006 100644
> > --- a/Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml
> > @@ -59,14 +59,18 @@ properties:
> >        - const: apb
> >  
> >    clocks:
> > +    minItems: 2
> >      items:
> >        - description: GMAC main clock
> >        - description: Peripheral registers interface clock
> > +      - description: APB glue registers interface clock
> >  
> >    clock-names:
> > +    minItems: 2
> >      items:
> >        - const: stmmaceth
> >        - const: pclk
> > +      - const: apb
> >  
> >    interrupts:
> >      items:
> > @@ -88,8 +92,8 @@ examples:
> >          compatible = "thead,th1520-gmac", "snps,dwmac-3.70a";
> >          reg = <0xe7070000 0x2000>, <0xec003000 0x1000>;
> >          reg-names = "dwmac", "apb";
> > -        clocks = <&clk 1>, <&clk 2>;
> > -        clock-names = "stmmaceth", "pclk";
> > +        clocks = <&clk 1>, <&clk 2>, <&clk 3>;
> > +        clock-names = "stmmaceth", "pclk", "apb";
> >          interrupts = <66>;
> >          interrupt-names = "macirq";
> >          phy-mode = "rgmii-id";
> > -- 
> > 2.50.1
> > 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv