Re: [RFC net-next 01/17] net/smc: Remove __init marker from smc_core_init()

[Dust Li <dust.li@linux.alibaba.com>]

On 2025-08-06 17:41:06, Alexandra Winter wrote:
>Remove the __init marker because smc_core_init() is not the
>init function of the smc module and for consistency with
>smc_core_exit() which neither has an __exit marker.

Have you seen a real warning or error because of the __init marker ?

I think the __init marker is just to tell the kernel this function
will only be called during initialization. So it doesn't need to
be the module's init function.

Best regards,
Dust

>
>Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
>---
> net/smc/smc_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/net/smc/smc_core.c b/net/smc/smc_core.c
>index 262746e304dd..67f9e0b83ebc 100644
>--- a/net/smc/smc_core.c
>+++ b/net/smc/smc_core.c
>@@ -2758,7 +2758,7 @@ static struct notifier_block smc_reboot_notifier = {
> 	.notifier_call = smc_core_reboot_event,
> };
> 
>-int __init smc_core_init(void)
>+int smc_core_init(void)
> {
> 	return register_reboot_notifier(&smc_reboot_notifier);
> }
>-- 
>2.48.1