Re: [RFC net-next 10/17] net/dibs: Define dibs_client_ops and dibs_dev_ops

[Dust Li <dust.li@linux.alibaba.com>]

On 2025-08-11 17:12:46, Alexandra Winter wrote:
>
>
>On 10.08.25 16:53, Dust Li wrote:
>> Hi Winter,
>> 
>> I feel a bit hard for me to review the code especially with so many
>> intermediate parts. I may need more time to review these.
>> 
>> Seperate such a big refine patch is hard. Maybe put the
>> small parts in the front and the final one in the last to reduce
>> the intermediate part as much as possible ? I'm not sure.
>> 
>> Best regards,
>> Dust
>
>I can understand that very well. I tried hard to split up the dibs layer implementation
>into consumable pieces, while preserving the functionality of smc-d, ism and loopback at
>each intermediate step, so it is always bisectable.
>
>I know this patch  "[RFC net-next 10/17] net/dibs: Define dibs_client_ops and dibs_dev_ops"
>and "[RFC net-next 16/17] net/dibs: Move data path to dibs layer" are rather large, but I
>could not find a way to split them up without temporarily breaking functionality.
>If you have any ideas, please let me know.
>
>You write:
>> Maybe put the small parts in the front and the final one in the last
>I am not sure I understand, what exactly you have in mind here. Are you asking
>for even larger patches?

Yes, that’s what I had in mind. :)
Of course, if it seems to complicate things, please disregard it.

>
>> I may need more time to review these.
>FYI: I will be on vacation the last 2 weeks of August.
>Would you rather have an RFC v2 this week with all the changes, I made so far?
>Or would you prefer that you continue reviewing this RFC and I send a new version
>in the first week of September?

No warries, both OK for me now.

Best regards,
Dust