From: Christoph Hellwig <hch@infradead.org>
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v3] f2fs: introduce flush_policy sysfs entry
Date: Mon, 11 Aug 2025 03:52:14 -0700 [thread overview]
Message-ID: <aJnLXmepVBD4V2QH@infradead.org> (raw)
In-Reply-To: <20250807034838.3829794-1-chao@kernel.org>
On Thu, Aug 07, 2025 at 11:48:38AM +0800, Chao Yu wrote:
> This patch introduces a new sysfs entry /sys/fs/f2fs/<disk>/flush_policy
> in order to tune performance of f2fs data flush flow.
>
> For example, checkpoint will use REQ_FUA to persist CP metadata, however,
> some kind device has bad performance on REQ_FUA command, result in that
> checkpoint being blocked for long time, w/ this sysfs entry, we can give
> an option to use REQ_PREFLUSH command instead of REQ_FUA during checkpoint,
> it can help to mitigate long latency of checkpoint.
That's and odd place to deal with this. If that's a real issue it
should be a block layer tweak to disable FUA, potentially with a quirk
entry in the driver to disable it rather than having to touch a file
system sysfs attribute.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-block@vger.kernel.org, jaegeuk@kernel.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: introduce flush_policy sysfs entry
Date: Mon, 11 Aug 2025 03:52:14 -0700 [thread overview]
Message-ID: <aJnLXmepVBD4V2QH@infradead.org> (raw)
In-Reply-To: <20250807034838.3829794-1-chao@kernel.org>
On Thu, Aug 07, 2025 at 11:48:38AM +0800, Chao Yu wrote:
> This patch introduces a new sysfs entry /sys/fs/f2fs/<disk>/flush_policy
> in order to tune performance of f2fs data flush flow.
>
> For example, checkpoint will use REQ_FUA to persist CP metadata, however,
> some kind device has bad performance on REQ_FUA command, result in that
> checkpoint being blocked for long time, w/ this sysfs entry, we can give
> an option to use REQ_PREFLUSH command instead of REQ_FUA during checkpoint,
> it can help to mitigate long latency of checkpoint.
That's and odd place to deal with this. If that's a real issue it
should be a block layer tweak to disable FUA, potentially with a quirk
entry in the driver to disable it rather than having to touch a file
system sysfs attribute.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2025-08-11 10:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 3:48 [f2fs-dev] [PATCH v3] f2fs: introduce flush_policy sysfs entry Chao Yu via Linux-f2fs-devel
2025-08-07 3:48 ` Chao Yu
2025-08-07 5:31 ` [f2fs-dev] " Zhiguo Niu
2025-08-07 5:31 ` Zhiguo Niu
2025-08-11 10:52 ` Christoph Hellwig [this message]
2025-08-11 10:52 ` Christoph Hellwig
2025-08-11 13:44 ` Bart Van Assche
2025-08-11 13:44 ` [f2fs-dev] " Bart Van Assche via Linux-f2fs-devel
2025-08-12 6:39 ` Chao Yu
2025-08-12 6:39 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-08-12 6:28 ` Chao Yu
2025-08-12 6:28 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-08-12 7:32 ` Christoph Hellwig
2025-08-12 7:32 ` [f2fs-dev] " Christoph Hellwig
2025-08-12 7:53 ` Chao Yu
2025-08-12 7:53 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-08-12 7:59 ` Christoph Hellwig
2025-08-12 7:59 ` [f2fs-dev] " Christoph Hellwig
2025-08-12 8:22 ` Chao Yu
2025-08-12 8:22 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJnLXmepVBD4V2QH@infradead.org \
--to=hch@infradead.org \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.