All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dongjin Kim <tobetter@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Heiko Stuebner <heiko@sntech.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Change ethernet TXD timing delay value
Date: Tue, 19 Aug 2025 16:48:50 +0900	[thread overview]
Message-ID: <aKQsYndrYStGTfoL@anyang> (raw)
In-Reply-To: <380246b7-7e7a-4843-b82b-2e8d74e01ad5@linaro.org>

On Tue, Aug 19, 2025 at 08:42:55AM +0200, Krzysztof Kozlowski wrote:
> On 19/08/2025 06:50, Dongjin Kim wrote:
> > Very poor network performance is observed on the ODROID-M1 Board
> > (REV 1.0 20220613) when running iperf3 (under 200Mbits/sec), and
> > this problem can be resolved after changing the value of TXD
> > timing to 0x35 from 0x4f.
> > 
> > Signed-off-by: Dongjin Kim <tobetter@gmail.com>
> > Change-Id: Idecd246e3fe93447b6e3e9b165d077d2050bbd75
> 
> 
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.

Thanks. I realized that I sent unmodified file that includes
"Change-Id:".

> 
> You CC-ed an address, which suggests you do not work on mainline kernel
> or you do not use get_maintainers.pl/b4/patman. Please rebase and always
> work on mainline or start using mentioned tools, so correct addresses
> will be used.

I've rebased to the master branch, so let me send the patch again.

> 
> Best regards,
> Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Dongjin Kim <tobetter@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Heiko Stuebner <heiko@sntech.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Change ethernet TXD timing delay value
Date: Tue, 19 Aug 2025 16:48:50 +0900	[thread overview]
Message-ID: <aKQsYndrYStGTfoL@anyang> (raw)
In-Reply-To: <380246b7-7e7a-4843-b82b-2e8d74e01ad5@linaro.org>

On Tue, Aug 19, 2025 at 08:42:55AM +0200, Krzysztof Kozlowski wrote:
> On 19/08/2025 06:50, Dongjin Kim wrote:
> > Very poor network performance is observed on the ODROID-M1 Board
> > (REV 1.0 20220613) when running iperf3 (under 200Mbits/sec), and
> > this problem can be resolved after changing the value of TXD
> > timing to 0x35 from 0x4f.
> > 
> > Signed-off-by: Dongjin Kim <tobetter@gmail.com>
> > Change-Id: Idecd246e3fe93447b6e3e9b165d077d2050bbd75
> 
> 
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.

Thanks. I realized that I sent unmodified file that includes
"Change-Id:".

> 
> You CC-ed an address, which suggests you do not work on mainline kernel
> or you do not use get_maintainers.pl/b4/patman. Please rebase and always
> work on mainline or start using mentioned tools, so correct addresses
> will be used.

I've rebased to the master branch, so let me send the patch again.

> 
> Best regards,
> Krzysztof

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-08-19  8:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-19  4:50 [PATCH] arm64: dts: rockchip: Change ethernet TXD timing delay value Dongjin Kim
2025-08-19  4:50 ` Dongjin Kim
2025-08-19  6:42 ` Krzysztof Kozlowski
2025-08-19  6:42   ` Krzysztof Kozlowski
2025-08-19  7:48   ` Dongjin Kim [this message]
2025-08-19  7:48     ` Dongjin Kim
2025-08-19 16:03 ` Andrew Lunn
2025-08-19 16:03   ` Andrew Lunn
2025-08-19 18:44   ` Heiko Stübner
2025-08-19 18:44     ` Heiko Stübner
2025-08-20  2:45   ` Dongjin Kim
2025-08-20  2:45     ` Dongjin Kim
2025-09-03 16:10     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aKQsYndrYStGTfoL@anyang \
    --to=tobetter@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.