From: Carlos Llamas <cmllamas@google.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
Pedro Falcato <pfalcato@suse.de>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
"open list:MEMORY MAPPING" <linux-mm@kvack.org>
Subject: Re: [PATCH] mm/mremap: fix regression in vrm->new_addr check
Date: Thu, 28 Aug 2025 14:13:13 +0000 [thread overview]
Message-ID: <aLBj-UanVYBax9aE@google.com> (raw)
In-Reply-To: <8a4dc910-5237-48aa-8abb-a6d5044bc290@lucifer.local>
On Thu, Aug 28, 2025 at 06:38:09AM +0100, Lorenzo Stoakes wrote:
> I'm curious why only you guys have seen it, a theory is bionic is sending random
> stuff to this parameter when unspecified, and glibc is not.
I honestly don't know and it could very well be only with bionic or
clang. I'll try to find out more about this, maybe glibc implementation
zeros out the 'new_addres' register and bionic doesn't.
>
> But obviously this fix is correct, and the original code needs fixing.
>
> Please respin a v2 as per above.
Sounds good.
next prev parent reply other threads:[~2025-08-28 14:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 3:26 [PATCH] mm/mremap: fix regression in vrm->new_addr check Carlos Llamas
2025-08-28 3:43 ` Liam R. Howlett
2025-08-28 4:06 ` Carlos Llamas
2025-08-28 4:16 ` Carlos Llamas
2025-08-28 5:38 ` Lorenzo Stoakes
2025-08-28 14:13 ` Carlos Llamas [this message]
2025-08-28 14:21 ` Vlastimil Babka
2025-08-28 14:22 ` Lorenzo Stoakes
2025-08-28 14:29 ` Carlos Llamas
2025-08-28 14:31 ` Vlastimil Babka
2025-08-28 14:26 ` [PATCH v2] " Carlos Llamas
2025-08-28 14:30 ` Vlastimil Babka
2025-08-28 14:34 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLBj-UanVYBax9aE@google.com \
--to=cmllamas@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=pfalcato@suse.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.